Genereally repeated minit and mshutdown sequences ought something to be supported by extensions. I believe there's other circumstances where this may happen (with apache?! not sure right now).

@dstogov From a purely functional point of view, this adds functionality, which is not possible to achieve in any other way. So, I think we should do it in any case, only the specific semantics might be argued.

Great to hear that you've managed to understand and fix your issue :-)

Skip PHP on newly added span sampling tests

Skip sss011 parametric test for PHP

Merge pull request #997 from DataDog/bob/skip-php-drop-sampling

Skip PHP on newly added span sampling tests

Description

These got added after PHP tests were merged and are failing PHP now.

Workflow

1. ⚠️⚠️ Create your PR as draft (we're receiving lot of PR, it saves us lot of time) ⚠️⚠️
2. Follows the style guidelines of this project (See how to easily lint the code)
3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Please refer to the documentation to run all scenarios in your PR if needed.

Once your PR is reviewed, you can merge it ! :heart:

Skip sss011 parametric test for PHP

Allow DDTrace\install_hook to take any callable

Also by default, apply closure hooks to the actual closure source; adding a flag DDTrace\HOOK_INSTANCE to only hook the specific Closure instance.

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Allow DDTrace\install_hook to take any callable

Also by default, apply closure hooks to the actual closure source; adding a flag DDTrace\HOOK_INSTANCE to only hook the specific Closure instance.

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Allow DDTrace\install_hook to take any callable

Also by default, apply closure hooks to the actual closure source; adding a flag DDTrace\HOOK_INSTANCE to only hook the specific Closure instance.

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Allow DDTrace\install_hook to take any callable

Also by default, apply closure hooks to the actual closure source; adding a flag DDTrace\HOOK_INSTANCE to only hook the specific Closure instance.

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Allow DDTrace\install_hook to take any callable

Also by default, apply closure hooks to the actual closure source; adding a flag DDTrace\HOOK_INSTANCE to only hook the specific Closure instance.

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Description

Also by default, apply closure hooks to the actual closure source; adding a flag DDTrace\HOOK_INSTANCE to only hook the specific Closure instance. Given that the API is new and everyone I talked to was surprised by the behaviour, I'm changing it.

Readiness checklist

• [ ] (only for Members) Changelog has been added to the release document.
• [x] Tests added for this feature/bug.

Reviewer checklist

• [ ] Appropriate labels assigned.
• [ ] Milestone is set.
• [ ] Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

Allow DDTrace\install_hook to take any callable

Also by default, apply closure hooks to the actual closure source; adding a flag DDTrace\HOOK_INSTANCE to only hook the specific Closure instance.

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Fix crash with file included within classes

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Fix crash with file included within classes

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Description

These got added after PHP tests were merging and are failing PHP now.

Workflow

1. ⚠️⚠️ Create your PR as draft (we're receiving lot of PR, it saves us lot of time) ⚠️⚠️
2. Follows the style guidelines of this project (See how to easily lint the code)
3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Please refer to the documentation to run all scenarios in your PR if needed.

Once your PR is reviewed, you can merge it ! :heart:

Description

Extends the install_hook API to also allow listening for file inclusions.

Readiness checklist

• [ ] (only for Members) Changelog has been added to the release document.
• [x] Tests added for this feature/bug.

Reviewer checklist

• [ ] Appropriate labels assigned.
• [ ] Milestone is set.
• [ ] Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

Setup python 3.9 for system tests

Add apt-get update

Add fixes for parametric testsuite (#1988)

• Add parametric tests to CI

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

• Make w3c headers more strict

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

• Fix DD_SPAN_SAMPLING_RULES to use question marks instead of dots as single character placeholders

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

• More checking to conform with parametric tests

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

• Reset decision maker if tag-propagated sampling priority changed

Also properly set decision maker = default, if the sampling priority was propagated to us without decision maker tag.

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Fix exceptions and errors in auto_prepend_file (#1987)

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Merge pull request #1986 from DataDog/cbeauchesne/systemtests-python-3.9

Setup python 3.9 for system tests

Add file hooking to DDTrace\install_hook

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Add file hooking to DDTrace\install_hook

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

Add file hooking to DDTrace\install_hook

Signed-off-by: Bob Weinand bob.weinand@datadoghq.com

@mvorisek The fundamental difference between errors and exceptions is that the one is propagated, while the other is in place. Errors are emitted where they are triggered, exceptions are emitted at the bottom of the stack if not caught.

There can be many errors during runs, but exceptions are fundamentally meant to just fallthrough once.