brutto
Repos
23
Followers
4
Following
3

Events

Created at 2 weeks ago
Created at 3 weeks ago
started
Created at 3 weeks ago
Monolog v3 breaking change for NoOperationMonologHandler::write method

@lesstif monolog v2 not compatible with v3, so i think you can drop v2 support with next release.

Created at 4 weeks ago
Comment model body

To correct working with comments Comment::$body must be AtlassianDocumentFormat type instead of string.

// Comment.php
...
public AtlassianDocumentFormat $body;
...

public function setBody(AtlassianDocumentFormat $body): static
{
...
Created at 4 weeks ago
Transition by untranslated status name not working

In doc for issue transition was said to use Transition::setUntranslatedName() method for "JIRA with local language profiles".

But if you use it transition id calculated wrong: Instead of transition id used status id So you get errors like {"errorMessages":["Transition id '<real-status-id>' is not valid for this issue."],"errors":{}}.

Problem in IssueService::findTransitonIdByUntranslatedName.

Created at 4 weeks ago
Cannot create Version

Model Version src/Issue/Version.php has $releaseDate prop described as follow:

...
public ?DateTimeInterface $releaseDate;
...

But on VersionService::create() we have this kind of:

    public function create($version)
    {
        if ($version->releaseDate instanceof \DateTimeInterface) {
            $version->releaseDate = $version->releaseDate->format('Y-m-d');
        }
     ...

Runing with strict-type enabledyou will get one of two errors:

  • Cannot assign string to property JiraCloud\Issue\Version::$releaseDate of type ?DateTimeInterface
  • Typed property JiraCloud\Issue\Version::$releaseDate must not be accessed before initialization

To fix it just add null value @ Version:

public ?DateTimeInterface $releaseDate = null; 
Created at 1 month ago
IssueField::addDescriptionParagraph() signature

Public method IssueField::addDescriptionParagraph() has required ADFMarkType in second argument, so you can not use this method without it. But internal AtlassianDocumentFormat::addParagraph() allowed null for mark type:

// ok
$doc = new AtlassianDocumentFormat();
$doc->addParagraph($mrLink);

$issueField = new IssueField();
$issueField->setDescription($doc);
// failed
$doc = new AtlassianDocumentFormat();
$doc->addParagraph($mrLink);

$issueField = new IssueField();
$issueField->addDescriptionParagraph($text); // <-- HERE, need set mark type
Created at 1 month ago
IssueField::addDescriptionParagraph() signature

Yep, ic. Thanks for response.

PS: I already found that example, but i just want have simple solution to add some simple text to Issue /wo any external library.

Created at 1 month ago
pull request opened
Change release management endpoints

Change release management endpoints according to this doc https://docs.gitlab.com/ee/api/releases/. Current one not working on version 15.3.1

Created at 1 month ago

Change release management endpoints

Change release management endpoints according to this doc https://docs.gitlab.com/ee/api/releases/. Current one not working on version 15.3.1

Created at 1 month ago
Created at 1 month ago
IssueField::addDescriptionParagraph() signature

Public method IssueField::addDescriptionParagraph() has required ADFMarkType in second argument, so you can not use this method without it. But internal AtlassianDocumentFormat::addParagraph() allowed null for mark type:

// ok
$doc = new AtlassianDocumentFormat();
$doc->addParagraph($mrLink);

$issueField = new IssueField();
$issueField->setDescription($doc);
// failed
$doc = new AtlassianDocumentFormat();
$doc->addParagraph($mrLink);

$issueField = new IssueField();
$issueField->addDescriptionParagraph($text); // <-- HERE, need set mark type
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
InnerBrowser Interfaces are missing

What are you trying to achieve?

Current project use v4 and api-tests are running well. I try to ugrade from v4 to v5. Update core and modules:

# composer.json
...
        "codeception/codeception": "^5.0",
        "codeception/module-asserts": "^3.0",
        "codeception/module-cli": "^2.0",
        "codeception/module-rest": "^3.0",
        "codeception/module-phpbrowser": "^3.0",
...

What do you get instead?

When run tests i get this error:

Fatal error: Uncaught Error: Interface "Codeception\Lib\Interfaces\Web" not found in /app/www/vendor/codeception/lib-innerbrowser/src/Codeception/Lib/InnerBrowser.php:43

In my test code i use self-wrote мodule based on InnerBrowser as $connectionModule for REST-module

# api.suite.php
...
        - \Helper\ApplicationHelper
        - REST:
            depends: \Helper\ApplicationHelper
            part: Json
            shortDebugResponse: 250
...

Details

  • Codeception version: 5.0
  • PHP Version: 8.1
  • Operating System: Alpine Linux
  • Installation type: Composer
  • Suite configuration:

Searching for this missing interface i found that it was presented in v4.2 (https://github.com/Codeception/Codeception/tree/4.2/src/Codeception/Lib/Interfaces), but missing from v5 (https://github.com/Codeception/Codeception/tree/5.0/src/Codeception/Lib/Interfaces).

Also any other InnerBrowser interface are missing too. Trying to find information about some kind of migrations into separate module, but found nothing.

BTW: Thanks for you work!

Created at 1 month ago
issue comment
InnerBrowser Interfaces are missing

@Naktibalda Thanks for a point.

Checked what version of codeception/lib-innerbrowser composer was used for the latest version of codeception/php-browser module in my project and find that it was 3.0.1 only (update/reinstall with -W not working). So dug deeper and found that problem was with internal dependency guzzle/psr7:1.9 library that not supported by codeception/lib-web (only 2+).

So update guzzle/psr7 up to 2+ version fix this problem and codeception/lib-web start install correclty.

PS: maybe this kind of behavior related to *@dev dependencies in module libraries and you can not see the real issue.

Created at 1 month ago
issue comment
InnerBrowser Interfaces are missing

@Naktibalda 3.1.2 have no such interfaces too https://github.com/Codeception/lib-innerbrowser/blob/3.1.2/src/Codeception/Lib/InnerBrowser.php 8(

Created at 1 month ago
InnerBrowser Interfaces are missing

What are you trying to achieve?

Current project use v4 and api-tests are running well. I try to ugrade from v4 to v5. Update core and modules:

# composer.json
...
        "codeception/codeception": "^5.0",
        "codeception/module-asserts": "^3.0",
        "codeception/module-cli": "^2.0",
        "codeception/module-rest": "^3.0",
        "codeception/module-phpbrowser": "^3.0",
...

What do you get instead?

When run tests i get this error:

Fatal error: Uncaught Error: Interface "Codeception\Lib\Interfaces\Web" not found in /app/www/vendor/codeception/lib-innerbrowser/src/Codeception/Lib/InnerBrowser.php:43

In my test code i use self-wrote мodule based on InnerBrowser as $connectionModule for REST-module

# api.suite.php
...
        - \Helper\ApplicationHelper
        - REST:
            depends: \Helper\ApplicationHelper
            part: Json
            shortDebugResponse: 250
...

Details

  • Codeception version: 5.0
  • PHP Version: 8.1
  • Operating System: Alpine Linux
  • Installation type: Composer
  • Suite configuration:

Searching for this missing interface i found that it was presented in v4.2 (https://github.com/Codeception/Codeception/tree/4.2/src/Codeception/Lib/Interfaces), but missing from v5 (https://github.com/Codeception/Codeception/tree/5.0/src/Codeception/Lib/Interfaces).

Also any other InnerBrowser interface are missing too. Trying to find information about some kind of migrations into separate module, but found nothing.

BTW: Thanks for you work!

Created at 1 month ago

Update symfony support ^6

Created at 1 month ago
pull request opened
Fix deprecation error on php 8.1

Use 0.17.5 version with php 8.1 and get such error:

Deprecated: Memcached::get(): Passing null to parameter #3 ($get_flags) of type int is deprecated in /app/www/vendor/tedivm/stash/src/Stash/Driver/Sub/Memcached.php on line 190
Created at 2 months ago

Update Memcached.php

Created at 2 months ago
Created at 2 months ago

Fix deprecation error for 8.1

See this error E_DEPRECATED: Memcached::get(): Passing null to parameter #3 ($get_flags) of type int is deprecated on 0.17.5. version with php 8.1.

Created at 2 months ago
Created at 2 months ago

getExpiration returns CurrentTime for empty record

Created stand alone "save" function that uses the data and ttl properties

This is because in PSR6 the “set” and new expiration functions are no longer persistent to the driver but instead save data in the object until it is saved.

This change provides backwards compatibility (for now) to make testing easier, while providing the foundation of the future changes to this class.

Formatting

Decoupled "set" function from persisting values

Removed expiration time for set function

Split invalidation method from get function.

Fixed formatting

Fixed more "save" related changes

Typo/syntax error

Added save function to ItemInterface

Changed getItemIterator to getItems

Added commit, saveDeferred, save, and deleteItems to the Pool Interface

Fixed formatting

Merge branch 'master' into psr6

Conflicts: tests/Stash/Test/AbstractPoolTest.php

Extend from RuntimeException

Stopped "collecting" deleted items

Added isHit function

Added "exists" function

Made expiresAt throw InvalidArgumentException on non-datetime arguments

Formatting

Created at 2 months ago
issue comment
Update Arrayable to be compatible with php 8.1

@PHLAK can u review and build next minor version?

Created at 2 months ago
pull request opened
Update Arrayable to be compatible with php 8.1

With php 8.1 this lib output deprecated warnings

Created at 2 months ago

Update Arrayable

compatible with php 8.1

Created at 2 months ago