brianloveswords
Repos
247
Followers
404
Following
41

Events

add a description

Created at 4 days ago

add fp in scala post

Created at 4 days ago
issue comment
Folder and its contents disappear when using `mv <source> ..` while in a folder with same name as source

I updated the description to hopefully be a bit more clear: in my repro, the problem is not that testdir/testdir goes missing, that's expected. The problem is that testdir/testdir/testfile goes missing. I'm not sure where it ends up! Does it get deleted?

Created at 4 days ago
issue comment
Folder and its contents disappear when using `mv <source> ..` while in a folder with same name as source

@fdncred I would expect either an error, or for testfile to not disappear.

Created at 4 days ago
opened issue
Folder and its contents disappear when using `mv <source> ..` if in the same folder name as source

Describe the bug

Hello! I can make a folder disappear and its contents disappear entirely if I try to move it in such a way that it would overwrite the current directory.

How to reproduce

  1. mkdir testdir
  2. cd testdir
  3. mkdir testdir
  4. touch testdir/testfile
  5. mv testdir ..

Expected behavior

Using /bin/mv, this would result in mv: rename testdir/ to ../testdir/: Directory not empty.

In nushell, the command completes successfully, but the source goes missing.

Screenshots

Configuration

| key | value | | ------------------ | ----------------------------------------------- | | version | 0.66.3 | | branch | | | commit_hash | | | build_os | macos-aarch64 | | build_target | aarch64-apple-darwin | | rust_version | rustc 1.62.1 | | cargo_version | cargo 1.62.0 (a748cf5a3 2022-06-08) | | pkg_version | 0.66.3 | | build_time | 2022-07-28 23:07:51 +00:00 | | build_rust_channel | release | | features | database, dataframe, default, trash, which, zip | | installed_plugins | |

Additional context

No response

Created at 4 days ago
issue comment
Add CSS and JS enabling click-to-toggle on heading

@hojberg alright I updated this to use closest and I checked the case where a term is embedded in the fold summary and it seems to work fine—the selector doesn't capture the anchor, and clicking on it works just fine.

Created at 2 weeks ago
issue comment
Add CSS and JS enabling click-to-toggle on heading

Thanks for the comments @hojberg, I'll look into making updates this weekend and @ you when it's ready for re-review!

Created at 3 weeks ago
issue comment
Panic when using the `%` character

Something with the history was a good lead, I ended up resetting everything back to scratch and couldn't reproduce it, so I diffed my config with the default and remembered I have history_file_format: "sqlite" set. That seems to be required for reproduction, and I can reproduce it with an empty history using the steps at the top of this issue.

Created at 1 month ago
issue comment
Panic when using the `%` character

I just tried on 0.65.0 and it panic'd, so I tried again on main and I still get it:

   0:        0x105e757f4 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h1fcf5822ec0595d6
   1:        0x105e8eac0 - core::fmt::write::hd4312e875444daaf
   2:        0x105e5f748 - std::io::Write::write_fmt::h6fe61d5a2c45611b
   3:        0x105e65110 - std::panicking::default_hook::{{closure}}::h33762d2c242ef766
   4:        0x105e64dd4 - std::panicking::default_hook::h6d8535317e31e739
   5:        0x1045c4b58 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h175bef0f9c41933f
                               at /private/tmp/rust-20220617-27679-di3d4y/rustc-1.61.0-src/library/alloc/src/boxed.rs:1875:9
   6:        0x1045e3f18 - nu::main::{{closure}}::haaaabbf39ec6ef65
                               at /Users/brian/src/nushell/src/main.rs:45:9
   7:        0x105e656d8 - std::panicking::rust_panic_with_hook::hbed5b5f05ae7b6c2
   8:        0x105e75afc - std::panicking::begin_panic_handler::{{closure}}::he6e992d2f2d44613
   9:        0x105e75908 - std::sys_common::backtrace::__rust_end_short_backtrace::h163559e3b58ec18c
  10:        0x105e65224 - _rust_begin_unwind
  11:        0x105ebf89c - core::panicking::panic_fmt::h20603f0cb36d804e
  12:        0x105e9b3f0 - core::str::slice_error_fail_rt::ha37c525d5097fa9e
  13:        0x105e98278 - core::ops::function::FnOnce::call_once::h9514d32793d8597d
  14:        0x105e98318 - core::intrinsics::const_eval_select::h2b329c4f8ee7b37a
  15:        0x105ebfa48 - core::str::slice_error_fail::h425786704163e588
  16:        0x10570b000 - core::str::traits::<impl core::slice::index::SliceIndex<str> for core::ops::range::RangeFrom<usize>>::index::h0e8dd320b77e65a6
                               at /private/tmp/rust-20220617-27679-di3d4y/rustc-1.61.0-src/library/core/src/str/traits.rs:370:21
  17:        0x105709fb4 - core::str::traits::<impl core::ops::index::Index<I> for str>::index::h70f6a96c9e0316b8
                               at /private/tmp/rust-20220617-27679-di3d4y/rustc-1.61.0-src/library/core/src/str/traits.rs:65:9
  18:        0x1054f5c28 - <alloc::string::String as core::ops::index::Index<core::ops::range::RangeFrom<usize>>>::index::hfb713cfa8be6752ae07d5
                               at /Users/brian/.cargo/registry/src/github.com-1ecc6299db9ec823/reedline-0.8.0/src/hinter/default.rs:27:21
  20:        0x1054a2b40 - core::option::Option<T>::map_or_else::h569fd9d99d3ea505
                               at /private/tmp/rust-20220617-27679-di3d4y/rustc-1.61.0-src/library/core/src/option.rs:1008:24
  21:        0x10549a640 - <reedline::hinter::default::DefaultHinter as reedline::hinter::Hinter>::handle::h833232f21d447f6b
                               at /Users/brian/.cargo/registry/src/github.com-1ecc6299db9ec823/reedline-0.8.0/src/hinter/default.rs:22:13
  22:        0x1054bf2e4 - reedline::engine::Reedline::buffer_paint::{{closure}}::hb7a428125aecf3de
                               at /Users/brian/.cargo/registry/src/github.com-1ecc6299db9ec823/reedline-0.8.0/src/engine.rs:1356:17
  23:        0x1054a2c44 - core::option::Option<T>::map_or_else::h681d061d7a91e14b
                               at /private/tmp/rust-20220617-27679-di3d4y/rustc-1.61.0-src/library/core/src/option.rs:1008:24
  24:        0x1054bef0c - reedline::engine::Reedline::buffer_paint::h1edf180579affe9b
                               at /Users/brian/.cargo/registry/src/github.com-1ecc6299db9ec823/reedline-0.8.0/src/engine.rs:1355:13
  25:        0x1054bd2d8 - reedline::engine::Reedline::repaint::hf6dd7131f0a12dba
                               at /Users/brian/.cargo/registry/src/github.com-1ecc6299db9ec823/reedline-0.8.0/src/engine.rs:1163:13
  26:        0x1054b8fdc - reedline::engine::Reedline::read_line_helper::hbd8413d216f99849
                               at /Users/brian/.cargo/registry/src/github.com-1ecc6299db9ec823/reedline-0.8.0/src/engine.rs:532:29
  27:        0x1054b8310 - reedline::engine::Reedline::read_line::h42ec59886ff179aa
                               at /Users/brian/.cargo/registry/src/github.com-1ecc6299db9ec823/reedline-0.8.0/src/engine.rs:419:22
  28:        0x10533efec - nu_cli::repl::evaluate_repl::h360af58f6337364a
                               at /Users/brian/src/nushell/crates/nu-cli/src/repl.rs:311:21
  29:        0x1045bef08 - nu::main::he0308937fe186cda
                               at /Users/brian/src/nushell/src/main.rs:295:31
  30:        0x1045d171c - core::ops::function::FnOnce::call_once::he4ceec195679f0d9
                               at /private/tmp/rust-20220617-27679-di3d4y/rustc-1.61.0-src/library/core/src/ops/function.rs:227:5
  31:        0x1045d4bcc - std::sys_common::backtrace::__rust_begin_short_backtrace::ha17ff4874ba1b584
                               at /private/tmp/rust-20220617-27679-di3d4y/rustc-1.61.0-src/library/std/src/sys_common/backtrace.rs:122:18
  32:        0x1045ec3a8 - std::rt::lang_start::{{closure}}::hb75019315c8b9f1b
                               at /private/tmp/rust-20220617-27679-di3d4y/rustc-1.61.0-src/library/std/src/rt.rs:145:18
  33:        0x105e5a840 - std::rt::lang_start_internal::h933a358395d5a923
  34:        0x1045ec370 - std::rt::lang_start::hd9118bb89348dfed
                               at /private/tmp/rust-20220617-27679-di3d4y/rustc-1.61.0-src/library/std/src/rt.rs:144:17
  35:        0x1045c2c3c - _main

Let me know what other information might be helpful!

Created at 1 month ago
issue comment
Panic when using the `%` character

Thanks for looking into this so quickly @jntrnr! I'll try again later today on either main or 0.65.0 if it's out by the time I have a chance to look more into this.

Created at 1 month ago
opened issue
Panic when using the `%` character

Describe the bug

I'm getting panics when using shell commands that include % symbol. I've included minimal repro steps before.

How to reproduce

  1. type ls a and hit enter. (note: does not matter if a exists or not)
  2. type ls a%

Expected behavior

Not panic

Screenshots

Configuration

| key | value | | ------------------ | ----------------------------------------------- | | version | 0.64.0 | | branch | | | commit_hash | | | build_os | macos-aarch64 | | build_target | aarch64-apple-darwin | | rust_version | rustc 1.61.0 | | cargo_version | cargo 1.61.0 (a028ae42f 2022-04-29) | | pkg_version | 0.64.0 | | build_time | 2022-06-15 02:39:17 +00:00 | | build_rust_channel | release | | features | database, dataframe, default, trash, which, zip | | installed_plugins | |

Additional context

No response

Created at 1 month ago

Support more browsers I guess

Created at 1 month ago

Make toggle a little safer

Created at 1 month ago
pull request opened
Add CSS and JS enabling click-to-toggle on heading

I was setting up a new computer and noticed this minor papercut on the Quickstart page: the heading on the toggle lists are not clickable. I saw in #troubleshooting that other people ran into this as well.

This was the most straightforward way I could find to fix it without having to change how unison generates the HTML. I don't love the .folded-details > div .word selector, but it does seem to work and not over-select in the light testing I did.

quickstart-toggle

If this is not the way you'd prefer for this to be fixed, and you'd prefer the HTML generator to change instead, feel free to reject this PR, I will not be offended!

Created at 1 month ago

Add CSS and JS enabling click-to-toggle on heading

Created at 1 month ago
brianloveswords create branch bjb/try-to-fix-toggle
Created at 1 month ago

Reset sqlite to upstream main

Created at 1 month ago
brianloveswords create branch bjb/fix-toggle
Created at 1 month ago
brianloveswords create branch master
Created at 1 month ago
create repository
brianloveswords create repository
Created at 1 month ago
opened issue
Changes to "Documenting Unison Code"

Hello! Chatted about this in Slack with @rlmark:

  • added note about including a blank line before code blocks image

  • added heading to list of supported syntax image

  • fixed the formatting on {Some} in the Link syntax cheat sheet. image

Here's the gist:

.learn.usageTopics> gist git@github.com:brianloveswords/unison-website:.gists
  Checking out main ...
  Synced 3 entities.                       
  Gist created. Pull via:
  
    pull git@github.com:brianloveswords/unison-website:#uu64bhtcd6
Created at 1 month ago

Sync branch "uu64bhtcd640uv2urfivj7ieafhcigc93op8t2bk4c4uak0r55odo5dgujnjmieetp1spjmeknv3hqe31jq94bt3gd0a2q00p97gck8"

Created at 1 month ago
opened issue
Heading in `Doc` will eat a code fence unless there's a separating blank line

I noticed this behavior when writing Docs that if I do not include a blank newline between a heading and a code block, the code block gets sorta "eaten" by the header and not evaluated.

Some screenshots to show what I'm talking about:

image

image

image

Created at 1 month ago