Generally looks good, one comment.
You should be able to get the api exception with KubectlException.getCause()
/lgtm /approve
Similarly, if you'd prefer I simultaneously sent some PRs to the wasi-http
repo, I can do that, it looked abandoned so I wasn't sure what the state was.
@pchickey thanks for the response, I'm happy to commit to making the necessary changes (and even iterating along side)
I looked at WIT and the component model, but there doesn't seem to be a good example of it being actually used in wasmtime right now (wasi-nn and wasi-crypto use WITX) so whenever there is a pointer to where you want this to go please let me know.
It definitely doesn't need to be perfect, I don't mind dealing with some churn, and currently I'm having to deal with maintaining this as a patch-set, which has it's own costs :)
Update code for base64 0.21.0
You can see examples of this in operation here:
This adds basic HTTP client support as an optional module. This is intended as a draft and conversation starter. If there are structural changes (eg. write a different proposal, a different PR, etc) please let me know, this is my first contribution.
Happy to close this and do this in a different way. Please advise.
Thanks!
Add source for for wasi-experimental-http-wasmtime.
Integrate experimental HTTP into wasmtime.
Cranelift: Fix select
condition harvesting (#5662)
Souper requires an i1
condition value, we don't and will implicitly check
against 0. We were truncating conditions but should actually be doing the
comparison against 0
.
Pin release artifacts Rust toolchain (#5669)
This fixes the build issue identified in #5664 at the toolchain level rather than working around it in our own build. The next step in fixing this will be to remove the nightly override in the future when the toolchain becomes stable.
ISLE: reject multi-term rules with explicit priorities (#5663)
In multi-terms, all matching rules fire. We treat the result as an unordered set of values, so setting rule priorities is meaningless. We want to prohibit relying on the rule match order in this case.
Also, codegen can produce invalid Rust if rules with different priorities both match against a multi-term. We first documented this symptom in #5647. As far as I can figure, prohibiting rule priorities prevents all possible instances of that bug.
At some point in the future we might decide we want to carefully define semantics for multi-term result ordering, at which point we can revisit this.
Cranelift: Add egraph rule to rewrite x * C ==> x << log2(C)
when C
is a power of two (#5647)
Making sure that new files in the winch filetests directory will cause a rebuild (#5672)
Remove unused code from the write module (#5674)
The DisplayValuesWithDelimiter struct is no longer used.
Cranelift: constant propagate shifts (#5671)
Thanks to Souper for pointing out we weren't doing this!
Fix some warnings on nightly Rust (#5668)
Cargo is warning about the usage of workspace dependencies where the
workspace declaration does not mention default-features
but the
dependency mentions default-features
, so this explicitly turns off
default features for cranelift-codegen
at the workspace level and
removes the explicit default-features = false
at the manifest levels.
Explicitly enable default feature in wasmtime
Enable another feature
Cranelift: Rewrite (x>>k)<<k
into masking off the bottom k
bits (#5673)
Cranelift: Rewrite (x>>k)<<k
into masking off the bottom k
bits
Add a runtest for exercising our rewrite of (x >> k) << k
into masking
Add a convenience function for displaying a BlockCall (#5677)
Add a display method to BlockCall that returns a std::fmt::Displayable result. Rework the display code in the write module of cranelift-codegen to use this method instead.
Cranelift: Rewrite or(and(x, y), not(y)) => or(x, not(y))
(#5676)
Co-authored-by: Rainy Sinclair 844493+itsrainy@users.noreply.github.com
Fix issue 5528 (#5605)
fix parameter error.
fix float convert to i8 and i16 should extract sign bit.
add missing regression test file.
using tmp register.
float convert i8 will consume more instructions.
fix worse inst emit size.
fix worst_case_size.
Merge branch 'bytecodealliance:main' into main
Ok, I will send a PR to remove this code from the client.
/lgtm /approve
I have added console.log function to check the function is working .
@Himanshu-holmes thanks for the interest in the project. If you are interested in contributing further, there is a list of good first issues:
https://github.com/kubernetes-client/javascript/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22
Thanks!
I don't think that this is an error in the library. You can see in the code where this is set:
https://github.com/kubernetes-client/javascript/blob/481cdd246fd8b57fdb41d7b0ee7fbddab441aef4/src/gen/api/customObjectsApi.ts#L1416
And where it is turned into a URL: https://github.com/kubernetes-client/javascript/blob/481cdd246fd8b57fdb41d7b0ee7fbddab441aef4/src/gen/api/customObjectsApi.ts#L1443
It's hard for me to see where this could happen. I suspect that either your label selector isn't working the way you think it should work or there is an issue with the server.
To investigate this further, I would ask you to determine the URL that the code is generating, and then attempt to call that URL directly using a tool like curl
, and also look at what kubectl
does using the same inputs.
As it stands, there's not enough information in this report to determine where (or indeed if) a problem exists.
This requires Java 11, we need to figure out what we're doing about this.
Update devcontainer.json
Add lighttpd for web serving.
Add a dotnet wasi feature.