boenrobot
Repos
49
Followers
18
Following
1

This package allows you to read and write information from a RouterOS host using the MikroTik RouterOS API protocol.

223
113

A stream wrapper that ensures data integrity. Particularly useful for sockets.

8
3

Wrapper for shared memory and locking functionality across different PHP extensions.

6
5

Genetaror for ANSI color escape sequences.

5
0

Analyzes available menus/commands/arguments on a MikroTik RouterOS installation using SSH, outputted in JSON

9
3

Events

opened issue
Unit tests in PHP 7

With https://github.com/Shardj/zf1-future/commit/93adc40bfb772c0a4ce7cacbb5729013b0e7eaf2

There is now no testing of any sort of compatibility with PHP 7, which is a bit unfortunate.

In the project I work on, we're currently using PHP 7.4, but we came to this project after migrating from PHP 7.1 (the last version where the original ZF1 works) to PHP 7.4. The fact that this project works with PHP 7.1 was invaluable in the migration. It allowed us to switch to it before migrating the rest of the code, and having the confidence that any errors encountered in the new PHP version are not ZF1's fault.

We're currently in the process of pulling the same in a jump between PHP 7.4 and PHP 8.1 (can't wait for a tagged release with the latest changes btw...), but still. I think compatibility with PHP 7 on a CI level should be restored, or incompatibilities are sure to arise sooner or later.

Created at 1 week ago

Added support for DoctrineProvider wrapped cache adapters, and raised the acceptable doctrine ORM versions to any in the 2 family after 2.3.

Merge pull request #1 from boenrobot/doctrine-provider-support

Added support for DoctrineProvider wrapped cache adapters

Created at 1 week ago

Added the ability to set up a keep alive interval that will close the connection if it does not receive a reply in time.

Created at 1 month ago
"Unable to determine incoming webhook type" exception

Sample logs sent over email.

I think I can safely disclose that after some digging, it seems the issue affects delivery notifications that failed with err-code 11 ("Unroutable").

Created at 2 months ago
"Unable to determine incoming webhook type"

It seems SMS delivery notifications are no longer (or at least not always) featuring the "scts" field. That field was used to disambiguate SMS delivery notifications from incoming SMS messages.

Expected Behavior

Incoming message is detected as an SMS delivery notification, and transformed into the appropriate object.

Current Behavior

Delivery notifications fail with the "Unable to determine incoming webhook type" message, which is not unexpected given that the payload is an SMS delivery notification without the "scts" field.

Possible Solution

Either Vonage should start sending the "scts" field again, or this client should be modified to use something else to disambiguate delivery notifications from incoming SMS messages. Not sure which field could be used instead of "scts".

Steps to Reproduce (for bugs)

  1. Send SMS with a delivery notification URL
  2. Try to parse the SMS delivery notification using \Vonage\SMS\Webhook\Factory::createFromArray or one of the helpers that ultimately calls that same method.
  3. Observe the error.

Context

The company I work for uses this SDK to send SMS messages and process delivery receipts for statistics, and black listing phone numbers if delivery fails consistently. While we can still send SMS messages, the rest is currently broken due to this.

Your Environment

  • Version used: On production, 3.0.0, though I did check the latest version in master of this repo, and it's still affected.
  • Environment name and version (e.g. PHP 7.2 on nginx 1.19.1): PHP 7.4
  • Operating System and version: Ubuntu Server
Created at 2 months ago
delete branch
boenrobot delete branch version-test-fix
Created at 2 months ago
delete branch
boenrobot delete branch form-translate-docblocks
Created at 2 months ago

Fixed the version test since the latest release.

Future releases should update the digits in the loops to match the largest number that this part of the version vector has ever reached. For the middle part, this is now 22, but the last part is now preemptively increased to 99.

Created at 2 months ago

Fixed the version test since the latest release.

Future releases should update the digits in the loops to match the largest number that this part of the version vector has ever reached. For the middle part, this is now 22, but the middle and last parts are now preemptively increased to 99.

Created at 2 months ago

Fixed the version test since the latest release. Future releases should update the digits in the loops to match the version vector, except the last part.

Created at 2 months ago

Fixed the version test since the latest release. Future releases should update the digits in the loops to match the version vector.

Created at 2 months ago
pull request opened
Fixed the version test since the latest release.

Future releases should update the digits in the loops to match the version vector.

Created at 2 months ago
create branch
boenrobot create branch version-test-fix
Created at 2 months ago
issue comment
getTranslator() docblocks for the Zend_Form family

Fair enough. Amended.

Created at 2 months ago

Fixed doc blocks in form related classes - getTranslator()/getDefaultTranslator() returns the translate adapter, not the translate class.

Actual behavior is not modified. This is just updating the docs to match the implementation, and will potentially help uncover bugs by static analysis tools in applications that thought they're dealing with the translator instead of dealing with the adapter.

Created at 2 months ago
pull request opened
getTranslator() docblocks for the Zend_Form family

Fixed doc blocks in form related classes - getTranslator()/getDefaultTranslator() returns the translate adapter, not the translate class.

Actual behavior is not modified. This is just updating the docs to match the implementation, and will potentially help uncover bugs by static analysis tools in applications that thought they're dealing with the translator instead of dealing with the adapter.

In the actual application I work on, we have a custom translate adapter, which we sometimes need to get out of the translator due to the extra functionality, and had been bitten a few times already by the fact we don't need to call getAdapter() to get it.

Created at 2 months ago
create branch
boenrobot create branch form-translate-docblocks
Created at 2 months ago

Added return type hint void to enable forward compatibility with newer PHPUnit versions.

phpdoc update

  • add missing parameters
  • fixed missing spaces
  • fixed typo

Apply SUPEE-9652/10570

Apply Magento 1.9.0.0 change

TypeError: round(): Argument #1 ($num) must be of type int|float

Base on ENV, setup TestConfiguration to enable memcache, db test

Fixed begining typo

Correctly assetion method name

  • Issue raise here https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:285
  • Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test
  • Rollback line code to here https://github.com/hungtrinh/zf1-future/blob/5ae9f922ca97bd59a7f70e5c2efb10b360eae331/tests/Zend/Db/Statement/TestCommon.php#L825

Correctly expected message for pdo_sqlite test

Issue raise here: https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:635

Zend_Db_Statement_Pdo_SqliteTest::testStatementGetSetAttribute Failed asserting that 'SQLSTATE[IM001]: Driver does not support this function: driver doesn't support getting that attribute' contains "This driver doesn't support getting".

  • with pdo_mysql will raise this message https://github.com/php/php-src/blob/568ed4721e6dffd8085c04552a3b24d0057ed2fe/ext/pdo/pdo_stmt.c#L1626
  • with pdo_sqlite will raise this message https://github.com/php/php-src/blob/568ed4721e6dffd8085c04552a3b24d0057ed2fe/ext/pdo/pdo_stmt.c#L1642

Fix bug: 'This test did not perform any assertions'

Issue raise here:

  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:973
  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:981

Correctly assetion method name

  • Issue raise here https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:279
  • Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test
  • Rollback line code to here https://github.com/hungtrinh/zf1-future/blob/5ae9f922ca97bd59a7f70e5c2efb10b360eae331/tests/Zend/Db/Adapter/TestCommon.php#L791

PHPUnit 9, correctly expected value

PHPUnit <= 6.x: true === assertEquals('12.34','12.340000') Since PHPUnit 7.x: false === assertEquals('12.34','12.340000')

Correctly assetion method name

  • Issue raise here https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:293
  • Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test
  • Rollback line code to here https://github.com/Shardj/zf1-future/blob/5ae9f922ca97bd59a7f70e5c2efb10b360eae331/tests/Zend/Db/Select/TestCommon.php#L316-L333

Correctly assetion method name

  • Issue raise here: https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:360
  • Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test
  • Rollback line code to here https://github.com/Shardj/zf1-future/blob/31ba05039cc0485b4cf9c5dfc7284cd4d185cd5e/tests/Zend/Db/Table/TestCommon.php#L224

Correctly assetion method name

  • Issue raise here: https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:307
  • Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test
  • Rollback line code to here https://github.com/Shardj/zf1-future/blob/31ba05039cc0485b4cf9c5dfc7284cd4d185cd5e/tests/Zend/Db/Table/TestCommon.php#L235

Correctly assetion method name

  • Issue raise here: https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:314
  • Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test
  • Rollback line code to here https://github.com/Shardj/zf1-future/blob/31ba05039cc0485b4cf9c5dfc7284cd4d185cd5e/tests/Zend/Db/Table/TestCommon.php#L247

Correctly expect notice on PHPUnit 9

Issue raise here:

  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:320
  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:380
  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:440

Root Cause: PHPUnit Expected user notice changed when migrate PHPUnit 3.x => PHPUnit 9.x

Fix bug 'This test did not perform any assertions'

Issue raise here:

  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:964
  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:1004
  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:1044

PHP 8.1 compatibility changes

Correctly test code to match with this commit https://github.com/Shardj/zf1-future/commit/ad81d0c2c6b5ee9207627022197b3a952418256b

Issue raise here:

  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:4824
  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:558
  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:641

Root cause here:

  • https://github.com/Shardj/zf1-future/commit/ad81d0c2c6b5ee9207627022197b3a952418256b#r92247133
  • https://github.com/Shardj/zf1-future/commit/ad81d0c2c6b5ee9207627022197b3a952418256b#r92248282

PHPUnit 9 compatibility changes

Issue raise here:

  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:489
  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:503
  • https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:517
Created at 2 months ago