bertho-zero
Repos
114
Followers
54
Following
22

Events

issue comment
Feature request: column-count

Still no columnCount :'(

Created at 1 day ago
issue comment
TypeScript: property position does not support !important

Because next/image adds a position: absolute via Image's style prop and I need to unset it.

pos="unset!important"
Created at 1 day ago
issue comment
ModalHeader and ModalCloseButton overflow

With Chrome, Brave and Firefox on Ubuntu. I have the same result on all my browsers.

image

Created at 1 day ago
issue comment
ModalHeader and ModalCloseButton overflow

Removing the size does not resolve the issue, the problem is that a long title can go behind the close button.

The title can be translated into several languages or contain dynamic content and have an unknown length.

Same example without size: https://codesandbox.io/s/wonderful-lumiere-mlnqhs?file=/src/index.js

Created at 2 days ago
issue comment
Roadmap - v3.0 🗺

One thing I would love would be a set of stories so we can see the theme we're expanding on as a whole. Or a tool that allows you to visualize the impact of our changes on all components.

Created at 3 days ago

feat(common-labels): translate event/fields to fr

Created at 3 days ago

style(bs-templates): update modal title

chore(react-share-menus): fix babel config

style(react-share-menus): update modal title

style(react-shared): update modal title

chore: update lockfile

Created at 1 week ago

chore: update jest

Created at 1 week ago

fix(react-shared): fix jest config

Created at 1 week ago

fix(react-shared): add testURL to jest config

Created at 1 week ago

fix(react-shared): use jsdom test environment

Created at 1 week ago

fix(agenda-docx): fix tests

Created at 1 week ago

fix(react-shared): fix test

Created at 1 week ago
issue comment
Support for React 18

@cfaester/enzyme-adapter-react-18 works fine for me

Created at 1 week ago

fix(react-shared): fix sideEffects for css and scss

Created at 1 week ago
closed issue
[Bug]: v7 ignore css imports

Describe the bug

The following import is ignored:

import '@company/package/css/react-date-range.css';

The following works fine, but the variable is of no use to me:

import _css from '@company/package/css/react-date-range.css';

I don't understand the origin of this problem.

How to keep css imports without giving them unnecessary names that the linter complains about?

To Reproduce

No response

System

System:
    OS: Linux 5.17 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 3.2.4 - ~/.yarn/bin/yarn
    npm: 9.2.0 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Firefox: 109.0
  npmPackages:
    @storybook/nextjs: ^7.0.0-beta.30

Additional context

No response

Created at 1 week ago
issue comment
[Bug]: v7 ignore css imports

I had a "sideEffects": false in the package.json, which I replaced with "sideEffects": ["*.css", "*.scss"] and it works fine now.

Created at 1 week ago
opened issue
[Bug]: v7 ignore css imports

Describe the bug

The following import is ignored:

import '@company/package/css/react-date-range.css';

But the following works fine, but the variable is of no use to me:

import _css from '@company/package/css/react-date-range.css';

I don't understand the origin of this problem.

How to keep css imports without giving them unnecessary names that the linter complains about?

To Reproduce

No response

System

System:
    OS: Linux 5.17 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 3.2.4 - ~/.yarn/bin/yarn
    npm: 9.2.0 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Firefox: 109.0
  npmPackages:
    @storybook/nextjs: ^7.0.0-beta.30

Additional context

No response

Created at 1 week ago

fix(react-filters): remove react strict mode

fix(react-filters): move QueryClientProvider in FiltersManager

Created at 1 week ago

chore(react-shared): update babel config

feat(react-shared): update nl2br

chore: update lockfile

feat(uikit): refactor and add NoBreak

fix(eslint-config): fix linting with typescript

Merge branch 'main' of github.com:OpenAgenda/oa-public

Created at 1 week ago
opened issue
ModalHeader and ModalCloseButton overflow

Description

When a modal is displayed with a long title, it can go behind the close button, which is visually not pretty.

image

Link to Reproduction

https://codesandbox.io/s/sad-babycat-ijposv?file=/src/index.js

Steps to reproduce

  1. Click on 'Open Modal'

Chakra UI Version

2.4.9

Browser

Brave 1.46.144

Operating System

  • [ ] macOS
  • [ ] Windows
  • [X] Linux

Additional Information

This problem could be fixed by moving the ModalCloseButton in the ModalHeader, which changes the html structure a bit but doesn't change anything visually because the button is absolute.

And when there is a close button in the header, we can increase the right padding to avoid overlapping:

{/* Before */}
<ModalContent>
  <ModalHeader>
    ...
  </ModalHeader>
  <ModalCloseButton />
</ModalContent>

{/* After */}
<ModalContent>
  <ModalHeader>
    ...
    <ModalCloseButton />
  </ModalHeader>
</ModalContent>

The fix (example), it can be in the theme:

<ModalHeader
  sx={{
    ':has(> .chakra-modal__close-btn)': {
      pr: 12, // to not overflow with close button
    },
  }}
>
Created at 1 week ago
add missing space

It is not necessary here

Created at 1 week ago
issue comment
Shortened styled-system props are sometimes ignored with the default theme (h on Button)

I wouldn't have thought this PR would have fixed that bug too, that's great

Created at 1 week ago
issue comment
Bug: function-paren-newline error with jsx and multiple map

Thanks for your response, @mdjermanovic

Created at 1 week ago

style: double quotes

Created at 2 weeks ago
pull request opened
Update modal.ts

Fixes #7224 and #4832

More details in the issues

Created at 2 weeks ago

Update modal.ts

Fixes #7224 and #4832

Created at 2 weeks ago
issue comment
Modal dialog with `isCentered` has broken overflow

<ModalContent containerProps={{ display: "grid" }}> instead of <ModalContent> fix the issue:

https://codesandbox.io/s/vigorous-bassi-gyjgoy?file=/src/index.js

Maybe it should be in the default theme?

Created at 2 weeks ago
issue comment
Centered modal with large content

A display: grid instead of display: flex on .chakra-modal__content-container fix the problem:

Capture vidéo du 12-01-2023 15:40:33.webm

Created at 2 weeks ago
opened issue
Centered modal with large contentn

Description

When I create a modal (centered or not), I expect to be able to see all the contents of it.

As soon as my centered modal is too big, the top disappears. Everything else works normally and the bottom is displayed correctly when I scroll, just the top is cut off.

Link to Reproduction

https://codesandbox.io/s/thirsty-fermat-gy9oqs?file=/src/index.js

Steps to reproduce

  1. Click on 'Trigger modal'

Chakra UI Version

2.4.7

Browser

Brave 1.46.144

Operating System

  • [ ] macOS
  • [ ] Windows
  • [X] Linux

Additional Information

No response

Created at 2 weeks ago