bergjohan
Repos
7
Followers
17
Following
4

Events

Initial commit

Created at 1 week ago

Initial commit

Created at 1 week ago

Initial commit

Created at 3 weeks ago
issue comment
Prevent weird solutions to pass

This is an interesting case, however, I don't think it's worth spending time trying to prevent it. I'll refer to the comments in #151

Created at 4 weeks ago
issue comment
Add support for Apple ARM

Thank you! :)

Created at 1 month ago
issue comment
Add support for Apple ARM

@ErikSchierboom I haven't gotten my write permissions yet, could we get this one merged? And also close #101 as duplicate?

Created at 1 month ago
pull request opened
Add support for Apple ARM
Created at 1 month ago
bergjohan create branch apple-arm-support
Created at 1 month ago
Created at 1 month ago
issue comment
exercises: add triangle

Yes you can merge it, thank you!

Created at 1 month ago
issue comment
Add .note.GNU-stack section to every exercise

@ErikSchierboom They were removed because I wasn't active as a maintainer. We discussed it a while back in another PR, and I decided to wait. But maybe it would be better if I got permissions again, so I don't have to ping you in every PR.

Created at 1 month ago
issue comment
Add .note.GNU-stack section to every exercise

Perfect, thank you!

Created at 1 month ago
issue comment
Add .note.GNU-stack section to every exercise

Noticed in another PR that this fails for macOS. I think we need to ifidn it for elf64 only:

%ifidn __OUTPUT_FORMAT__,elf64
section .note.GNU-stack noalloc noexec nowrite progbits
%endif
Created at 1 month ago
issue comment
exercises: add triangle

Try the following instead:

%ifidn __OUTPUT_FORMAT__,elf64
section .note.GNU-stack noalloc noexec nowrite progbits
%endif
Created at 1 month ago
issue comment
exercises: add triangle

Wait, there seems to be an error on macOS:

triangle.asm:95: error: segment name `.note.GNU-stack' not recognized

Created at 1 month ago
issue comment
exercises: add triangle

Perfect, thank you!

Created at 1 month ago
issue comment
exercises: add triangle

Wait, could you update the assembly files with the changes in https://github.com/exercism/x86-64-assembly/pull/161 before merging?

Created at 1 month ago
issue comment
Add .note.GNU-stack section to every exercise

Thank you for the PR, looks good!

@ErikSchierboom Could you help with merging this?

Created at 1 month ago
issue comment
exercises: add triangle

Thanks for the PR, looks good!

@ErikSchierboom Feel free to approve and merge it!

Created at 1 month ago
issue comment
Exercises won't work without .note.GNU-stack section under linux

Cool, thanks! If you'd like to make a PR, I'd be happy to review it. Otherwise I'll try to fix this when I find some time.

Created at 1 month ago
issue comment
Exercises won't work without .note.GNU-stack section under linux

Hi, thanks for opening an issue on this, interesting..

Searching for note gnu stack, I found the following: https://wiki.gentoo.org/wiki/Hardened/GNU_stack_quickstart

The interesting part is the section "How to fix the stack (in practice)".

TL;DR we should add the following at the end of all assembly files:

section .note.GNU-stack noalloc noexec nowrite progbits

Could you verify that this solves the problem?

Created at 1 month ago