balintzs
Repos
3
Followers
4

Events

[processor/metricstransform] Add support for scaling histogram metrics

Is your feature request related to a problem? Please describe.

We would like to convert latency histogram metrics we receive in milliseconds to seconds.

Describe the solution you'd like

Add support for scaling histogram datapoint sums and explicit bounds in the metricstransform processor.

Describe alternatives you've considered

No response

Additional context

No response

Created at 4 weeks ago

Add handling for scaling min, max and exemplars of histograms

Created at 4 weeks ago
[metricstransformprocessor] Add support for scaling histograms

@bogdandrutu, @dmitryax, could either of you take a quick look at this PR?

Created at 1 month ago
[metricstransformprocessor] Add support for scaling histograms

Description: Add support for scaling histogram metrics

Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/15690

Testing: Tested locally with a pipeline looking roughly like this: zipkin receiver -> spanmetrics processor -> prometheus exporter -> prometheus receiver -> metricstransform processor -> prometheus exporter

Created at 1 month ago
balintzs create branch metricstransform-scale-histogram
Created at 1 month ago
[processor/metricstransform] Add support for scaling histogram metrics

Is your feature request related to a problem? Please describe.

We would like to convert latency histogram metrics we receive in milliseconds to seconds.

Describe the solution you'd like

Add support for scaling histogram datapoint sums and explicit bounds in the metricstransform processor.

Describe alternatives you've considered

No response

Additional context

No response

Created at 1 month ago
balintzs delete branch prometheus-fix-inf-bucket-count
Created at 1 month ago

[receiver/postgresql] Fix data type for postgresql.bgwriter.duration (#15249)

  • [receiver/postgresql] Fix data type for postgresql.bgwriter.duration

This was previously modeled as an int but should have been been a double, corresponding to pg_stat_bgwriter.checkpoint_*_time.

  • Update scraper test ot use double value

[pkg/winperfcounters] Retry collection when rolloever error is detected (#14343)

  • [pkg/winperfcounters] Retry collection when rolloever error is detected

Remove deprecated in v0.60.0 extension/headerssetter module. (#14973)

SNMP Receiver metric config now takes double as valid value instead o… (#15346)

Validate entries in ALLOWLIST are not owned (#15283)

Fix #1269

Signed-off-by: Maureen amaka013@gmail.com

Signed-off-by: Maureen amaka013@gmail.com

[receiver/snmp] SNMP Receiver client refactor (#15347)

[receiver/postgresql] Fix issue where WAL lag stats could cause conversion error (#15251)

[extension/bearertokenauth] Allow for other token auth schemes (#14772)

  • Allow for other token auth schemes apart from Bearer

  • Update Readme

  • replace scheme with bearer

[processor/servicegraph] Add to component list (#14932)

  • Add servicegraph processor to component list

  • Add changelog entry

  • Move changelog yaml to .chloggen

  • gotidy

  • Fix processors test

  • Bump servicegraph to alpha

  • Updated README

[chore] dependabot updates Thu Oct 20 05:37:30 UTC 2022 (#15348)

dependabot updates Thu Oct 20 05:37:26 UTC 2022 Bump github.com/DataDog/agent-payload/v5 from 5.0.34 to 5.0.36 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.44.118 to 1.44.119 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.44.118 to 1.44.119 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.44.118 to 1.44.119 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.44.118 to 1.44.119 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.44.118 to 1.44.119 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.44.118 to 1.44.119 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.44.118 to 1.44.119 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.44.118 to 1.44.119 in /receiver/awsxrayreceiver Bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.11.3 to 2.12.0 in /receiver/opencensusreceiver Bump github.com/prometheus/client_model from 0.2.0 to 0.3.0 in /exporter/prometheusexporter Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.516 to 1.0.517 in /exporter/tencentcloudlogserviceexporter Bump go.opentelemetry.io/otel from 1.11.0 to 1.11.1 in /examples/demo/client Bump go.opentelemetry.io/otel from 1.11.0 to 1.11.1 in /examples/demo/server Bump go.opentelemetry.io/otel from 1.11.0 to 1.11.1 in /internal/aws/metrics Bump go.opentelemetry.io/otel from 1.11.0 to 1.11.1 in /receiver/opencensusreceiver Bump go.opentelemetry.io/otel from 1.11.0 to 1.11.1 in /receiver/simpleprometheusreceiver/examples/federation/prom-counter Bump go.opentelemetry.io/otel from 1.11.0 to 1.11.1 in /receiver/statsdreceiver Bump go.opentelemetry.io/otel/exporters/otlp/otlptrace from 1.11.0 to 1.11.1 in /examples/demo/client Bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from 1.10.0 to 1.11.1 in /cmd/tracegen Bump go.opentelemetry.io/otel/metric from 0.32.3 to 0.33.0 in /examples/demo/server Bump go.opentelemetry.io/otel/metric from 0.32.3 to 0.33.0 in /receiver/simpleprometheusreceiver/examples/federation/prom-counter Bump go.opentelemetry.io/otel/sdk from 1.11.0 to 1.11.1 in /examples/demo/client Bump go.opentelemetry.io/otel/sdk from 1.11.0 to 1.11.1 in /examples/demo/server Bump go.opentelemetry.io/otel/sdk from 1.11.0 to 1.11.1 in /receiver/opencensusreceiver Bump go.opentelemetry.io/otel/trace from 1.11.0 to 1.11.1 in /examples/demo/server Bump go.opentelemetry.io/otel/trace from 1.11.0 to 1.11.1 in /processor/tailsamplingprocessor Bump go.opentelemetry.io/otel/trace from 1.11.0 to 1.11.1 in /receiver/opencensusreceiver Bump golang.org/x/text from 0.3.8 to 0.4.0 in /cmd/configschema Bump golang.org/x/text from 0.3.8 to 0.4.0 in /testbed

Co-authored-by: dmitryax dmitryax@users.noreply.github.com

[exporter/loki] Add multi-tenancy support via loki.tenant hint. (#15285)

  • [exporter/loki] Add multi-tenancy support via loki.tenant hint.

  • fixup! [exporter/loki] Add multi-tenancy support via loki.tenant hint.

Merge branch 'main' into prometheus-fix-inf-bucket-count

Created at 1 month ago
Prometheus fix inf bucket count

I just noticed a change in pkg/translator/prometheusremotewrite/helper.go, but not in the prometheus exporter. Is the dependency bump all that is required for that exporter?

Yes, as far as I can tell, that is all that is required.

Created at 1 month ago
Prometheus fix inf bucket count

Are you planning to fix the prometheus exporter separately?

This change fixed it: https://github.com/prometheus/client_golang/pull/1148

Or is there something I missed?

Created at 1 month ago

Update prometheus/client_golang version for prometheusexporter directly

Created at 1 month ago
Prometheus fix inf bucket count

Description: +Inf bucket counts are handled incorrectly in both prometheusexporter and prometheusremotewriteexporter.

In prometheus this bug was taken care of by the following PR: https://github.com/prometheus/client_golang/pull/1148 For prometheusremotewriteexporter we need to make the same fix and assign value of the total count to the +Inf bucket as well.

This issue caused New Relic to drop our histogram datapoints that had invalid values. It was a problem with 0.61.0 as well, but became much worse with 0.62.0. We built a custom image updating github.com/prometheus/client_golang to the SHA version (dcea97eee2b3257f34fd3203cb922eedeabb42a6) that contained our fix and the issue disappeared: Screenshot 2022-10-19 at 12 48 49

Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/4975

Created at 1 month ago
balintzs create branch prometheus-fix-inf-bucket-count
Created at 1 month ago
Inconsistent results between prometheusexporter and prometheusremotewrite

Actually, looking at it, it is not the same bug, but the same issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheusremotewrite/helper.go#L350

The +Inf bucket should have the same value as the total count: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheusremotewrite/helper.go#L306

Created at 1 month ago
Inconsistent results between prometheusexporter and prometheusremotewrite

Sorry, I should have posted this here: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/2838#issuecomment-1283888158

Created at 1 month ago
[spanmetricsprocessor] lacenty_bucket histogram +Inf label inconsistency

cc @TylerHelmuth

Created at 1 month ago
[spanmetricsprocessor] lacenty_bucket histogram +Inf label inconsistency

Hello all, I believe this is caused by a bug we found in prometheus that causes the +Inf bucket to be added incorrectly, which in turn results in a negative number when converting cumulative datapoints to delta: https://github.com/prometheus/client_golang/issues/1147

We faced an issue whereby New Relic dropped our datapoints because of this. The issue existed with 0.61.0 but became much worse with 0.62.0. We built a custom image updating github.com/prometheus/client_golang to the SHA version (dcea97eee2b3257f34fd3203cb922eedeabb42a6) that contained our fix and the issue disappeared: Screenshot 2022-10-19 at 12 48 49

Created at 1 month ago
delete branch
balintzs delete branch bugfix-inf-bucket-from-exemplar
Created at 1 month ago
issue comment
Exemplar for `+Inf` bucket adds bucket with wrong value

Thanks for merging it, @bwplotka. When can we expect it to get released?

Created at 1 month ago

Fix test variables

Signed-off-by: Balint Zsilavecz balint.zsilavecz@skyscanner.net

Created at 1 month ago