andrewnicols
Repos
204
Followers
51
Following
5

Source of the Moodle Developer Resources and Documentation

15
55

Events

MDL-75887 behat: Add ability to set value regardless of the editor

Prior to this commit, the behat_form_editor integration was hard-coded to use Atto.

This change allows other editors to be used to set editor values, and breaks that hard bond. Following this change, any editor is able to define a behat_editor_[name].php file defining a function which meets the following signature:

set_editor_value(string $editorid, string $value): void

Each editor is responsible for checking whether its own API is available and calling any relevant functions to force the editor to set the content.

Please note: Behat is unable to determine the current editor in use on the page automatically.

Created at 6 hours ago
andrewnicols create branch lambdaUpgrade420
Created at 8 hours ago
create branch
andrewnicols create branch MDL-75887-39
Created at 9 hours ago
create branch
andrewnicols create branch MDL-75887-311
Created at 9 hours ago
create branch
andrewnicols create branch MDL-75887-400
Created at 9 hours ago

MDL-75887 behat: Add ability to set value regardless of the editor

Prior to this commit, the behat_form_editor integration was hard-coded to use Atto.

This change allows other editors to be used to set editor values, and breaks that hard bond. Following this change, any editor is able to define a behat_editor_[name].php file defining a function which meets the following signature:

set_editor_value(string $editorid, string $value): void

Each editor is responsible for checking whether its own API is available and calling any relevant functions to force the editor to set the content.

Please note: Behat is unable to determine the current editor in use on the page automatically.

Created at 9 hours ago

MDL-75886 atto: Always use Atto for @atto tests

This change, which should be easy to mimic for other editors.

This will ensure that the correct editor is used for tests relating to that editor, or its subplugins.

Created at 10 hours ago

MDL-75886 atto: Always use Atto for @atto tests

This change, which should be easy to mimic for other editors.

This will ensure that the correct editor is used for tests relating to that editor, or its subplugins.

Created at 10 hours ago

MDL-75886 atto: Always use Atto for @atto tests

This change, which should be easy to mimic for other editors.

This will ensure that the correct editor is used for tests relating to that editor, or its subplugins.

Created at 10 hours ago

MDL-75886 atto: Always use Atto for @atto tests

This change, which should be easy to mimic for other editors.

This will ensure that the correct editor is used for tests relating to that editor, or its subplugins.

Created at 10 hours ago

MDL-75886 atto: Always use Atto for @atto tests

This change, which should be easy to mimic for other editors.

This will ensure that the correct editor is used for tests relating to that editor, or its subplugins.

Created at 10 hours ago

MDL-75886 atto: Always use Atto for @atto tests

This change, which should be easy to mimic for other editors.

This will ensure that the correct editor is used for tests relating to that editor, or its subplugins.

Created at 10 hours ago

MDL-75886 atto: Always use Atto for @atto tests

This change, which should be easy to mimic for other editors.

This will ensure that the correct editor is used for tests relating to that editor, or its subplugins.

Created at 10 hours ago

MDL-75886 atto: Always use Atto for @atto tests

This change, which should be easy to mimic for other editors.

This will ensure that the correct editor is used for tests relating to that editor, or its subplugins.

Created at 10 hours ago
create branch
andrewnicols create branch MDL-75887-master
Created at 20 hours ago
create branch
andrewnicols create branch MDL-75886-39
Created at 20 hours ago
create branch
andrewnicols create branch MDL-75886-311
Created at 20 hours ago
create branch
andrewnicols create branch MDL-75886-400
Created at 20 hours ago
create branch
andrewnicols create branch MDL-75886-master
Created at 20 hours ago

[repo] Update Moodle Component metadata

Merge pull request #379 from moodle/create-pull-request/patch

[repo] Update Moodle Component metadata

Created at 21 hours ago
delete branch
andrewnicols delete branch create-pull-request/patch
Created at 21 hours ago
pull request closed
[repo] Update Moodle Component metadata

Automated changes by create-pull-request GitHub action

Created at 21 hours ago
closed issue
[docs] Migrate Git for developers

The URL of the page on https://docs.moodle.org/dev/

https://docs.moodle.org/dev/Git_for_developers

Is this documentation specific to a Moodle version?

No response

What location would you suggest in the new docs?

I'm thinking about /docs/guides/git

Created at 21 hours ago
issue comment
[docs] Migrate Git for developers

Thanks @bozicm ,

Closing as duplicate.

Created at 21 hours ago
issue comment
[docs] Migrate Git_for_developers

In #372 @HuongNV13 suggests a target of /docs/guides/git, which I think is possibly more appropriate.

Created at 21 hours ago

MDL-75262 tiny_accessibility: Implement Accessibility Checker

Co-authored by Andrew Lyons andrew@nicols.co.uk

Part of MDL-75071

Created at 1 day ago

MDL-74883 question: fix question_attempt_step_subquestion_adapter typos

During the late stages of developing MDL-20636, some key concepts in the code got renamed. However, at the time, this class was not updated properly so updating it now.

MDL-74922 javascript: storragewrapper validateCache fix

MDL-75456 behat: final deprecation of get_node_type() and get_field()

MDL-75460 mod_bigbluebuttonbn: Fix lock on start

MDL-75447 reportbuilder: return only valid audience instances.

MDL-75668 backup: Save context mapping of duplicate blocks.

MDL-75559 behat: Sort behat_hooks to top of context list

MDL-71531 cachestore_file: Stop locking cache files to read

The cache file is only ever written to in the write_file function, where it does so by writing to a temp file and performing an atomic rename of that file. When writing, the target file is never locked.

The cache file is only ever read in the get function, and there is no need for an exclusive lock in that situation.

There is therefore no need to obtain any lock, shared or exclusive, to read the cache file. Doing so only affects performance of the file sytem as file locks must be needlessly obtained and written to disk for a read operation which does not benefit from them.

MDL-75744 gapselect: remove empty choices option.

MDL-75721 reportbuilder: select from main table in absence of columns.

Ensure any joins added to the report itself are also present.

MDL-75200 core: function clean_param should work with null - php 8.1

MDL-73421 core: Calling static method on trait deprecated in PHP8.1

MDL-75782 mod_quiz: Make TinyMCE autosave less fragile

This commit amends the quiz autosave feature to not assume the components of the Tiny API as much, and add support for newer versions of TinyMCE.

MDL-75790 reportbuilder: Fix random error with user name

MDL-75459 Collapsable Form Sections: Default state bug fix

In circumstances where all collapsible form sections were expanded on page load, a check is now made to ensure the expand all/collapse all button behaves as intended.

MDL-74284 cohort: set page title on upload tab.

Override active URL when viewing system/all cohorts for consistent breadcrumb navigation.

MDL-75800 enrol: correct instance deleted event name.

MDL-27570 quiz: check if time is really up

MDL-27570 quiz timing: add unit test and simplify top of process_attempt

MDL-75776 composer: Move to upstream mink-extension and updates

We were using our fork of the mink extension:

https://github.com/moodlehq/MinkExtension.git

Because they bumped requirements to PHP 7.4 too early for us. Now, with Moodle 4.1, finally our requirements are also PHP 7.4, so we can stop using the fork and switch to the upstream one:

https://github.com/FriendsOfBehat/MinkExtension

Note this only can be done in 4.1dev, because this is the first version using PHP >= 7.4. Older branches will need to continue using the fork. Also, note that we may need to go back to the fork if there is any future trouble with the upstream library not matching our supported PHP versions.

Apart from that, it's a good moment to bump other components to current ones.

Of course, this has been generated following the instructions:

https://docs.moodle.org/dev/Composer

And using PHP 7.4 (always the min version supported) to generate the lock file.

Created at 1 day ago

MDL-75328 tiny_media: Add cancel button to image modal

Part of MDL-75071

Created at 1 day ago