andrewnester
Repos
37
Followers
54
Following
22

Ace (Ajax.org Cloud9 Editor)

24894
5011

jsonm implementation port for Rust.

3
1

Events

build: harden publish.yml permissions

Signed-off-by: Alex aleksandrosansan@gmail.com

build: harden nodejs.yml permissions

Signed-off-by: Alex aleksandrosansan@gmail.com

Merge pull request #4935 from sashashura/patch-1

GitHub Workflows security hardening

Created at 2 hours ago
pull request closed
GitHub Workflows security hardening

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

Created at 2 hours ago
delete branch
andrewnester delete branch vim-emoji
Created at 2 days ago
pull request opened
fix: Fixed handling surrogare characters in insert, replace, delete mode in Vim

Issue #, if available: https://github.com/ajaxorg/ace/issues/4108

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 2 days ago

fix: Fixed handling surrogate characters in insert-after mode in Vim

Created at 2 days ago
create branch
andrewnester create branch vim-emoji
Created at 2 days ago
closed issue
Discrepancy between keywords used by mode-aql.js in the current version and the version used by arangodb.

Arango : keywords List of keywords used by arango

...
 var keywords = (
    "for|return|filter|search|sort|limit|let|collect|asc|desc|in|into|insert|update|remove|replace|upsert|options|with|and|or|not|distinct|graph|shortest_path|outbound|inbound|any|all|none|aggregate|like|k_shortest_paths|prune"
    );
...

Ace : mode-aql.js List of keywords listed in ace-builds

...

var keywords = (         
"for|search|outbound|inbound|any|graph|prune|options|shortest_path|to|in|return|filter|sort|limit|let|collect|remove|update|replace|insers|upsert|with"
);

...

@nightwing @jywarren @fjakobs @zefhemel

Created at 3 days ago
issue comment
Discrepancy between keywords used by mode-aql.js in the current version and the version used by arangodb.

Fixed and released in version 1.11.1

Created at 3 days ago
closed issue
The editor can be crashed by passing in `undefined` into the setValue method

Passing in an undefined value into the setValue method breaks the editor and everything else.

stack trace from Firefox

  • this.$detectNewLine file:///c:/users/austincheney/prettydiff3/node_modules/ace-builds/src-min-noconflict/ace.js:1:143354
  • this.insert file:///c:/users/austincheney/prettydiff3/node_modules/ace-builds/src-min-noconflict/ace.js:1:145099
  • this.setValue file:///c:/users/austincheney/prettydiff3/node_modules/ace-builds/src-min-noconflict/ace.js:1:142991
  • this.setValue file:///c:/users/austincheney/prettydiff3/node_modules/ace-builds/src-min-noconflict/ace.js:1:232577
  • my personal code that produced the error

This problem is encountered in the scenario: myEditor.setValue(undefined). A safe mitigation is that if the argument is undefined simply process an empty string.

Convert this.$detectNewLine=function(e){var t=e.match(

To: this.$detectNewLine=function(e){var t=(typeof e!=="string")?null:e.match(

Created at 3 days ago
issue comment
The editor can be crashed by passing in `undefined` into the setValue method

Fixed and released in version 1.11.1

Created at 3 days ago
issue comment
vim: entering insert mode with 'a' can place cursor in middle of emojis

Fixed by this PR https://github.com/ajaxorg/ace/pull/4933 and released in version 1.11.1

Created at 3 days ago

fix: Discrepancy between keywords used by mode-aql.js in the current version and the version used by arangodb

fix: The editor can be crashed by passing in undefined into the setValue method

Merge pull request #4929 from andrewnester/update-aql-keywords

fix: Discrepancy between keywords used by mode-aql.js in the current version and the version used by arangodb

Merge pull request #4930 from andrewnester/fix-4784

fix: The editor can be crashed by passing in undefined into the setValue method

fix: Update vim mode (#4933)

release v1.11.1

build api reference v1.11.1

Created at 3 days ago

build api reference v1.11.1

Created at 3 days ago
create tag
andrewnester create tag v1.11.1
Created at 3 days ago
create tag
andrewnester create tag v1.11.1
Created at 3 days ago

release v1.11.1

Created at 3 days ago

package 23.09.22

Created at 3 days ago

package 23.09.22

Created at 3 days ago

fix: Update vim mode (#4933)

Created at 3 days ago
delete branch
andrewnester delete branch vim-update
Created at 3 days ago
closed issue
vim: entering insert mode with 'a' can place cursor in middle of emojis

To reproduce, in kitchen sink:

https://ace.c9.io/build/kitchen-sink.html

  1. Turn on Vim keybindings,
  2. Copy and paste the emoji 😇into the editor,
  3. Press a to enter insert mode "after" the character under the carat,
  4. Notice that the carat is placed "in the middle" of the emoji.

At this point, pressing Backspace also removes the first element of the surrogate pair making up the emoji, leaving behind the other (now invalid) piece.

Created at 3 days ago
pull request closed
update vim mode

Issue #, if available: fixes #4108

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 3 days ago
closed issue
Gutter indicators for annotations

Describe the issue

I am trying to use new feature indicators for annotations but am getting error. In settings i added => customScrollbar: "renderer"

But i get following error => Cannot read properties of undefined (reading '$updateDecorators')

error

Links

no link

Created at 3 days ago
issue comment
Gutter indicators for annotations

You need to set customScrollbar: true instead

Created at 3 days ago
delete branch
andrewnester delete branch update-aql-keywords
Created at 3 days ago
delete branch
andrewnester delete branch fix-4784
Created at 3 days ago
pull request opened
fix: The editor can be crashed by passing in undefined into the setValue method

Issue #, if available: #4784

Description of changes:

Process undefined as empty string

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 5 days ago
create branch
andrewnester create branch fix-4784
Created at 5 days ago