andrewnester
Repos
40
Followers
60
Following
24

Ace (Ajax.org Cloud9 Editor)

25490
5052

jsonm implementation port for Rust.

4
1

Events

Created at 1 day ago
issue comment
ES2022 Repository create method include undefined field that breaks DB update

I've published a PR to address this issue, can someone take a look? Thank you!

Created at 1 day ago
pull request opened
fix: Resolve undefined fields created when in ES2022 mode

Closes: #9118

Description of change

When compiling in ES2022 mode, Typescript option useDefineForClassFields is set to true. It leads to fields with undefined values being generated in entity metadata.

This changes fixes it by cleaning up any undefined fields in metadata so undefined fields are not generated and behaviour is the same when useDefineForClassFields is set to either true or false

Pull-Request Checklist

  • [x] Code is up-to-date with the master branch
  • [x] npm run format to apply prettier formatting
  • [x] npm run test passes with this change
  • [x] This pull request links relevant issues as Fixes #0000
  • [x] There are new or updated unit tests validating the change
  • [x] Documentation has been updated to reflect this change
  • [x] The new commits follow conventions explained in CONTRIBUTING.md
Created at 1 day ago
create branch
andrewnester create branch issue-9118
Created at 1 day ago
Created at 1 day ago
Created at 4 days ago
closed issue
Error in mode-latex getType

When using mode-latex, a console error appears saying Cannot read properties of null (reading 'type'), coming from https://github.com/ajaxorg/ace-builds/blob/master/src-noconflict/mode-latex.js#L142

It seems like whenever there isn't any content after the cursor, typing \begin or \end to begin or end a new environment causes a console error to show up.

It's simple to reproduce in the kitchen sink: https://ajaxorg.github.io/ace-builds/kitchen-sink.html Just set the mode to LaTeX and with this document content

\usepackage{amsmath}
\title{\LaTeX}
\date{}
<start typing here>

begin typing \begin{document}. Once you finish typing begin, the console error will show up.

This doesn't appear to happen if there is any text after where you would be typing \begin{..., like this

<start typing here>
some other stuff

typing \begin does not make the error appear.

Created at 1 week ago
closed issue
Python: smartquotes with f-strings

Describe the bug

When using python in an editor typing print(f"{test}") results in a smart quote being added on the second quote but not the first.

Expected Behavior

I'd expect a smartquote to be added on the first quote.

Current Behavior

A smartquote is added when you are closing the quote on the f-string.

Reproduction Steps

typing print(f"{test}")

Or any f-string with a variable.

Possible Solution

Detecting parameters that create f-strings

Additional Information/Context

This might also be a problem for raw strings in python.

Ace Version / Browser / OS / Keyboard layout

I tested this on the live version too https://ace.c9.io/build/kitchen-sink.html -- browser is firefox, also reproduced in chrome.

Created at 1 week ago
issue comment
Python: smartquotes with f-strings

Released in 1.16.0

Created at 1 week ago
issue comment
Error in mode-latex getType

Released in 1.16.0

Created at 1 week ago
create tag
andrewnester create tag v1.16.0
Created at 1 week ago

release v1.16.0

Created at 1 week ago
create tag
andrewnester create tag v1.16.0
Created at 1 week ago

package 17.03.23

Created at 1 week ago

package 17.03.23

Created at 1 week ago

feat: Inline autocompletion (#5084)

  • Inline ghost-text autocompletion

Added optional ghost-text preview to popup-based autocompletion (disabled by default) New external inline-autocompletion widget which supports ghost-text only autocompletion

  • Autocomplete bugfixes

Added the inline autocompletion to the kitchen sink demo Added kitchen sink demo option to enable inline preview for popup-based autocomplete Inline completion and command bar tooltip are changed to be editor scoped

  • Update src/ext/inline_autocomplete.js

Co-authored-by: André Oliveira andreduartecoliveira@gmail.com

  • Fix styling and add cross-editor tests

  • Fix for popup display positioning for autocompletion

  • Add popup display unit tests


Co-authored-by: André Oliveira andreduartecoliveira@gmail.com

Created at 1 week ago
pull request closed
feat: inline autocompletion

Issue #, if available: N/A

Description of changes: Inline autocompletion feature. Minor fixes to ghost text display. Snippet manager preview text.

The popup-based autocompletion is augmented with optional inline-code rendering. This feature is turned off by default, so no unexpected ghost text appears for users in the new version. It can be turned on with the inlineEnabled boolean flag in the Autocomplete widget. This autocompletion displays the inline completions on a best effort basis (if the completion's prefix allows it), as the autocomplete settings might not be fully compatible with inline completion (eg: matches based on caption not prefix might cannot be rendered inline). If the inline completions are enabled, the popup position is dynamically updated whenever it would overlay a multi-line inline completion suggestion.

An other external widget was created which can be used for inline-only completion. Here, all the completions are guaranteed to be compatible with inline rendering, and the commands are set up in a way to promote more horizontal (left-right, rather than up-down) controls for autocompletion. This widget could be used as is, to allow both style of completions, or could be used as a reference implementation for integrators.

This external inline autocompletion widget works similarly to the previous popup-based autocompletion with a few differences:

  • It displays a slightly different set of completions (strict prefix match with exactMatch, and does not try to match on caption value)
  • It always renders a ghost text completion directly into the editor
  • It optionally shows a command bar tooltip with the available commands for easy navigation. These commands are dynamically updated, and clickable.
  • Editor scrolling with mouse does not cancel the autocompletion (so long snippets can be also inspected)

Keybindings:

  • Manual trigger: Alt/Option-C
  • Previous suggestion: Alt/Option-[
  • Next suggestion: Alt/Option-]
  • Accept suggestion: Tab or Ctrl/Cmd-Right
  • Close suggestions: Esc

The popup and the inline style autocompletions are mutually exclusive, only one is attached at a time (they share the same editor.completer property). However, they can seamlessly switch when both of them are configured to different keybindings.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 1 week ago

fix: Added lateral keyword introduced in MySQL 8.0.14 (#5053)

Created at 1 month ago
pull request closed
added lateral keyword introduced in MySQL 8.0.14

Improved MySQL highlighting mode

Description of changes: added lateral keyword introduced in MySQL 8.0.14

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 1 month ago

fix: Improve MySQL highlighting mode (#5050)

Created at 1 month ago
pull request closed
Improve MySQL highlighting mode

Improve MySQL highlighting mode:

  • separate dataTypes highlighting mode
  • added timestamp dataTypes
  • 'by' keyword moved from builtins to mySqlKeywords
  • date|time|timestamp moved from constants to builtins Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Created at 1 month ago