andrew-demb
Repos
143
Followers
14
Following
28

Events

issue comment
BC break with GraphQL\Server\ServerConfig::setValidationRules signature in 14.11.7

@spawnia can you release a new patch release to avoid manual work with refetching same version with different hash with composer?

Created at 4 days ago
Conflict between strict types and PHP 8

This error triggered due to BC break from upstream library and changes will be reverted afterwards. So I recommend just to add conflict rule with problem version (like in https://github.com/craftcms/cms/commit/7f1bb95645ba49d415c5e27bb0c9e9865d2f6e85#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34)


This is simply declaring the types, nothing more, just upload this shit and it works

It is a BC break to code that extend changed scalar classes without added the same types onto. Also, Fatal error about incompatible type just one case from all possible with applied changed in broken version of webonyx/graphql-php, so there is no guarantee that patch will help to be fully compatible with that version (14.11.7)

Created at 5 days ago
Conflict between strict types and PHP 8

Do you have webonyx/graphql-php:14.11.7 installed?

They are broke BC with a patch version bump v14.11.7 See also: https://github.com/webonyx/graphql-php/issues/1221

Created at 5 days ago
opened issue
BC break with GraphQL\Server\ServerConfig::setValidationRules signature in 14.11.7

Signature of GraphQL\Server\ServerConfig::setValidationRules (https://github.com/webonyx/graphql-php/blob/688c6b7fae513c912581d3f9e141161fe5729191/src/Server/ServerConfig.php#L213) has been changed in v14.11.7.

Signature in v14.11.6 - https://github.com/webonyx/graphql-php/blob/6070542725b61fc7d0654a8a9855303e5e157434/src/Server/ServerConfig.php#L168) were not declared explicit return type.

As of this method marked as @api there were expectations about strong BC promise. For now this update breaks thecodingmachine/graphqlite-bundle https://github.com/thecodingmachine/graphqlite-bundle/blob/3ae908cc814dfa7283d869789db5852a200a46aa/Server/ServerConfig.php#L27

Proposed solution: revert changing method signature and apply this change only with next major version bump with changelog

Created at 5 days ago
Created at 3 weeks ago
Targeting PHP ^8.0

Can I replace Webmozart\Assert\Assert with native assert() for performance and better IDE code suggestion reason?

Does that Assert lib throw exceptions in a non dev env? If the result is the same, I don’t see why not. However, I haven’t looked into it’s intended use.

PHP's assert() wont be executed for non-dev environment. webmozart/assert checks and assert() expressions are the same from type safety perspective. webmozart/assert provides information in method contract about guarranted checked types in result.

So if there is a motivation to get less dependencies, simpler code and less checks for types in non-dev mode - it is OK to replace checks 🙂

Created at 3 weeks ago
Created at 3 weeks ago
issue comment
Up php version to 8.0. Add return types

Your git settings for project should probably be updated for clear commit author linking with the GitHub account.

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-email-address-for-a-single-repository

Created at 1 month ago
delete branch
andrew-demb delete branch resolve-deprecated-range-params
Created at 1 month ago

Typo in range query json parameter name

Refactored, added php8.* compatibility

fix property default values

Merge pull request #14 from atakajlo/fix-property-initialization

fix property default values

Bug fixes

Merge branch 'master' into bug-fixes

Merge pull request #15 from DevAndreyL/bug-fixes

Bug fixes

Merge pull request #11 from andrew-demb/patch-1

Typo in range query json parameter name

Use non-deprecated comparison operator params instead of from/to/include_lower/include_upper for range query

Deprecated since ElasticSearch 0.90 - https://www.elastic.co/guide/en/elasticsearch/reference/0.90/query-dsl-range-query.html

Created at 1 month ago
delete branch
andrew-demb delete branch patch-1
Created at 1 month ago
delete branch
andrew-demb delete branch patch-1
Created at 1 month ago
pull request opened
Fix image path for graphiql UI screenshot

With #2687 image extension was changed from .jpg to .png, but the readme link was not updated according to the new file extension

Created at 1 month ago

Fix image path for graphiql UI screenshot

Created at 1 month ago
Created at 1 month ago
delete branch
andrew-demb delete branch patch-1
Created at 1 month ago
pull request opened
Fix links to docs chapters

| Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Documented? | yes | Fixed tickets | #... | License | MIT

There is no docs for custom parameters and custom GraphQL endpoint, which were dropped in https://github.com/overblog/GraphiQLBundle/commit/1f7030574cb99dda2e1c8d24175c8dc89a5df865#diff-769b4cd82eac8712bf35bb9c552175b94ae31871b6e3dd20fdbe7f1994172e12 Was it on purpose? Should we drop their mention from readme?

Created at 1 month ago

Fix links to docs chapters

Created at 1 month ago
Created at 1 month ago
pull request opened
Fix example snippet syntax
Created at 1 month ago

Fix example snippet syntax

Created at 1 month ago