alistairjcbrown
Repos
60
Followers
30
Following
10

A package linker for lerna monorepos - use it to install packages from your monorepo into your application

Unofficial Node.js library for interacting with League of Comic Geeks

13
5

Saboteur game engine which implements the state and rules of the board game Saboteur

Diffing snapshot utility for Jest

Backup app for fitbit

Events

Remove scrollbar from popover when not required

Reviewer: @jonathanKingston

Description:

Task: https://app.asana.com/0/892838074342800/1202842358782954/f

  • Reduces the height of the popover contents so scrolling isn't required
  • Updates overflow to not always show scrollbar

For the screenshots below, "Show scroll bars" on macOS was set to "Always"

No email protection | Email protection (not scrolled) | Email protection (scrolled) --- | --- | --- Screenshot 2022-08-24 at 10 27 49 | Screenshot 2022-08-24 at 10 28 45 | Screenshot 2022-08-24 at 10 29 20

Steps to test this PR:

  1. Use this build of the extension
  2. When not signed into email protection, go to a webpage and view the popover
    • The popover will not scroll, and no scrollbar is visible
  3. Sign into email protection, go to a webpage and view the popover
    • The popover will scroll, and a scrollbar may be visible depending on your OS and settings

Automated tests:

  • [ ] Unit tests
  • [ ] Integration tests
Reviewer Checklist:
  • [ ] Ensure the PR solves the problem
  • [ ] Review every line of code
  • [ ] Ensure the PR does no harm by testing the changes thoroughly
  • [ ] Get help if you're uncomfortable with any of the above!
  • [ ] Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • [ ] Get advice or leverage existing code
  • [ ] Agree on technical approach with reviewer (if the changes are nuanced)
  • [ ] Ensure that there is a testing strategy (and documented non-automated tests)
  • [ ] Ensure there is a documented monitoring strategy (if necessary)
  • [ ] Consider systems implications
Created at 1 month ago

Remove scrollbar from popover when not required

  • Reduces the height of the popover contents so scrolling isn't required
  • Updates overflow to not always show scrollbar
Created at 1 month ago
alistairjcbrown create branch abrown/bugfix-popover-scrollbar-showing
Created at 1 month ago
pull request opened
Rename autofill content script message and format

Reviewer: @jonathanKingston Asana: https://app.asana.com/0/1162895505193104/1202817610595239/f

Description

Updates temp naming, as well as aligning with the messageType key format in the extension. This changes only affects the extension integration -- corresponding extension PR: https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/1354

Steps to test

Test in corresponding extension branch -- https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/1354

Created at 1 month ago
Abrown/rename autofill content script message

Reviewer: @jonathanKingston

Update autofill content script event name and format. Requires corresponding update to autofill

🛑 Before merging, confirm that this branch does not contain a DELETE commit and has updated autofill to the latest version.

Steps to test this PR:

  1. Load this extension branch in Firefox and enable Email Protection
  2. Go to https://duckduckgo.com/newsletter
  3. Confirm autofill is showing and working, confirm right click context menu is showing and working
  4. Disable tracking protections, page refreshes
  5. Confirm autofill is showing and working, confirm right click context menu is showing and working

Automated tests:

  • [ ] Unit tests
  • [ ] Integration tests
Reviewer Checklist:
  • [ ] Ensure the PR solves the problem
  • [ ] Review every line of code
  • [ ] Ensure the PR does no harm by testing the changes thoroughly
  • [ ] Get help if you're uncomfortable with any of the above!
  • [ ] Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • [ ] Get advice or leverage existing code
  • [ ] Agree on technical approach with reviewer (if the changes are nuanced)
  • [ ] Ensure that there is a testing strategy (and documented non-automated tests)
  • [ ] Ensure there is a documented monitoring strategy (if necessary)
  • [ ] Consider systems implications
Created at 1 month ago

DELETE -- bring in autofill update for testing

Created at 1 month ago
alistairjcbrown create branch abrown/rename-autofill-content-script-message
Created at 1 month ago
alistairjcbrown create branch abrown/rename-autofill-content-script-message
Created at 1 month ago

Enable autofill when protections are disabled

Created at 1 month ago
Enable autofill when protections are disabled

Reviewer: @jonathanKingston

Description:

Task: https://app.asana.com/0/1162895505193104/1202817610595239/f

Allow autofill to run when site is allowlisted

Steps to test this PR:

  1. Load this extension branch in Firefox and enable Email Protection
  2. Go to https://duckduckgo.com/newsletter
  3. Confirm autofill is showing and working, confirm right click context menu is showing and working
  4. Disable tracking protections, page refreshes
  5. Confirm autofill is showing and working, confirm right click context menu is showing and working

Automated tests:

  • [ ] Unit tests
  • [ ] Integration tests
Reviewer Checklist:
  • [ ] Ensure the PR solves the problem
  • [ ] Review every line of code
  • [ ] Ensure the PR does no harm by testing the changes thoroughly
  • [ ] Get help if you're uncomfortable with any of the above!
  • [ ] Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • [ ] Get advice or leverage existing code
  • [ ] Agree on technical approach with reviewer (if the changes are nuanced)
  • [ ] Ensure that there is a testing strategy (and documented non-automated tests)
  • [ ] Ensure there is a documented monitoring strategy (if necessary)
  • [ ] Consider systems implications
Created at 1 month ago
alistairjcbrown create branch abrown/enable-autofill-when-protections-disabled
Created at 1 month ago

Remove CheckboxPlugin interface from Facebook surrogate (#1342)

Allow body to scroll vertically to reach email alias button

Created at 1 month ago
Allow body to scroll vertically to reach email alias button

Reviewer: @GioSensation

Description:

Task: https://app.asana.com/0/0/1202815012139664/f

Update to allow popover to scroll vertically, which will allow access to the email alias button when both it and top blocked are disabled.

Steps to test this PR:

  1. Load extension
  2. Make sure to browse until "Top Tracking Offenders" button shows (if not already)
  3. Log into email protection account
  4. "Create new Duck Address" button is below the fold, but can now be scrolled to

Automated tests:

  • [ ] Unit tests
  • [ ] Integration tests
Reviewer Checklist:
  • [ ] Ensure the PR solves the problem
  • [ ] Review every line of code
  • [ ] Ensure the PR does no harm by testing the changes thoroughly
  • [ ] Get help if you're uncomfortable with any of the above!
  • [ ] Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • [ ] Get advice or leverage existing code
  • [ ] Agree on technical approach with reviewer (if the changes are nuanced)
  • [ ] Ensure that there is a testing strategy (and documented non-automated tests)
  • [ ] Ensure there is a documented monitoring strategy (if necessary)
  • [ ] Consider systems implications
Created at 1 month ago

Allow body to scroll vertically to reach email alias button

Created at 1 month ago

Allow body to scroll vertically to reach email alias button

Created at 1 month ago
alistairjcbrown create branch abrown/bugfix-scroll-for-email-alias-container
Created at 1 month ago