alexec
Repos
142
Followers
278
Following
16

Events

fix: changes

Signed-off-by: Alex Collins alex_collins@intuit.com

Created at 15 hours ago
pull request closed
fix: Build `git`. Fixes #10091

Fixes #10091

Please do not open a pull request until you have checked ALL of these:

  • [x] Create the PR as draft .
  • [ ] Run make pre-commit -B to fix codegen and lint problems.
  • [ ] Sign-off your commits (otherwise the DCO check will fail).
  • [ ] Use a conventional commit message (otherwise the commit message check will fail).
  • [ ] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [ ] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • [ ] Github checks are green.
  • [ ] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Created at 16 hours ago
jqFilter - no such file or directory

Pre-requisites

  • [X] I have double-checked my configuration
  • [X] I can confirm the issues exists when I tested with :latest
  • [ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

I have a simple script where I want to print the output using jqFilter.

No matter how I fill it in, it still returns " no such file or directory"

level=error msg="executor error: fork/exec kubectl get pod./argo-server-b944b94d6-mrxnt -n argo -o json | jq -rc'.': no such file or directory"

Version

v3.4.1

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

metadata:
  name: argocd-apps-filter
  namespace: argo
  labels:
    example: 'true'
    workflows.argoproj.io/creator: system-serviceaccount-argo-argo-server
  managedFields:
    - manager: kubectl-client-side-apply
      operation: Update
      apiVersion: argoproj.io/v1alpha1
      fieldsType: FieldsV1
      fieldsV1:
        f:metadata:
          f:labels:
            .: {}
            f:example: {}
    - manager: argo
      operation: Update
      apiVersion: argoproj.io/v1alpha1
      fieldsType: FieldsV1
      fieldsV1:
        f:metadata:
          f:labels:
            f:workflows.argoproj.io/creator: {}
        f:spec: {}
spec:
  templates:
    - name: main
      inputs: {}
      outputs: {}
      metadata: {}
      dag:
        tasks:
          - name: status
            template: status
            arguments: {}
    - name: status
      inputs: {}
      outputs:
        parameters:
          - name: job-name
            valueFrom:
              jsonPath: '{.metadata.name}'
          - name: job-obj
            valueFrom:
              jqFilter: .
      metadata: {}
      resource:
        action: get
        manifest: |
          apiVersion: v1
          kind: Pod
          metadata:
            name: argo-server-b944b94d6-mrxnt
            namespace: argo
  entrypoint: main
  arguments: {}
  serviceAccountName: default
  ttlStrategy:
    secondsAfterCompletion: 3000
  podGC:
    strategy: OnPodCompletion
  workflowMetadata:
    labels:
      example: 'true'

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow} level=info msg="capturing logs" argo=true level=info msg="Starting Workflow Executor" version=v3.4.1 level=info msg="Using executor retry strategy" Duration=1s Factor=1.6 Jitter=0.5 Steps=5 level=info msg="Executor initialized" deadline="0001-01-01 00:00:00 +0000 UTC" includeScriptOutput=false namespace=argo podName=argocd-apps-xg9cx-status-1464683396 template="{"name":"status","inputs":{},"outputs":{"parameters":[{"name":"job-name3","valueFrom":{"jsonPath":"{.metadata.name}"}},{"name":"job-obj","valueFrom":{"jqFilter":"."}}]},"metadata":{},"resource":{"action":"get","manifest":"apiVersion: v1\nkind: Pod\nmetadata :\n name: argo-server-b944b94d6-mrxnt\n namespace: argo\n"},"archiveLocation":{"archiveLogs":true,"s3":{"endpoint":"minio:9000","bucket":"my-bucket","insecure" :true,"accessKeySecret":{"name":"my-minio-cred","key":"accesskey"},"secretKeySecret":{"name":"my-minio-cred","key":"secretkey"},"key":"argocd-apps-xg9cx/argoc d-apps-xg9cx-status-1464683396"}}}" version="&Version{Version:v3.4.1,BuildDate:2022-10-01T15:03:42Z,GitCommit:0546fef0b096d84c9e3362d2b241614e743ebe97,GitTag:v3.4.1,GitTreeState:cl ean,GoVersion:go1.18.6,Compiler:gc,Platform:linux/amd64,}" level=info msg="Loading manifest to /tmp/manifest.yaml" level=info msg="kubectl get -f /tmp/manifest.yaml -o json" level=info msg="Resource: argo/pod./argo-server-b944b94d6-mrxnt. SelfLink: api/v1/namespaces/argo/pods/argo-server-b944b94d6-mrxnt" level=info msg="Saving resource output parameters" level=info msg="[kubectl get pod./argo-server-b944b94d6-mrxnt -o jsonpath={.metadata.name} -n argo]" level=info msg="Saved output parameter: job-name3, value: argo-server-b944b94d6-mrxnt" level=info msg="[kubectl get pod./argo-server-b944b94d6-mrxnt -n argo -o json | jq -rc '.']" level=error msg="executor error: fork/exec kubectl get pod./argo-server-b944b94d6-mrxnt -n argo -o json | jq -rc'.': no such file or directory" level=info msg="sub-process exited" argo=true error="" Error: exit status 1

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

Created at 19 hours ago
delete branch
alexec delete branch fix-9860
Created at 19 hours ago

fix: Make jq work. Fixes #9860 (#10150)

Signed-off-by: Alex Collins alex_collins@intuit.com

Created at 19 hours ago
pull request closed
fix: Make `jq` work. Fixes #9860

Signed-off-by: Alex Collins alex_collins@intuit.com

Fixes #9860

Please do not open a pull request until you have checked ALL of these:

  • [x] Create the PR as draft .
  • [x] Run make pre-commit -B to fix codegen and lint problems.
  • [x] Sign-off your commits (otherwise the DCO check will fail).
  • [x] Use a conventional commit message (otherwise the commit message check will fail).
  • [x] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [x] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • [x] Github checks are green.
  • [x] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Created at 19 hours ago
pull request opened
fix: Build `git`. Fixes #10091

Fixes #10091

Please do not open a pull request until you have checked ALL of these:

  • [x] Create the PR as draft .
  • [ ] Run make pre-commit -B to fix codegen and lint problems.
  • [ ] Sign-off your commits (otherwise the DCO check will fail).
  • [ ] Use a conventional commit message (otherwise the commit message check will fail).
  • [ ] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [ ] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • [ ] Github checks are green.
  • [ ] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Created at 19 hours ago
create branch
alexec create branch fix-10091
Created at 19 hours ago

fix: changes

Signed-off-by: Alex Collins alex_collins@intuit.com

Created at 20 hours ago
issue comment
feat: Tweak the pod logs viewer

@rbreeze bump!

Created at 21 hours ago
pull request closed
KAFKA-2526 : fix deserializer/serializer from properties for console …

Signed-off-by: Alex Collins alex_collins@intuit.com Fixes KAFKA-2526

Configuration of the ConsoleProducer and ConsoleConsumer has been broken since 2017. Despite there being CLI options, these are ignored. The client.properties file is also ignored for both.

I have a custom deserilazer and serializer that I want to use (it does encryption and decryption).

This is behavior correction rather than change. There are no tests, or test infrastructure for these two tools.

Testing will be manual.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)
Created at 21 hours ago
issue comment
KAFKA-2526 : fix deserializer/serializer from properties for console …

We ended up building our own tool.

Created at 21 hours ago

fix: go-git error empty git-upload-pack given. Fixes #9613 (#9982)

Signed-off-by: Rohan Kumar rohan@pipekit.io

fix (argo wait): use functions to constrain ctx instead of blocks (#10140)

Signed-off-by: scott scottwangsxll@gmail.com

Merge branch 'master' into fix-9839

Signed-off-by: Alex Collins alex_collins@intuit.com

Created at 21 hours ago
pull request opened
fix: Make `jq` work. Fixes #9860

Signed-off-by: Alex Collins alex_collins@intuit.com

Fixes #TODO

Please do not open a pull request until you have checked ALL of these:

  • [ ] Create the PR as draft .
  • [ ] Run make pre-commit -B to fix codegen and lint problems.
  • [ ] Sign-off your commits (otherwise the DCO check will fail).
  • [ ] Use a conventional commit message (otherwise the commit message check will fail).
  • [ ] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [ ] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • [ ] Github checks are green.
  • [ ] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Created at 21 hours ago

fix: Make jq work. Fixes #9860

Signed-off-by: Alex Collins alex_collins@intuit.com

Created at 21 hours ago
create branch
alexec create branch fix-9860
Created at 21 hours ago
pull request opened
fix: Remove error. Fixes #9839, #9987

Signed-off-by: Alex Collins alex_collins@intuit.com

Fixes #9839 Fixes #9987

Please do not open a pull request until you have checked ALL of these:

  • [ ] Create the PR as draft .
  • [ ] Run make pre-commit -B to fix codegen and lint problems.
  • [ ] Sign-off your commits (otherwise the DCO check will fail).
  • [ ] Use a conventional commit message (otherwise the commit message check will fail).
  • [ ] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [ ] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • [ ] Github checks are green.
  • [ ] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Created at 23 hours ago
create branch
alexec create branch fix-9839
Created at 23 hours ago

fix (argo wait): use functions to constrain ctx instead of blocks (#10140)

Signed-off-by: scott scottwangsxll@gmail.com

Created at 23 hours ago
pull request closed
fix (argo wait): use functions to constrain ctx instead of blocks

Signed-off-by: scott scottwangsxll@gmail.com

Fixes: as the title says

Please do not open a pull request until you have checked ALL of these:

  • [x] Create the PR as draft .
  • [ ] Run make pre-commit -B to fix codegen and lint problems.
  • [x] Sign-off your commits (otherwise the DCO check will fail).
  • [x] Use a conventional commit message (otherwise the commit message check will fail).
  • [x] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [x] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • [ ] Github checks are green.
  • [x] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Created at 23 hours ago
getting `empty git-upload-pack given` from wf using git artifacts as input

Summary

What happened/what you expected to happen?

  • started getting empty git-upload-pack given from workflows that use git artifacts as their input, and the pipeline just stays stuck at the init stage like that (https://cloud-native.slack.com/archives/C01QW9QSSSK/p1663593342339939)
  • It was working perfectly before the upgrade and one push after the upgrade.
  • Is it maybe trying to use a different user than specified in the url? It seems like there's some kind of Auth param that was added here: https://github.com/argoproj/argo-workflows/blob/047952afd539d06cae2fd6ba0b608b19c1194bba/workflow/artifacts/git/git.go#L155
  • This was the cause: https://github.com/go-git/go-git/issues/328#issuecomment-1100218144
  • Removing depth solved it. But that's VERY impractical for large histories.

What version are you running? v3.4

Diagnostics

Paste the smallest workflow that reproduces the bug. We must be able to run the workflow.

 artifacts:
          - name: argo-source
            path: /workspace
            git:
              repo: https://myuser@bitbucket.org/mycompany/myrepo.git
              revision: c480097dfb84f12e897de3b1037dcecb7c86bc0e
              depth: 1
              usernameSecret:
                name: bitbucketserver-access
                key: username
              passwordSecret:
                name: bitbucketserver-access
                key: secret

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Created at 23 hours ago

fix: go-git error empty git-upload-pack given. Fixes #9613 (#9982)

Signed-off-by: Rohan Kumar rohan@pipekit.io

Created at 23 hours ago
pull request closed
fix: go-git error empty git-upload-pack given. Fixes #9613

Signed-off-by: Rohan Kumar rohan@pipekit.io

Fixes #9613

Please do not open a pull request until you have checked ALL of these:

  • [x] Create the PR as draft .
  • [x] Run make pre-commit -B to fix codegen and lint problems.
  • [x] Sign-off your commits (otherwise the DCO check will fail).
  • [x] Use a conventional commit message (otherwise the commit message check will fail).
  • [x] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [x] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • [x] Github checks are green.
  • [x] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Created at 23 hours ago