alexandre-daubois
Repos
7
Followers
22
Following
9

The Symfony PHP framework

27459
8580

Provides an object-oriented API to query in-memory collections in a SQL-style.

15
1

The PHP Interpreter

C
1
0

Events

Created at 1 month ago
issue comment
[Debug] Add `resolve-env` option documentation of `debug:config` command

Great, thanks!

Created at 2 months ago
pull request opened
[Debug] Add `resolve-env` option documentation of `debug:config` command

Resolves #17028

Created at 2 months ago
alexandre-daubois create branch feat/resolve-env-option
Created at 2 months ago
issue comment
[FrameworkBundle] Add `resolve-env` option to debug:config command

Very interesting, thank you for the investigation Jérôme!

Also, the rebase is done :slightly_smiling_face:

Created at 2 months ago

[DependencyInjection] Add missing use statement in test

[HttpFoundation] Fix TypeError on null $_SESSION in NativeSessionStorage::save()

[DoctrineBridge] Fix comment for type on Query::setValue (middlewares)

Fix typographical error in exception message in InputBag class

minor #46824 Fix typographical error in exception message in InputBag class (tacrawford91)

This PR was merged into the 6.0 branch.

Discussion

Fix typographical error in exception message in InputBag class

| Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no

The word "Excepted" does not seem to be contextually correct, since the message is to convey the input types that are expected. (Opened new PR following advice from @lyrixx on #46820 )

Commits

bf7ed68766 Fix typographical error in exception message in InputBag class

bug #46811 [DoctrineBridge] Fix comment for type on Query::setValue (middlewares) (l-vo)

This PR was merged into the 5.4 branch.

Discussion

[DoctrineBridge] Fix comment for type on Query::setValue (middlewares)

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR |

See #46810 and #46744

Commits

928a7542ed [DoctrineBridge] Fix comment for type on Query::setValue (middlewares)

Merge branch '5.4' into 6.0

  • 5.4: [DoctrineBridge] Fix comment for type on Query::setValue (middlewares)

Merge branch '6.0' into 6.1

  • 6.0: Fix typographical error in exception message in InputBag class [DoctrineBridge] Fix comment for type on Query::setValue (middlewares)

[Serializer] Provide context information from attribute for promoted properties

feature #46680 [Serializer] Provide context information from attribute for promoted properties (DanielBadura)

This PR was submitted for the 5.4 branch but it was squashed and merged into the 6.2 branch instead.

Discussion

[Serializer] Provide context information from attribute for promoted properties

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

I refactored some classes to using property promotion wiht #[Context] attributes and my tests started to fail since the context was missing then. So i tried to retrieve this context at the AbstractNormalizer and added a testcase for that.

I'm not sure if this is the right place for getting this metadata information and if i have overseen something.

Commits

c51c4e63e8 [Serializer] Provide context information from attribute for promoted properties

Remove unneeded annotation

add missing basque translations

minor #46830 add missing basque translations (aetxebeste)

This PR was merged into the 4.4 branch.

Discussion

add missing basque translations

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes/no | Deprecations? | yes/no | Tickets | Fix #43419 | License | MIT | Doc PR | symfony/symfony-docs#...

Commits

c222e502bf add missing basque translations

[Form] Provide string keys when iterating on a form

feature #46813 [Form] Provide string keys when iterating on a form (VincentLanglet)

This PR was squashed before being merged into the 6.2 branch.

Discussion

[Form] Provide string keys when iterating on a form

| Q | A | ------------- | --- | Branch? | 6.2 as recommended by https://github.com/symfony/symfony/issues/46698#issuecomment-1169942792 | Bug fix? | no (?) | New feature? | no | Deprecations? | no | Tickets | Fix #46698 | License | MIT | Doc PR | symfony/symfony-docs#...

cc @derrabus

Commits

69de9a2232 [Form] Provide string keys when iterating on a form

Introduce FlashBagAwareSessionInterface

feature #46491 Introduce FlashBagAwareSessionInterface (VincentLanglet)

This PR was squashed before being merged into the 6.2 branch.

Discussion

Introduce FlashBagAwareSessionInterface

| Q | A | ------------- | --- | Branch? | 6.2 for features | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #41765 | License | MIT | Doc PR | symfony/symfony-docs#... Not needed

This solve https://github.com/symfony/symfony/issues/41765

People will be able to write

$session = $request->getSession();
if ($session instanceof FlashBagAwareSessionInterface) {
     $session->addFlashBag(...);
}

This is better than a instanceof Session check (which is not working with decoration).

Commits

026c748208 Introduce FlashBagAwareSessionInterface

minor #46656 [DependencyInjection] Add missing use statement in test (HypeMC)

This PR was merged into the 6.2 branch.

Discussion

[DependencyInjection] Add missing use statement in test

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

Looks like #46279 removed a use statement by accident. This PR returns the missing use statement & fixes the tests.

Commits

b03cbe65c2 [DependencyInjection] Add missing use statement in test

Add deprecation when the session is not FlashBagAware

feature #46831 Add deprecation when the session is not FlashBagAware (VincentLanglet)

This PR was squashed before being merged into the 6.2 branch.

Discussion

Add deprecation when the session is not FlashBagAware

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | Fix #... | License | MIT | Doc PR | symfony/symfony-docs#...

Follow up of https://github.com/symfony/symfony/pull/46491

Since there is now an interface for the getFlashBag method, we should add the check in the addFlash method.

Commits

76bb06477f Add deprecation when the session is not FlashBagAware

Created at 2 months ago
issue comment
[FrameworkBundle] Add `resolve-env` option to debug:config command

Didn't think of this case @GromNaN, thank you! I'm taking a look at it soon.

Created at 2 months ago

[FrameworkBundle] Add resolve-env option to debug:config command

Created at 2 months ago
issue comment
Replace annotations by attributes in Serializer and Controller

I am 👍 on your comment @javiereguiluz! Indeed, annotations are being replaced by attributes but I didn't see some "official" deprecation about annotations for the moment (and we won't see any before PHP 8 becomes the lowest supported version I guess!). In any case I'll be happy to make the change if needed!

Created at 2 months ago
pull request opened
Replace annotations by attributes in Serializer and Controller

Resolves https://github.com/symfony/symfony-docs/issues/16877

Created at 2 months ago

Replace annotations by attributes in Serializer and Controller

Created at 2 months ago
alexandre-daubois delete branch phpstan-extractor-5_4
Created at 2 months ago
alexandre-daubois create branch feat/groups-attribute
Created at 2 months ago
Created at 2 months ago
pull request opened
[Console] Add Multiselect to choice()

Resolves #16963

Created at 2 months ago
alexandre-daubois create branch feat/multiple-choices
Created at 2 months ago
issue comment
Hide sensitive information with `SensitiveParameter` attribute

I think this could be added as a .. note: somewhere in the Security documentation just to inform developers of this from PHP 8.2. But I can't exactly decide where to add this, in the Security documentation?

Created at 2 months ago
issue comment
DateTime object comparison after applying delta less than 1 second

I reproduced this. From what I found, the problem seems to come from the change made in 091c0920, exactly here in this file: https://github.com/php/php-src/blob/PHP-8.1/ext/date/php_date.c#L3008

Reverting the change gives the expected output.

Created at 2 months ago
issue comment
Fix GH-8841: error on return type check of func declaration isn't removing the function from function_table

Thank you for the feedback! Added the condition, I agree it's better like this.

I'm not quite sure about zend_register_seen_symbol() in zend_begin_func_decl(). Would we need to undo this as well?

If I understand correctly, zend_register_seen_symbol() only takes in account the file context. Conflicting with a previous seen symbol here would mean that the file already contains two function declarations with the same function name? If this is the case, then I think we can do without the seen_symbols undo, as it is really unlikely to happen and would, I guess, cause an error earlier.

Created at 2 months ago

Fix phpGH-8841: error on return type check of func declaration isn't removing the function from function_table

Created at 2 months ago
issue comment
[BrowserKit] Add response management to BrowserKit documentation (without toArray)

Not able to edit milestone and so on but updated the description, thank you!

Created at 2 months ago

[PropertyInfo] Add PhpStan extractor to PropertyInfo available extractors

Created at 2 months ago
issue comment
Fix ordered lists in secrets management and Form component documentation

Thank you for your comment @javiereguiluz! Totally understand the reasons. Fortunately, I could only find the display problem of multiple "1." at these spots in the documentation, which is very limited. Good luck for the fix in the parser!

Created at 2 months ago

[PropertyInfo] Add PhpStan extractor to PropertyInfo available extractors

Created at 2 months ago
pull request closed
[PropertyInfo] Add PhpStan extractor to PropertyInfo available extractors (with promoted property)

Resolves #16730

Created at 2 months ago