akrys
Repos
9
Followers
16
Following
17

Events

started
Created at 3 weeks ago
pull request opened
Remove "Magic number" in PDF Output Paramter

see #12 for details

Created at 1 month ago
create branch
akrys create branch working-test-stage
Created at 1 month ago

fixes #12 "magic number" in pdf output parameter

Merge branch 'working-test-stage' into main

Created at 1 month ago
Created at 1 month ago
Suggestion: replace MPDF-Output Parameter 'S' with Mpdf\Output\Destination::STRING_RETURN

I just watched the video "Creating a PDF file in PHP using Mpdf" and I wondered what that parameter 'S' could mean in this line:

$contractNotePdf = $mpdf->output('', 'S');

So, I looked into the lib and I found that they use Mpdf\Output\Destination::STRING_RETURN for testing. (This is basically 'S')

I'd suggest to use the line as $contractNotePdf = $mpdf->output('', Mpdf\Output\Destination::STRING_RETURN);

This way it would be much easier to understand the meaning of this parameter.

Created at 1 month ago