Describe the issue

TEST(Table, ReservedGrowthUpdatesWhenTableDoesntGrow2) {
  IntTable t;
  for (int i = 0; i < 8; ++i) t.insert(i);
  // Want to insert twice without invalidating iterators so reserve.
  const size_t cap = t.capacity();
  t.reserve(3);
  // We want to be testing the case in which the reserve doesn't grow the table.
  ASSERT_EQ(cap, t.capacity());
  auto it = t.find(0);
  t.insert(100);
  t.insert(200);
  t.insert(300);
  // `it` should have been invalidated.
  EXPECT_EQ(*it, 0);
}

Steps to reproduce the problem

I'm not sure, but in such test will be unsigned overflow in

  void reset_reserved_growth(size_t reservation, size_t size) {
    reserved_growth_ = reservation - size;
  }

Is it expected?

What version of Abseil are you using?

master

What operating system and version are you using?

Linux 6.2.6-arch1-1

What compiler and version are you using?

clang version 15.0.7 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-pc-linux-gnu/12.2.1 Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1 Selected GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1 Candidate multilib: .;@m64 Candidate multilib: 32;@m32 Selected multilib: .;@m64

What build system are you using?

cmake version 3.26.1

CMake suite maintained and supported by Kitware (kitware.com/cmake).

Additional context

I think fix should be like this

  void reset_reserved_growth(size_t reservation, size_t size) {
    if (reservation > size) {
      reserved_growth_ = std::max(reservation - size, reserved_growth_);
    }
  }

Remove unnecessary includes

Fix flakiness issues in timing tests.

PiperOrigin-RevId: 519939158 Change-Id: I9b049fa55167ed4064f3909887eec7bc52601677

type_traits: don't use __is_trivially_relocatable with Clang on Windows.

It currently gives the wrong result for types with a user-provided destructor:

struct S {
  ~S();
};

static_assert(!__is_trivially_relocatable(S));

PiperOrigin-RevId: 519855600 Change-Id: I5f0659ad0831974805a5ed4b615e3b6250d23154

inlined_vector: destroy all types with trivial destructors efficiently.

There's no reason to require the type to be trivially copy-constructible/assignable in order to avoid running destructors—those traits have nothing to do with destruction.

PiperOrigin-RevId: 519822201 Change-Id: I2ed7bbb53f0c1a512017115ff29fb27a24c6b11a

absl int128: avoid shifting signed integer by a number of bits greater than or equal to the precision of the operand

PiperOrigin-RevId: 519808237 Change-Id: I9123b167b606d609b8f3924d6f4fd298fa866a90

Import of CCTZ from GitHub.

PiperOrigin-RevId: 519786979 Change-Id: Ic5b69c1ac37b47db01d613edca5504e6611657b5

Thank you so much That was the problem!!

Yeah your pip and python3 are using different Python installations. And you don't have absl-py (and anything else installed) for whatever python3 points to. You can try pip3 or python3 -m pip whenever you used pip.

Hi! I have installed all dependencies in the flare_remover app and i have a problem when i run the command. The enviroment that i'm using: The problem that i get: Thank you!!

This is the output, previously i had this one and i updated pip

What about python3 -m pip list?

Describe the issue

When building gRPC with bazel RBE, I'm getting the absl/types/compare.h(49): error C2338: Only literal "0" is allowed. error

The issue started happening after upgrading to protobuf 22.x, but the error seems to be coming from absl codebase. Perhaps this is some incompatibility with C++14 and MSVC from VS2019?

ERROR: T:/altsrc/github/grpc/test/core/xds/BUILD:232:13: Compiling test/core/xds/xds_listener_resource_type_test.cc failed: (Exit 2): cl.exe failed: error executing command
  cd /d T:/_bazel_output/pjdymepj/execroot/com_github_grpc_grpc
  SET BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
    SET GRPC_BAZEL_RUNTIME=1
    SET INCLUDE=C:\VS\VC\Tools\MSVC\14.29.30133\include;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\cppwinrt
    SET PATH=C:\VS\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\VS\Common7\IDE\VC\VCPackages;C:\VS\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\VS\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer;C:\VS\MSBuild\Current\bin\Roslyn;C:\VS\Common7\Tools\devinit;C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\VS\\MSBuild\Current\Bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\VS\Common7\IDE\;C:\VS\Common7\Tools\;;C:\Windows\system32
    SET PWD=/proc/self/cwd
    SET RUNFILES_MANIFEST_ONLY=1
    SET TEMP=C:\Users\ContainerAdministrator\AppData\Local\Temp
    SET TMP=C:\Users\ContainerAdministrator\AppData\Local\Temp
  C:\VS\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\cl.exe /nologo /DCOMPILER_MSVC /DNOMINMAX /D_WIN32_WINNT=0x0601 /D_CRT_SECURE_NO_DEPRECATE /D_CRT_SECURE_NO_WARNINGS /bigobj /Zm500 /EHsc /wd4351 /wd4291 /wd4250 /wd4996 /I. /Ibazel-out/x64_windows-opt/bin /Iexternal/com_google_absl /Ibazel-out/x64_windows-opt/bin/external/com_google_absl /Iexternal/com_google_googleapis /Ibazel-out/x64_windows-opt/bin/external/com_google_googleapis /Iexternal/upb /Ibazel-out/x64_windows-opt/bin/external/upb /Iexternal/utf8_range /Ibazel-out/x64_windows-opt/bin/external/utf8_range /Iexternal/com_google_protobuf /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf /Iexternal/zlib /Ibazel-out/x64_windows-opt/bin/external/zlib /Iexternal/boringssl /Ibazel-out/x64_windows-opt/bin/external/boringssl /Iexternal/com_github_cncf_udpa /Ibazel-out/x64_windows-opt/bin/external/com_github_cncf_udpa /Iexternal/com_envoyproxy_protoc_gen_validate /Ibazel-out/x64_windows-opt/bin/external/com_envoyproxy_protoc_gen_validate /Iexternal/com_github_cares_cares /Ibazel-out/x64_windows-opt/bin/external/com_github_cares_cares /Iexternal/com_googlesource_code_re2 /Ibazel-out/x64_windows-opt/bin/external/com_googlesource_code_re2 /Iexternal/envoy_api /Ibazel-out/x64_windows-opt/bin/external/envoy_api /Iexternal/opencensus_proto /Ibazel-out/x64_windows-opt/bin/external/opencensus_proto /Iexternal/com_google_googletest /Ibazel-out/x64_windows-opt/bin/external/com_google_googletest /Iexternal/bazel_tools /Ibazel-out/x64_windows-opt/bin/external/bazel_tools /Ibazel-out/x64_windows-opt/bin/external/com_google_googleapis /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src /Ibazel-out/x64_windows-opt/bin /Ibazel-out/x64_windows-opt/bin/external/com_github_cncf_udpa /Ibazel-out/x64_windows-opt/bin/external/com_envoyproxy_protoc_gen_validate /Ibazel-out/x64_windows-opt/bin/external/envoy_api /Ibazel-out/x64_windows-opt/bin/external/opencensus_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/_virtual_includes/protobuf /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_nowkt /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_lite /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/arena /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/arena_align /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/stubs/_virtual_includes/lite /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/port_def /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/arena_allocation_policy /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/arena_config /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/arena_cleanup /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/string_block /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/io/_virtual_includes/io /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/io/_virtual_includes/io_win32 /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/io/_virtual_includes/gzip_stream /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/stubs/_virtual_includes/stubs /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/io/_virtual_includes/printer /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/io/_virtual_includes/zero_copy_sink /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/io/_virtual_includes/tokenizer /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/_virtual_includes/importer /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/util/_virtual_includes/delimited_message_util /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/util/_virtual_includes/differencer /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/util/_virtual_includes/field_mask_util /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/util/_virtual_includes/json_util /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/json/_virtual_includes/json /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/json/_virtual_includes/parser /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/json/_virtual_includes/descriptor_traits /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/json/_virtual_includes/lexer /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/json/_virtual_includes/message_path /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/json/_virtual_includes/zero_copy_buffered_stream /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/json/_virtual_includes/untyped_message /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/util/_virtual_includes/type_resolver_util /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/json/_virtual_includes/unparser /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/json/_virtual_includes/writer /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/util/_virtual_includes/time_util /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/any_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/api_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/source_context_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/type_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/_virtual_includes/plugin_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/descriptor_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/duration_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/empty_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/field_mask_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/struct_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/timestamp_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/wrappers_proto /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/_virtual_includes/code_generator /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/_virtual_includes/command_line_interface /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/cpp/_virtual_includes/cpp /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/cpp/_virtual_includes/names /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/cpp/_virtual_includes/names_internal /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/_virtual_includes/retention /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/csharp/_virtual_includes/csharp /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/csharp/_virtual_includes/names /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/java/_virtual_includes/java /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/java/_virtual_includes/names /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/java/_virtual_includes/names_internal /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/objectivec/_virtual_includes/objectivec /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/objectivec/_virtual_includes/line_consumer /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/objectivec/_virtual_includes/names /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/objectivec/_virtual_includes/names_internal /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/php/_virtual_includes/php /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/php/_virtual_includes/names /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/python/_virtual_includes/python /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/compiler/ruby/_virtual_includes/ruby /Iinclude /Ibazel-out/x64_windows-opt/bin/include /Isrc/core/ext/upb-generated /Ibazel-out/x64_windows-opt/bin/src/core/ext/upb-generated /Isrc/core/ext/upbdefs-generated /Ibazel-out/x64_windows-opt/bin/src/core/ext/upbdefs-generated /Isrc/core/include /Ibazel-out/x64_windows-opt/bin/src/core/include /Isrc/core/src/core/ext/upb-generated /Ibazel-out/x64_windows-opt/bin/src/core/src/core/ext/upb-generated /Isrc/core/src/core/ext/upbdefs-generated /Ibazel-out/x64_windows-opt/bin/src/core/src/core/ext/upbdefs-generated /Iexternal/zlib /Ibazel-out/x64_windows-opt/bin/external/zlib /Iexternal/boringssl/src/include /Ibazel-out/x64_windows-opt/bin/external/boringssl/src/include /Ithird_party/xxhash /Ibazel-out/x64_windows-opt/bin/third_party/xxhash /Ithird_party/address_sorting/include /Ibazel-out/x64_windows-opt/bin/third_party/address_sorting/include /Iexternal/com_github_cares_cares/include /Ibazel-out/x64_windows-opt/bin/external/com_github_cares_cares/include /Iexternal/com_github_cares_cares /Ibazel-out/x64_windows-opt/bin/external/com_github_cares_cares /Iexternal/com_google_protobuf/src/google/protobuf/wkt /Ibazel-out/x64_windows-opt/bin/external/com_google_protobuf/src/google/protobuf/wkt /Iexternal/com_google_googletest/googlemock /Ibazel-out/x64_windows-opt/bin/external/com_google_googletest/googlemock /Iexternal/com_google_googletest/googlemock/include /Ibazel-out/x64_windows-opt/bin/external/com_google_googletest/googlemock/include /Iexternal/com_google_googletest/googletest /Ibazel-out/x64_windows-opt/bin/external/com_google_googletest/googletest /Iexternal/com_google_googletest/googletest/include /Ibazel-out/x64_windows-opt/bin/external/com_google_googletest/googletest/include /Itest/core/util/include /Ibazel-out/x64_windows-opt/bin/test/core/util/include /Itest/core/util/src/core/ext/upb-generated /Ibazel-out/x64_windows-opt/bin/test/core/util/src/core/ext/upb-generated /Itest/core/util/src/core/ext/upbdefs-generated /Ibazel-out/x64_windows-opt/bin/test/core/util/src/core/ext/upbdefs-generated /Itest/core/event_engine/include /Ibazel-out/x64_windows-opt/bin/test/core/event_engine/include /Itest/core/event_engine/src/core/ext/upb-generated /Ibazel-out/x64_windows-opt/bin/test/core/event_engine/src/core/ext/upb-generated /Itest/core/event_engine/src/core/ext/upbdefs-generated /Ibazel-out/x64_windows-opt/bin/test/core/event_engine/src/core/ext/upbdefs-generated /Itest/cpp/util/include /Ibazel-out/x64_windows-opt/bin/test/cpp/util/include /Itest/cpp/util/src/core/ext/upb-generated /Ibazel-out/x64_windows-opt/bin/test/cpp/util/src/core/ext/upb-generated /Itest/cpp/util/src/core/ext/upbdefs-generated /Ibazel-out/x64_windows-opt/bin/test/cpp/util/src/core/ext/upbdefs-generated /DGRPC_PORT_ISOLATED_RUNTIME=1 /DCARES_STATICLIB /showIncludes /MD /O2 /Oy- /DNDEBUG /wd4117 -D__DATE__="redacted" -D__TIMESTAMP__="redacted" -D__TIME__="redacted" /Gy /Gw -DGRPC_BAZEL_BUILD /std:c++14 /Fobazel-out/x64_windows-opt/bin/test/core/xds/_objs/xds_listener_resource_type_test/xds_listener_resource_type_test.obj /c test/core/xds/xds_listener_resource_type_test.cc
# Configuration: 01161858ca5431053053b80434f2c1a48dbf382dff4b7d989aada28be8a11818
# Execution platform: //third_party/toolchains:rbe_windows_default_platform
external/com_google_absl\absl/types/compare.h(49): error C2338: Only literal `0` is allowed.
external/com_google_absl\absl/types/optional.h(704): note: see reference to class template instantiation 'absl::lts_20230125::compare_internal::Fail<T>' being compiled
        with
        [
            T=uint32_t
        ]

https://source.cloud.google.com/results/invocations/07335c45-6d16-44d8-bf4b-3b92d6472328/log

Steps to reproduce the problem

Build gRPC with bazel

What version of Abseil are you using?

abseil-cpp-20230125.0

What operating system and version are you using?

Windows 2019 Server

What compiler and version are you using?

MSVC from VS2019

What build system are you using?

bazel

Additional context

No response

I've released https://github.com/abseil/abseil-cpp/releases/tag/20230125.2 to address this issue.

I'm still getting the error And in pip appears that absl is installed

Fix the implementation of OnlyLiteralZero (#1420)

This patch changes the implementation of OnlyLiteralZero to only fail if the second overload is chosen, instead of failing during overload resolution.

This patch cherry-picks 2de126cc5826a8d464270ead65a7a9a7b012b741.

Fixes #1419

This patch changes the implementation of OnlyLiteralZero to only fail if the second overload is chosen, instead of failing during overload resolution.

This patch cherry-picks 2de126cc5826a8d464270ead65a7a9a7b012b741.

Fixes #1419

Make sure absl-py is really installed, by running python3 -c 'from absl import app'.

Other than this, it doesn't seem to be an issue we can help with on the absl side. Try flare_remover's?

Hi! I have installed all dependencies in the flare_remover app and i have a problem when i run the command. The enviroment that i'm using: The problem that i get: Thank you!!