Having the same issue with laravel composer projects
I'll merge by next week. It'll be easier for me to maintain it.
Would there be a way to maintain both?
https://github.com/revant/frappe_docker/blob/refactor-single-image/docs/custom-apps.md#load-custom-apps-through-json
should the Apps json be base64encoded string? easy to move around without causing character escape issues. json looks simple but simplicity can be achieved by piping json to base64 and passing that to build-arg.
anyone?
I would say it should probably be a json file for readability and not be base64 encoded
Followup to #975
chore(deps): Update pre-commit hooks (#976)
Co-authored-by: vrslev vrslev@users.noreply.github.com
chore(deps): bump webfactory/ssh-agent from 0.6.0 to 0.7.0 (#977)
Bumps webfactory/ssh-agent from 0.6.0 to 0.7.0.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore(deps): bump nginxinc/nginx-unprivileged in /images/nginx (#978)
Bumps nginxinc/nginx-unprivileged from 1.23.1-alpine to 1.23.2-alpine.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Use docker --chown command instead of RUN chown (#979)
The RUN chown -R frappe:frappe /home/frappe
command was taking too long for me, over 6 minutes before I gave up and killed it. docker chown is faster, and it helps avoid creating a new layer.
chore(deps): bump pytest from 7.1.3 to 7.2.0 (#982)
Bumps pytest from 7.1.3 to 7.2.0.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: Update example.env
chore: Update example.env
chore(deps): Update pre-commit hooks (#984)
Co-authored-by: vrslev vrslev@users.noreply.github.com
Prevent leaving pip install cache in Docker image (#985)
chore(deps): Update pre-commit hooks (#986)
Co-authored-by: vrslev vrslev@users.noreply.github.com
chore: Update example.env
chore: Update example.env
feat: install client apps using script (#992)
feat: install client apps using script
chore: ignore shellcheck pre-commit
chore: Update example.env
fix: incorrect eval for bool in bash (#995)
chore: Update example.env
fix(frappe-socketio): use package.json from frappe repo (#996)
fixes #994
chore: Update example.env
chore: Update example.env
chore(deps): Update pre-commit hooks (#1000)
Co-authored-by: vrslev vrslev@users.noreply.github.com
@revant I updated the pr with an ENV statement and tested it locally Seems to work like this when the env is not set. Can you verify?
feat: make proxy read timeout configurable via env
Hi have you ever thought about using caddy https://caddyserver.com/ to replace NGINX as an easier alternative.
I could provide a proof of concept if wanted. But i would like to hear thoughts on it first.
I changed the PWD and ran the pre-commit. About the helm chart: i'm not really sure how to add that there.
Concerning breaking current deployments the only way i would currently see is modifying the entrypoint to set the value as a default before envsubset replaces the config env variables. I will take a look at that next week.
feat: make proxy read timeout configurable via env
When starting steam the friendlist window is opened twice
Seems fixed for me now with the latest version could not reproduce it anymore
The main issue on start seems fixed, although while testing i noticed another way to reproduce the issue:
Then the window sometimes stays when i sign in again, sometimes it crashes and stays blank
When starting steam the friendlist window is opened twice