VincentLanglet
Repos
54
Followers
44
Following
11

A tool to automatically fix Twig Coding Standards issues

30
3

PHP Static Analysis Tool - discover bugs in your code without running it!

11347
782

The missing Symfony Admin Generator

2074
1250

Integrate Doctrine ORM into the SonataAdminBundle

427
333

The Symfony PHP framework

27485
8584

A declarative, efficient, and flexible JavaScript library for building user interfaces.

195608
39095

Events

issue comment
Wrong inference about array from PHPStan

The code started to fail with this commit: https://github.com/phpstan/phpstan-src/commit/8f441830a09850e8fdc0e0fa6b717c66b0428f0e

Created at 1 hour ago
pull request opened
Fix min max call on union types

Closes https://github.com/phpstan/phpstan/issues/8088

Created at 2 hours ago
VincentLanglet create branch minMax
Created at 2 hours ago
issue comment
Wrong inference about array from PHPStan

https://phpstan.org/r/4b292f19-c957-4967-89b6-31cdc3b31529

dumped type should be

Dumped type: non-empty-array<string, mixed>&hasOffsetValue('uses', non-empty-array)

and not

Dumped type: non-empty-array<string, non-empty-array>&hasOffsetValue('uses', non-empty-array)
Created at 3 hours ago
issue comment
Wrong int inference after a `max` call.

https://phpstan.org/r/4b292f19-c957-4967-89b6-31cdc3b31529

dumped type should be

Dumped type: non-empty-array<string, mixed>&hasOffsetValue('uses', non-empty-array)

and not

Dumped type: non-empty-array<string, non-empty-array>&hasOffsetValue('uses', non-empty-array)
Created at 3 hours ago
Fix errors in composer container page

Ready to merge @jordisala1991 ?

Created at 14 hours ago
`TestCase::assertSame` (and related exact comparisons) must compare `float` exactly

HI @mvorisek, with this change, I have some float comparison which are failing.

Basically with some things like

$this->assertEquals(0.3, 0.1+0.2);

Wouldn't be useful to provide the old implementation of assertEquals to another method ? Like assertFloatEquals ?

Created at 1 day ago
Fix sortable support for select2 4.x

I kinda lost the track of this PR.

@jorrit @jordisala1991 what is the status / next steps ?

Created at 1 day ago

Update frontend dependencies

Try to fix the github actions check

Fix build

Created at 1 day ago
pull request closed
Update frontend dependencies

Subject

I am targeting this branch, because this is BC.

Created at 1 day ago
pull request closed
Update frontend deps

Subject

I am targeting this branch, because this only applies to 4.x.

Created at 1 day ago
pull request closed
Update frontend dependencies

Subject

I am targeting this branch, because this is BC.

Created at 1 day ago

Update frontend dependencies

Fix rector

Fix frontend build

Created at 1 day ago

Update projects.yaml

Created at 1 day ago
delete branch
VincentLanglet delete branch jordisala1991-patch-2
Created at 1 day ago
pull request closed
Remove intl 2.x
Created at 1 day ago
delete branch
VincentLanglet delete branch jordisala1991-patch-1
Created at 1 day ago

Update frontend.yaml.twig

Created at 1 day ago
pull request closed
Make check-files work again

This step is suposed to trigger a failure if generated assets by Github Actions are different from the ones provided by the user.

Created at 1 day ago
On block delete in page composer redirect to that page composer not to BlockAdmin list

Now it redirects to BlockAdmin list that is not usable and not shown anywhere else.

Edit: This is problem with 3.x and 4.x.

  1. you go to /admin/app/sonatapagepage/1/compose
  2. select block to delete in the composer
  3. delete it
  4. you are redirected to /admin/app/sonatapageblock/list?composer=1&filter[_page]=1&filter[_per_page]=25&filter[page][value]=1 not back to /admin/app/sonatapagepage/1/compose
Created at 2 days ago

Fix remove button on compose page edit (#1625)

Created at 2 days ago
pull request closed
Fix remove button on compose page edit

Subject

I am targeting this branch, because this is in preparation for 4.0.

Closes #1601

Changelog

### Fixed
- Fix delete button while editting blocks on compose page.
Created at 2 days ago