This issue was discussed on esbuild's side: https://github.com/evanw/esbuild/issues/884

There is no way for esbuild to provide plugins support on the CLI, so it's up to AWS-CDK to allow us to configure esbuild through JS instead of through CLI alone.

In our case, we use @preconstruct/cli inside monorepo to resolve monorepo-internal dependencies. It needs an esbuild plugin to allow bundling to work correctly. Without it, we must build manually outside CDK first, and then hand over the build artifact to CDK. It would be much preferred to be able to use CDK esbuild bundling.

Thanks!

Thank you!

Is there anything I can do to help move this forward?

Bump actions/setup-node from 3.4.1 to 3.5.1 (#5356)

Bumps actions/setup-node from 3.4.1 to 3.5.1.

• Release notes
• Commits

updated-dependencies:

• dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Fix lib/.gitignore path separator on Windows. (#5325)

Fixes unexpected max acquire-timeout (#5377)

Important for applications where high pool contention is expected, and completion is favored over latency.

Co-authored-by: Matt matt.goodson.business@gmail.com

Fix: orWhereJson (#5361)

Add JSDoc (TS Flavour) to mjs stub file (#5390)

Bump sinon from 14.0.2 to 15.0.1 (#5413)

Bumps sinon from 14.0.2 to 15.0.1.

• Release notes
• Changelog
• Commits

updated-dependencies:

• dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] support@github.com

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

1227: add assertion for basic where clause values (#5417)

Bump tsd from 0.24.1 to 0.25.0 (#5396)

Bumps tsd from 0.24.1 to 0.25.0.

• Release notes
• Commits

updated-dependencies:

• dependency-name: tsd dependency-type: direct:development update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Prepare to release 2.4.0

Fix Postgres Malformed array literal 2.4.0 Regression (#5439)

Prepare to release 2.4.1

tests(insert): add tests for json, text array, integer array (#5451)

Additional lint checks before publishing (#5459)

Prepare to release 2.4.2

Update changelog

Fix usage of object type that is too broad.

Describe the bug Indexes can optionally specify the length of the column to be considered. The parser fails to parse CREATE TABLE statements with such indexes

Database Engine MySQL 8.0

To Reproduce -the SQL that be parsed

CREATE TABLE `Translation` (
  `id` char(36) CHARACTER SET ascii COLLATE ascii_bin NOT NULL,
  `en-GB` text,
  PRIMARY KEY (`id`),
  KEY `Translation_en-GB_btree_idx` (`en-GB`(768)),
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci

-the node-sql-parser version

4.6.5

-the node version

v18.13.0

Expected behavior The above SQL should parse

Actual behavior Error is thrown:

[SyntaxError]: Expected "#", ")", ",", "--", "/*", "ASC", "DESC", or [ \t\n\r] but "(" found.

Add vim copilot binding

Add vim test commands

We've had trouble in getting the behavior we desire from ENUMs, and have ended up using type overrides instead of relying on the generation.

In practice, we believe that a string literal union is the preferred type to be generated for an enum, rather than an TypeScript enum.

This is because TypeScript enums are somewhat of an abberation in TS - there are one of only 3 structures that do not get erased when compiling to JavaScript, but instead need to be compiled.

Additionally, they have a behavior similar to interfaces, where you can define an enum multiple times, and the declarations will be merged instead of erroring out.

We've found that for representing a database column enum, a string literal type union is preferrable.

Is there a way for sql-ts to generate a string literal type union for enums?

Thank you for the incredibly fast fix!

Add pnpm tab completion

Minor adjustments

Describe the bug The parser fails to parser `CREATE TABLE

Database Engine MySQL

To Reproduce -the SQL that be parsed

const { Parser } = require("node-sql-parser");                                                                                                                                                                                                              
const parser = new Parser();
  
let sql = `CREATE TABLE \`GeoCoordinateTable\` (
  \`geoCoordinate\` point NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci
`;                                                                                                                                                                                                                                                          
  
const ast = parser.parse(sql);

-the node-sql-parser version 4.6.4 -the node version 18.7.0

Expected behavior The above should not throw.

Screenshots

/Users/taozhi/Workspaces/OpenSources/node-sql-parser/pegjs/mysql.pegjs:2917
    return new peg$SyntaxError(
           ^
SyntaxError: Expected "#", "--", "->", "->>", ".", "/*", "BIGINT", "BINARY", "BIT", "CHAR", "DATE", "DATETIME", "DECIMAL", "DOUBLE", "ENUM", "FLOAT", "INT", "INTEGER", "JSON", "LONGTEXT", "MEDIUMTEXT", "NUMERIC", "SMALLINT", "TEXT", "TIME", "TIMESTAMP", "TINYINT", "TINYTEXT", "VARBINARY", "VARCHAR", "blob", "boolean", "longblob", "mediumblob", "tinyblob", or [ \t\n\r] but "p" found.
    at peg$buildStructuredError (/Users/taozhi/Workspaces/OpenSources/node-sql-parser/pegjs/mysql.pegjs:2917:12)
    at Object.typeCase [as mysql] (/Users/taozhi/Workspaces/OpenSources/node-sql-parser/pegjs/mysql.pegjs:28480:11)
    at r.value (/Users/taozhi/Workspaces/OpenSources/node-sql-parser/src/parser.js:20:43)
    at Object.<anonymous> (/home/ivan/holibob-worktree/master/database-scripts/test.js:15:20)
    at Module._compile (node:internal/modules/cjs/loader:1120:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1174:10)
    at Module.load (node:internal/modules/cjs/loader:998:32)
    at Function.Module._load (node:internal/modules/cjs/loader:839:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47