Tyrael
Repos
55
Followers
355
Following
87

Events

pull request opened
add support for client_key_contents

Description

adds support for chef-vault to use the private key from the client_key_contents chef configuration option

Related Issue

#401

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • [ x] I have read the CONTRIBUTING document.
  • [ ] I have run the pre-merge tests locally and they pass.
  • [x] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [x] All commits have been signed-off for the Developer Certificate of Origin.
Created at 1 week ago
create branch
Tyrael create branch use_client_key_contents
Created at 1 week ago

To add a workflow for Simplecov Report

Signed-off-by: snehaldwivedi sdwivedi@msystechnologies.com

Added simplecov gem

Signed-off-by: snehaldwivedi sdwivedi@msystechnologies.com

Merge pull request #387 from chef/snehal/integrate_simplecov_report

To integrate test coverage % report in PR creation or merge

Bump version to 4.1.6 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

Add workstation team as code-owner

Signed-off-by: Vikram Karve vikram.karve@progress.com

Merge pull request #388 from chef/vkarve/update-codeowner

Add workstation team as code-owner

Avoid loading all of chef-vault unless we're running the plugin (#385)

Right now any knife plugin even knife -h will load all these plugins and end up loading all of chef-vault. This avoids 12 requires total.

Signed-off-by: Tim Smith tsmith@chef.io

Bump version to 4.1.7 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

Test Ruby 3.0/3.1

Signed-off-by: poornima poorndm@progress.com

Modified GemFile

Signed-off-by: poornima poorndm@progress.com

pin chef & chef-utils ruby >=3

Signed-off-by: poornima poorndm@progress.com

corrected syntax error

Signed-off-by: poornima poorndm@progress.com

Remove extra space

Signed-off-by: poornima poorndm@progress.com

Modified pinned stmts

Signed-off-by: poornima poorndm@progress.com

Modified Version

Signed-off-by: poornima poorndm@progress.com

updated the HTTPServerException to HTTPClientException

Signed-off-by: nikhil2611 nikhilgupta2102@gmail.com

updated the key arguments

Signed-off-by: nikhil2611 nikhilgupta2102@gmail.com

updated the Gemfile

Signed-off-by: nikhil2611 nikhilgupta2102@gmail.com

updated chef-zero dependency

Signed-off-by: nikhil2611 nikhilgupta2102@gmail.com

updated some flags

Signed-off-by: nikhil2611 nikhilgupta2102@gmail.com

Created at 1 week ago
opened issue
add support for client_key_contents

Describe the Enhancement

chef supports passing the contents of the private key with client_key_contents since https://github.com/chef/chef/pull/6660/files I would expect this to also work with chef-vault but it looks it does not, and I couldn't find anything in the chef-vault codebase/issues regarding this

Describe the Need

I don't wanna persist the ssh key to disk, for chef signing that is already possible (either via ssh_agent_signing or using config.rb/knife.rb to programatically fetch the private key from a vault and set it via client_key_contents) but as chef-vault can't use agent signing (see #382 ) nor does it honor client_key_contents it looks my only option is to write the key to disk and pass the key path via client_key which means writing the key to disk

Current Alternative

not that I know of

Can We Help You Implement This?

if I'm not missing anything I'm happy to cook up a PR

Created at 1 week ago
Created at 1 week ago
Created at 1 month ago
Created at 1 month ago
issue comment
[NEEDS REVIEW] Fixes JENKINS-14520 - LDAP StartTLS support

the configuration page reporting error with the current plugin version is a separate issue, currently that always happen regardless if the settings are correct: https://issues.jenkins.io/browse/JENKINS-68748

Created at 2 months ago