5
8
11
Events
run_generators.sh: use project root as base dir
Merge #437 - run_generators.sh: use project root as base dir
Pull-request: #437
Signed-off-by: William Desportes williamdes@wdes.fr
Merge branch '5.8.x'
Fix TokensList::getPrevious which was not able to reach very first token
Add new method TokensList::getPreviousOfType + manage list of types in TokensList::getPreviousOfType and TokensList::getNextOfType
Add new SELECT test case
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/16741
Signed-off-by: William Desportes williamdes@wdes.fr
Add a new CREATE VIEW test case
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/18196
Signed-off-by: William Desportes williamdes@wdes.fr
Add a test case for ALTER TABLE with an INDEX expression
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/18236
Signed-off-by: William Desportes williamdes@wdes.fr
Implement a custom JSON serializer on top of the existing one to remove static properties from data files
Signed-off-by: William Desportes williamdes@wdes.fr
Remove static properties from data files
Signed-off-by: William Desportes williamdes@wdes.fr
Merge #428 - Fix TokensList::getPrevious which was not able to reach very first token
Pull-request: #428
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for #428
Pull-request: #428
Signed-off-by: William Desportes williamdes@wdes.fr
Fix coding standard issues after #428
Signed-off-by: William Desportes williamdes@wdes.fr
Also exclude asciiMap from .out files
Signed-off-by: William Desportes williamdes@wdes.fr
Make GitHub workflows run for PRs to this branch too
Signed-off-by: William Desportes williamdes@wdes.fr
Add test cases for parsing MySQL special comments
Ref: https://github.com/phpmyadmin/sql-parser/issues/226
Signed-off-by: William Desportes williamdes@wdes.fr
Fix TransactionStatement::build() "Call to a member function build() on null"
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for 7f8469460c
Ref: 7f8469460c20b276ff04ea987c3f1eaebfac80a7
Signed-off-by: William Desportes williamdes@wdes.fr
Improve the testParsephpMyAdminDump to re-build all the file
This is how I found the TransactionStatement::build() bug.
Ref: 7f8469460c20b276ff04ea987c3f1eaebfac80a7
Signed-off-by: William Desportes williamdes@wdes.fr
Fix #226 - Ignore end of comment string at the end of queries with MySQL-specific commands
Co-Authored-By: William Desportes williamdes@wdes.fr
Remove branch restriction for PRs
It makes no sense.
Ref: 6677c78cad7d3c729566df48fe75a195e7cb6046
Signed-off-by: William Desportes williamdes@wdes.fr
Merge #424 - Fix #226 - Ignore end of comment string at the end of queries with MySQL-specific commands
Pull-request: #424 Fixes: #226
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for #226
Pull-request: #424
Signed-off-by: William Desportes williamdes@wdes.fr
Fix management of ALTER USER when used with IDENTIFIED WITH option
Can you rebase this PR for 5.8 without closing this PR or creating a new one? I can do it on my end All PRs should target 5.8 except if they are breaking changes for 6.0/master
Done! :pray:
run_generators.sh: use project root as base dir
Fix management of ALTER USER when used with IDENTIFIED WITH option
run_generators.sh: use project root as base dir
Whenever you run php in a container, it might be difficult to know which folders / files to mount in the container. Thus, the whole current directory is usually mounted. But in this case, relying on parent folders is not possible.
Fix TokensList::getPrevious which was not able to reach very first token
Add new method TokensList::getPreviousOfType + manage list of types in TokensList::getPreviousOfType and TokensList::getNextOfType
Add new SELECT test case
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/16741
Signed-off-by: William Desportes williamdes@wdes.fr
Add a new CREATE VIEW test case
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/18196
Signed-off-by: William Desportes williamdes@wdes.fr
Merge branch '5.8.x'
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/18035
Add a test case for ALTER TABLE with an INDEX expression
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/18236
Signed-off-by: William Desportes williamdes@wdes.fr
Implement a custom JSON serializer on top of the existing one to remove static properties from data files
Signed-off-by: William Desportes williamdes@wdes.fr
Remove static properties from data files
Signed-off-by: William Desportes williamdes@wdes.fr
Merge #428 - Fix TokensList::getPrevious which was not able to reach very first token
Pull-request: #428
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for #428
Pull-request: #428
Signed-off-by: William Desportes williamdes@wdes.fr
Fix coding standard issues after #428
Signed-off-by: William Desportes williamdes@wdes.fr
Also exclude asciiMap from .out files
Signed-off-by: William Desportes williamdes@wdes.fr
Make GitHub workflows run for PRs to this branch too
Signed-off-by: William Desportes williamdes@wdes.fr
Add test cases for parsing MySQL special comments
Ref: https://github.com/phpmyadmin/sql-parser/issues/226
Signed-off-by: William Desportes williamdes@wdes.fr
Fix TransactionStatement::build() "Call to a member function build() on null"
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for 7f8469460c
Ref: 7f8469460c20b276ff04ea987c3f1eaebfac80a7
Signed-off-by: William Desportes williamdes@wdes.fr
Improve the testParsephpMyAdminDump to re-build all the file
This is how I found the TransactionStatement::build() bug.
Ref: 7f8469460c20b276ff04ea987c3f1eaebfac80a7
Signed-off-by: William Desportes williamdes@wdes.fr
Fix #226 - Ignore end of comment string at the end of queries with MySQL-specific commands
Co-Authored-By: William Desportes williamdes@wdes.fr
Remove branch restriction for PRs
It makes no sense.
Ref: 6677c78cad7d3c729566df48fe75a195e7cb6046
Signed-off-by: William Desportes williamdes@wdes.fr
Merge #424 - Fix #226 - Ignore end of comment string at the end of queries with MySQL-specific commands
Pull-request: #424 Fixes: #226
Signed-off-by: William Desportes williamdes@wdes.fr
Fix management of ALTER USER when used with IDENTIFIED WITH option
Fix management of ALTER USER when used with IDENTIFIED WITH option
Fix management of ALTER USER when used with IDENTIFIED WITH option
Fix management of ALTER USER when used with IDENTIFIED WITH option
Fix management of ALTER USER when used with IDENTIFIED WITH option
Fix TokensList::getPrevious which was not able to reach very first token
Add new method TokensList::getPreviousOfType + manage list of types in TokensList::getPreviousOfType and TokensList::getNextOfType
Add new SELECT test case
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/16741
Signed-off-by: William Desportes williamdes@wdes.fr
Add a new CREATE VIEW test case
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/18196
Signed-off-by: William Desportes williamdes@wdes.fr
Merge branch '5.8.x'
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/18035
Add a test case for ALTER TABLE with an INDEX expression
Ref: https://github.com/phpmyadmin/phpmyadmin/issues/18236
Signed-off-by: William Desportes williamdes@wdes.fr
Implement a custom JSON serializer on top of the existing one to remove static properties from data files
Signed-off-by: William Desportes williamdes@wdes.fr
Remove static properties from data files
Signed-off-by: William Desportes williamdes@wdes.fr
Merge #428 - Fix TokensList::getPrevious which was not able to reach very first token
Pull-request: #428
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for #428
Pull-request: #428
Signed-off-by: William Desportes williamdes@wdes.fr
Fix coding standard issues after #428
Signed-off-by: William Desportes williamdes@wdes.fr
Also exclude asciiMap from .out files
Signed-off-by: William Desportes williamdes@wdes.fr
Make GitHub workflows run for PRs to this branch too
Signed-off-by: William Desportes williamdes@wdes.fr
Add test cases for parsing MySQL special comments
Ref: https://github.com/phpmyadmin/sql-parser/issues/226
Signed-off-by: William Desportes williamdes@wdes.fr
Fix TransactionStatement::build() "Call to a member function build() on null"
Signed-off-by: William Desportes williamdes@wdes.fr
Add a CHANGELOG entry for 7f8469460c
Ref: 7f8469460c20b276ff04ea987c3f1eaebfac80a7
Signed-off-by: William Desportes williamdes@wdes.fr
Improve the testParsephpMyAdminDump to re-build all the file
This is how I found the TransactionStatement::build() bug.
Ref: 7f8469460c20b276ff04ea987c3f1eaebfac80a7
Signed-off-by: William Desportes williamdes@wdes.fr
Fix #226 - Ignore end of comment string at the end of queries with MySQL-specific commands
Co-Authored-By: William Desportes williamdes@wdes.fr
Remove branch restriction for PRs
It makes no sense.
Ref: 6677c78cad7d3c729566df48fe75a195e7cb6046
Signed-off-by: William Desportes williamdes@wdes.fr
Merge #424 - Fix #226 - Ignore end of comment string at the end of queries with MySQL-specific commands
Pull-request: #424 Fixes: #226
Signed-off-by: William Desportes williamdes@wdes.fr
Fix management of ALTER USER when used with IDENTIFIED WITH option
This fix is linked to following issues:
- https://github.com/phpmyadmin/sql-parser/issues/431
- https://github.com/phpmyadmin/phpmyadmin/issues/17654
Tithugues delete branch feature/list-of-types-for-getpreviousoftype-and-getnextoftype
Fix TokensList::getPrevious which was not able to reach very first token
Do you have a SQL statement that could create a regression test for us ?
I think that there already is one. The one used in the test class starts by SELECT, but as we can see in the test itself, when we are on index 2 (the * of the SELECT), then getting previous token again lead to null, whereas it should have lead to the SELECT token.
Is it clear enough? Does it make sense to you?
That's okay, 5.8 will replace 5.7 without any breaking changes. Like previous versions :)
Thanks! I hope it will be released soon then. :pray:
Add new method TokensList::getPreviousOfType + manage list of types in TokensList::getPreviousOfType and TokensList::getNextOfType
These changes aims to:
- support new request for a previous token based on a set of types
- support request for a next token based on a set of types, not only one
I intentionally didn't change all the getNextOfType* methods, as other methods have an additional filter which does not always make sense to combine with an array of types.
Additionally, this PR relies on changes done in PR https://github.com/phpmyadmin/sql-parser/pull/428.
