TattdCodeMonkey
Repos
39
Followers
26
Following
22

Events

fix sqs_message_attribute typing

Merge pull request #33 from balins/main

Fix sqs_message_attribute typing

Created at 2 days ago
pull request closed
Fix `sqs_message_attribute` typing

This PR fixes a dialyzer error when using message_attributes without the custom_type field.

The current typing results in a dialyzer error when using

    ExAws.SQS.send_message(sqs_url, body,
      message_attributes: [
        %{name: "name", data_type: :string, value: "value"}
     ]
    )

due to custom_type not being marked as an optional field o sqs_message_attribute type.

Created at 2 days ago
delete branch
TattdCodeMonkey delete branch rnorris/feat/ml-inference-ux-updates
Created at 2 days ago

[Enterprise Search][ML Inference] UX improvements (#149464)

Summary

Several UX improvements for the ML inference flyout as well as minor bug fixes:

  • aligned on a consisted title & paragraph for each step
  • test step layout and copy improvements
  • reworded create button copy
  • auto-selected "New" when there are no existing pipelines to choose
  • used correct class to scroll to error in flyout, updated from modal
  • fixed bug where error was thrown from kibana when there are no existing inference pipelines

Screenshots

Configure Step

image

Test

image

image

Review

image

Created at 2 days ago
pull request closed
[Enterprise Search][ML Inference] UX improvements

Summary

Several UX improvements for the ML inference flyout as well as minor bug fixes:

  • aligned on a consisted title & paragraph for each step
  • test step layout and copy improvements
  • reworded create button copy
  • auto-selected "New" when there are no existing pipelines to choose
  • used correct class to scroll to error in flyout, updated from modal
  • fixed bug where error was thrown from kibana when there are no existing inference pipelines

Screenshots

Configure Step image

Test image

image

Review image

Created at 2 days ago

[Fleet] experimental toggles for doc-value-only (#149131)

Summary

Closes https://github.com/elastic/kibana/issues/144357

WIP. Review can be started, but still requires a lot of testing and fixing the issue below.

How to test locally:

  • Turn on experimentalDataStreamSettings feature flag
  • Go to Add integration, System integration
  • On the first data stream, turn on the Doc value only switches, Save
  • The mapping changes are visible under Stack Management / Index Management / Component Templates e.g. logs-system.auth@package
  • The numeric switch sets index:false on all numeric field mappings (long, double, etc.)
  • The other switch sets index:false on all other field type mappings that support it (keyword, ip, date, etc.)
  • The new mappings will take effect after rollover

What works:

  • When turning the new doc-value-only numeric and other checkboxes on or off, the corresponding mapping changes are done in the component template
  • The logic also reads the package spec's template and preserves the index:false values regardless of the switch (tested manually by setting @timestamp field to index:false in the template, there is also the original field in logs-system.auth@package stream that is set to index:false in the package by default.
"original": {
    "index": false,
    "doc_values": false,
    "type": "keyword"
},

Pending:

  • Add/update unit and integration tests to verify the mapping change logic - DONE
  • Manual testing (turning the switches on/off, create/update package policy, upgrade package) - DONE
  • Clarify TODOs in the code about the supported types - DONE
  • Hitting an issue when turning on doc-value-only for "other" types (keyword, date, etc.). Could be that one of the fields doesn't support index:false setting. Didn't experience this when turning on only the numeric types. - FIXED
illegal_argument_exception: [illegal_argument_exception] Reason: updating component template [logs-system.auth@package] results in invalid composable template [logs-system.auth] after templates are merged

EDIT: found the root cause of this: Caused by: java.lang.IllegalArgumentException: data stream timestamp field [@timestamp] is not indexed

Checklist

Delete any items that are not applicable to this PR.

Co-authored-by: Kibana Machine 42973632+kibanamachine@users.noreply.github.com

[ci-stats] move shipper to a package, validate limits in on-merge job (#149474)

We just had an issue where two PRs were merged and it caused the limit of the triggerActionsUi bundle to be exceeded, breaking PR builds. The issue is that we didn't see any indication of this in the on-merge jobs because we don't produce the PR report for on-merge jobs or ask ci-stats if we should fail the job. Instead, we just ship the metrics for baseline purposes. This fixes that problem by adding a --validate flag to node scripts/ship_ci_stats, which takes care of sending at least some ci-stats and will verify that the bundle limits are not exceeded.

Since we didn't catch this issue in the on-merge job the limits were incorrect for over an hour and merged into many PRs, wasting engineering and CI time.

Co-authored-by: kibanamachine 42973632+kibanamachine@users.noreply.github.com

skip flaky suite (#149256)

[SecuritySolution] Fix data view not found when rendering with adHocDataView (#149513)

Summary

Please Enable feature flags. Please add this to kibana.dev.yml xpack.securitySolution.enableExperimental: ['chartEmbeddablesEnabled']

AdHocDataview requires a static reference to point internal reference Id to the given data view. The reference of data view will be lost If we re-generate internal reference Id every time the function is called. To fix this, I assigned the id out side of the function so it wouldn't change when the function is called.

Expected: Risk score over time should be rendered properly:

Checklist

Delete any items that are not applicable to this PR.

[Security Solution][Fleet] Fixes bug when adding Security Defend integration (#149232)

Summary

  • [x] Fixes a bug in the Add Elastic Defend Integration page in fleet where users would encounter a broken page when trying to add the security defend integration to their agent policy.

Screenshot

Before

https://user-images.githubusercontent.com/91867110/211752156-e678f6fc-4a79-4ead-b1d9-1eac9e82f912.mp4

After

integrationbug

[DOCS] Add "Updated on" column to the cases table screenshot (#149430)

skip flaky suite (#86545)

Add fields to Append Ingest Pipeline processor form (#149520)

Closes https://github.com/elastic/kibana/issues/145018

Summary

This PR adds the allow_duplicates and media_type fields to the Append Ingest Pipelines processor which allows these two settings to be set through the UI.

Recording:

https://user-images.githubusercontent.com/59341489/214585327-1e151931-61c2-4d0a-9f3d-1e4b920272cd.mov

Screenshot:

Checklist

[Index Management] Remove unused test (#149516)

Fix core app routes (#149462)

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | See more potential risk examples |

For maintainers

[Synthetics] Step details page, step selection, location fix (#149529)

[Security solution] Re-add country flag to Top Countries Table (#149460)

[Security Solution][Endpoint] Response Console framework support for argument value selectors (#148693)

Summary

  • PR adds the ability for Commands to define custom value selectors - components that will be rendered as the value when the Argument name is entered in the Console. These Argument Selectors can then provide the user with a better UX for selecting data that is not easily entered in the console via text input.
  • Introduces a File picker Argument Selector (not yet being used by real commands) that will be used in upcoming features.
  • Introduces a new mustHaveValue property to the definition of a command's argument.

See PR on github for info.

[main] Sync bundled packages with Package Storage (#149245)

Automated by https://internal-ci.elastic.co/job/package_storage/job/sync-bundled-packages-job/job/main/1469/

Co-authored-by: apmmachine infra-root+apmmachine@elastic.co

[Enterprise Search] Engine list - Show indices flyout (#149241)

Summary

Engine list - show indices flyout

https://user-images.githubusercontent.com/55930906/213495039-48713d0c-1c47-4af9-bc8c-41f71a9b8781.mov

When the Api Status returns Error

Checklist

Delete any items that are not applicable to this PR.

Co-authored-by: kibanamachine 42973632+kibanamachine@users.noreply.github.com

[Security Solution][Alerts] Add suppression icon to rule name in cases alerts table (#148934)

Summary

Addresses https://github.com/elastic/kibana/issues/145805

kibana.alert.suppression.docs_count field is not always returned in ecsData, sometimes it's in data instead. We now check both data sources for the docs_count.

image

[Andruil] Defend for containers UI fixes (#149372)

Summary

  • fix to invalid yaml causing null pointer in general view.
  • also fixed incrementName function to work past two digits when duplicating selectors
  • removed "click here" placeholder in yaml editor help text
  • fixed usability issue with removing all conditions in a selector. previously would be prevented, but now allows and shows a descriptive error.

Checklist

Delete any items that are not applicable to this PR.

Co-authored-by: Karl Godard karlgodard@elastic.co

[APM] Use constants for system indices (#149521)

We should use constants when referring to the system indices.

Update dependency @types/babel__core to ^7.20.0 (main) (#149561)

Mend
Renovate

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | @types/babel__core (source) | ^7.1.20 -> ^7.20.0 | age | adoption | passing | confidence |


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[Console] Update console readme (#149088)

Summary

This PR updates the Console readme file with information about the architecture changes, new features, and outstanding issues.

Co-authored-by: Muhammad Ibragimov muhammad.ibragimov@elastic.co Co-authored-by: Alison Goryachev alisonmllr20@gmail.com Co-authored-by: Kibana Machine 42973632+kibanamachine@users.noreply.github.com

Created at 2 days ago
issue comment
[Enterprise Search][ML Inference] UX improvements

@zombieFox the source field and target fields are rendered using a flex group. I could set the source or both to fullWidth to get rid of that space.

Created at 2 days ago
Created at 2 days ago