265
70
12
Events
Some people have needed stronger medicine
Signed-off-by: Steve Coffman steve@khanacademy.org
Add ability to customize resolvergen behavior using additional plugins (#2516)
-
Add ability to customize resolvergen behavior using additional plugins
-
Add field.GoResultName()
Co-authored-by: Brian Kamotho zshrlu@gmail.com
Add ability to customize resolvergen behavior using additional plugins
Describe your PR and link to any relevant issues.
I have:
- [ ] Added ability to customize resolvergen behavior using additional plugins. Relevant issue.
Add ability to customize resolvergen behavior using additional plugins
Hey, thanks! This is great, and I'm going to merge it, but I would love documentation or examples, or a test in a follow-up PR some time!
RemoveDuplicateTags func introduced to fix #2514
That makes sense! Hit me up with a PR if you feel like it should change to the behavior you originally proposed.
Upgrade to Postgresql 14 from 11, along with mac update script
Signed-off-by: Steve Coffman steve@khanacademy.org
Merge pull request #68 from Khan/psql_14
Upgrade to Postgresql 14 from 11, along with mac update script
Upgrade to Postgresql 14 from 11, along with mac update script
We have tested fairly extensively and found no real compatibility problems with upgrading from Postgresql 11 to 14, so we are updating this for local dev.
We are adding an update script to ease the transition for other developers.
Linux users should be able to self-service updating their own systems package managers.
Signed-off-by: Steve Coffman steve@khanacademy.org
RemoveDuplicateTags func introduced to fix #2514
As described in #2514, and without this PR, GoTagFieldHook just appends new tags, so @goTag will not override an existing tag.
Ideally it should override existing tag, since the sole purpose of the @goTag directive is to give control to user.
In this PR, the removeDuplicateTags helper func is introduced to fix #2514
I have:
RemoveDuplicateTags func introduced to fix #2514
Hey, I hope it's ok, but I merged the tweaks I made in #2533 as they seemed a little easier to read. I would be happy to accept a PR if you feel like yours is better.
Thanks!
@goTag do not override existing tag
Thanks for reporting this!
prepend goTag directive on struct tags and omit overridden duplicate struct tags per #2514 (#2533)
-
removeDuplicateTags func introduced to fix #2514
-
Change to prepend goTag directive
Signed-off-by: Steve Coffman steve@khanacademy.org
- Fix test for field_hooks_are_applied to prepend
Signed-off-by: Steve Coffman steve@khanacademy.org
Signed-off-by: Steve Coffman steve@khanacademy.org Co-authored-by: vallabh vallabh.joshi@gmail.com
@goTag do not override existing tag
@goTag do not override existing tag
Ideally it should override existing tag. sole purpose of the directive is to give control to user. Looks
GoTagFieldHook just appends new tags
https://github.com/99designs/gqlgen/blob/866187fd2510121d1b5f0d0636c8d37d80191c91/plugin/modelgen/models.go#L415
prepend goTag directive on struct tags and omit overridden duplicate struct tags per #2514
As described in #2514, and without this PR, GoTagFieldHook just appends new tags, so @goTag will not override an existing tag.
Ideally it should override existing tag, since the sole purpose of the @goTag directive is to give control to user.
In this PR, the removeDuplicateTags helper func is introduced to fix #2514
This PR was originally authored by @valllabh in #2531 but I have adjusted it slightly.
I have:
Fix test for field_hooks_are_applied to prepend
Signed-off-by: Steve Coffman steve@khanacademy.org
Fix test for field_hooks_are_applied to prepend
Signed-off-by: Steve Coffman steve@khanacademy.org
Fix test for field_hooks_are_applied to prepend
Signed-off-by: Steve Coffman steve@khanacademy.org
Valllabh master
As described in #2514, and without this PR, GoTagFieldHook just appends new tags, so @goTag will not override an existing tag.
Ideally it should override existing tag, since the sole purpose of the @goTag directive is to give control to user.
In this PR, the removeDuplicateTags helper func is introduced to fix #2514
I have:
Change to prepend goTag directive
I made this as an alternative to your original PR.
I have:
