fix image references
Merge pull request #747 from RaananW/badImageReferences
fix image references
Update closing.md
Merge pull request #748 from BabylonJS/RaananW-patch-1
Update link to game
Fixed typo
Merge pull request #749 from talanc/patch-2
Fixed typo
fix: typos in "material" related files
fix: s/inBabylon/in Babylon
Merge pull request #750 from PhilippeMorier/patch-11
fix: typos
Adding information and examples around instanced buffers and NME
Updated Mesh>Copies, Clones, and Instances>Instances page with some information about how to access instanced buffers color with node material. Also included a new example PG in the docs.
Update layerMask docs
Make more clear what operation is realized
Merge pull request #753 from BabylonJS/carolhmj-patch-1
Update layerMask docs
Add link to in depth layer mask
WGSL shaders: Added specific documentation for the use of the "color" attribute.
Merge pull request #755 from BabylonJS/Popov72-patch-1
WGSL shaders: Added specific documentation for the use of the "color" attribute
Merge pull request #752 from PatrickRyanMS/master
Adding information and examples around instanced buffers and NME
Update assetContainers.md
Merge pull request #754 from BabylonJS/carolhmj-patch-1
Add link to in depth layer mask
Add Figma to BabylonJS to Community Extensions
Fixed bad link
Any update on this one?
first pass
reuse where it can
add tests.
Review comments
initial commit
Review points
address review.
Fix stencil buffer creation with RTT
Physics Iteration 4
Merge pull request #13484 from Popov72/webgpu-fix-rtt-stencil
WebGPU: Fix stencil buffer creation with RTT
lint
fix build
Allow ImageBitmap for the buffer parameter of updateURL
trying to make the compiler happy
Fix format
review comments.
Merge pull request #13486 from BabylonJS/Popov72-patch-1
Texture: Allow ImageBitmap for the buffer parameter of updateURL
fix import geometry with same uniqueid
Merge pull request #13467 from carolhmj/fixAssetContainerInstantiation
Fix asset container instantiation with parented instanced nodes
Merge branch 'master' into fixBabylonFileLoader
For future reference - can we discuss this in the forum? We usually use github not to report issues, but to track work to be done.
Thanks so much for the PR.
I would rather test before making changes. I agree - we should fully support node 18. But I am not 100% sure this is the only change. I'm moving to to draft for now, until I get a change to fully test that
There are certain changes we will be happy to do ourselves, but we will be happy to see your suggested changes
These are old relics from an older version of the build system. We will be happy to take care of that if you point where you see it
Handle pointerlock rejections, if promise based (#13487)
handle pointerlock rejections, if promise based
ran prettier
This should get rid of the unhandled top-level exception if requesting pointer lock fails.
I think the intended way to use pointer lock in Babylon is to sub to onCanvasBlurObservable
and onCanvasFocusObservable
, so element.focus()
probably belongs into the resolved handler.
The alternative would be to focus regardless, but this is probably not desired:
if (promise instanceof Promise) promise.catch(() => {});
element.focus();
A good way to try this behaviour is to enter and exit pointerlock in quick succession on a chromium based browser.
Should be good now. there was a missing extension in production
Using the last version if you use the mouse wheel scroll trying to zoom out the video rendered in 360 start to visualize it like fisheye, how this could be limited or fixed to avoid this?.
example: https://drive.google.com/file/d/1jI8Dc5e_sDW9sDjYdTa3WHCF4y1347Sp/view?usp=sharing
Zoom Out create a fisheye view Fixes #247
Merge pull request #249 from BabylonJS/RaananW/issue247
Zoom Out create a fisheye view
Fixes #247 Missing extension added
Fixes #247 Missing extension added