NiklasBr
Repos
66
Followers
16
Following
9

The classic email sending library for PHP

19328
8470

Legend of the Five Rings Probabilities and Roller. This software is intended to supplement players and game masters when playing Legend of the Five Rings RPG (www.l5r.com/rpg).

Advent of Code 2017

0
0

Events

create branch
NiklasBr create branch patch-slug-validity
Created at 15 hours ago

Reevert slug limit (temporary)

Created at 15 hours ago
issue comment
Revisit URL slug check validity

While revisiting the validation, may I suggest to also return the offending characters? Something like this:

if (preg_match_all('/[#\?\*\:\\\\<\>\|"%&@=;]/', $item->getSlug(), $matches)) {
    throw new Model\Element\ValidationException('Slug contains forbidden characters: [ ' .  implode(' ', $matches[0]) . ' ] ');
}

Could save a lot of digging around.

Created at 15 hours ago
issue comment
Revisit URL slug check validity

Here's a list of allowed characters: https://stackoverflow.com/a/1547940

Created at 16 hours ago
issue comment
[Task] Improve check validity

Example of valid slug failing now:

/kabelmateriell/fortinnet-cu-strompe/copper-mesh-tape-no.63-nr.-63-b=45mm-l=200m

Created at 16 hours ago
issue comment
[Task] Improve check validity

@Corepex There is an unintentional BC break here. We are getting a number of errors after updating to ≥10.5.17 with

Error: "Validation failed: Slug contains forbidden characters!

These are not happening in 10.5.12 through 10.5.16.

Created at 16 hours ago
issue comment
[Bug]: Static Page Generator should not embed ESI content

Not fixed, just explained

Created at 16 hours ago
delete branch
NiklasBr delete branch patch-3
Created at 16 hours ago
issue comment
Remove unclickable area of WYSIWYG

Just try it yourself!

https://user-images.githubusercontent.com/279826/229092651-1c75517b-bf98-4d5a-b646-adcc14824560.mov

Created at 19 hours ago
issue comment
Remove unclickable area of WYSIWYG

Chrome, Edge, Safari, Firefox. All can reproduce this error on demo.pimcore.fun.

Created at 19 hours ago
delete branch
NiklasBr delete branch patch-1
Created at 19 hours ago
issue comment
Remove unclickable area of WYSIWYG

@martineiber this has nothing to do with two WYSIWYG elements. Nor about overlap. To reproduce:

  1. Create a single WYSIWYG area.
  2. Click on the bottom part of the area.

Expected result: Focus should happen in the WYSIWYG Actual result: WYSIWYG does not get focus.

Created at 19 hours ago
pull request opened
setWriterOptions renamed to writerOptions

Looks like this is what it should be https://github.com/endroid/qr-code/blob/9c507ea522454f0d5cb29be0911fe275463b8999/tests/BuilderTest.php#L28

Created at 21 hours ago

setWriterOptions renamed to writerOptions

Looks like this is what it should be https://github.com/endroid/qr-code/blob/9c507ea522454f0d5cb29be0911fe275463b8999/tests/BuilderTest.php#L28

Created at 21 hours ago
Created at 21 hours ago
issue comment
Well it caused my PC to fully freeze and crash due to the errors.

This app has nothing to do with VS Code, it is a self-contained app and not an extension.

Created at 22 hours ago
issue comment
Headless PDF printing inconsistent page width and height

🥳 five years and going!

Created at 1 day ago
pull request opened
Adds note about ESI & Static Page Generator in 09_Performance_Guide.md

Related to #14468.

Created at 1 day ago

Adds note about ESI & Static Page Generator in 09_Performance_Guide.md

Created at 1 day ago
pull request opened
Cleanup in 03_Navigation.md: Whitespace/indentation, consistent parameter keys, …

Changes in this pull request

Just some smaller changes.

Created at 1 day ago
create branch
NiklasBr create branch 03_navigation-cleanup
Created at 1 day ago

Cleanup in 03_Navigation.md: Whitespace/indentation, consistent parameter keys, …

Created at 1 day ago
issue comment
Deprecation Warning

I think this should be fixed once #704 is merged. I hope the maintainer can do it soon.

Created at 2 days ago
issue comment
[Task] Optimized composite index key

Tag as [security]?

Created at 2 days ago
delete branch
NiklasBr delete branch custom-reports-sql
Created at 3 days ago
delete branch
NiklasBr delete branch 14704-sql-custom-reports
Created at 4 days ago
issue comment
Well it caused my PC to fully freeze and crash due to the errors.

Are you sure this is the correct place to report your issue? ImageOptim is a Mac-only application.

Created at 4 days ago
issue comment
"context deadline exceeded" with consecutive requests

I don't know what else I can contribute with in this issue. Could never resolve it on my own.

Created at 6 days ago