@jshemas false
isn't an accepted type since it's only allowing string | undefined
. Is this an error on the types end or is a boolean value just not an actual type we can use?
@DuCanhGH I see you've made lots of changes since you forked the repo. I'm inclined to go with your fork instead but unsure what kind of impact your changes have on the package.
Per https://github.com/framer/motion/discussions/1775#discussioncomment-4299578 I have also tried using a template.tsx
file but that doesn't seem to work either, even though the Next docs specifically mention transitions to be a use-case for it: https://beta.nextjs.org/docs/routing/pages-and-layouts#templates.
That is weird although I think I have them working here https://codesandbox.io/p/sandbox/charming-pine-zz12kx
Your example uses the pages
directory. @maurocolella uses the new /app
directory: https://beta.nextjs.org/docs. While still experimental it's definitely the new way of creating Next apps.
There are seemingly a couple of issues with transitions. Most notable: the exit animations do not work (see video). I'm not sure whether the issue is with Framer or with Next. Next does seem to unmount the layout immediately upon navigation. I've tried adding usePresence
to allow Framer to remove an element after a timeout but even that doesn't work.
https://user-images.githubusercontent.com/6362631/213143210-634ce3fc-49ad-4135-b92a-9b1fe8aaa88d.mov
Add missing workbox entry point
Add support for app directory
Add to Murkrage scope
When creating a client using supabase-js
you have the option to use a custom fetch implementation. This currently isn't possible when creating either a browser or server client using the auth helpers.
In order to make use of Next 13's caching capabilities, I would like to be able to use their fetch implementation (which extends the native Fetch) with Supabase through the auth helpers. I think the best way to go about this is to allow us to provide the same client options we can provide using createClient()
directly from the main library.
Info on Next 13's fetch: https://beta.nextjs.org/docs/api-reference/fetch
Add structure to the project
Add day 3
Move all days into their own folder
Thanks for the workaround @samuba! However it seems type-fest
does not include those types? https://www.npmjs.com/package/type-fest
When creating a client using supabase-js
you have the option to use a custom fetch implementation. This currently isn't possible when creating either a browser or server client using the auth helpers.
In order to make use of Next 13's caching capabilities, I would like to be able to use their fetch implementation (which extends the native Fetch) with Supabase through the auth helpers. I think the best way to go about this is to allow us to provide the same client options we can provide using createClient()
directly from the main library.
Info on Next 13's fetch: https://beta.nextjs.org/docs/api-reference/fetch
Add day-2 solution
Move inputs into their own folder
Merge branch 'main' of github.com:Murkrage/advent-of-code
Unsure where else to add this specifically so am open to be pointed in the right direction.
The problem it solves:
When using an object (json) as a datatype, Typescript doesn't allow it to be used because it doesn't pick up on { [key: string]: Json }
. Adding object
as it's own possible type to the Json
type solves this issue.
Without this:
With:
The type/interface I'm using for instructions
:
export interface TInstruction {
id: string;
text: string;
}
Thanks for the reply @soedirgo! For whatever reason I hadn't considered the terrible type checking for object
. Which makes sense because most things are an object underneath.
Converting to a type
instead of an interface
indeed did the trick. A little confused as to why as you should be able to use both from a TS perspective. All good now, though. Just need a minor refactor on my end but that's alright.
Closing this one :)
Revert code style changes
Oh damn I just noticed Github Desktop decided to add a whole bunch of styling changes... I'll try and fix it 😅
Add object as possible type for Json