MLoughry
Repos
37
Followers
8
Following
1

Typescript solutions for topaz's Advent of Code 2018

0
0

Events

pull request opened
Fix regression with 'module.parents' when using Compilation stats

When I was iterating on #70, I fixed an issue where I was recording concatenated module names as <module path> + X modules; However, I failed to correct the same issue when recording the module names in module.parents, so there is now a mismtach between module.parents and the module names recorded.

This change fixes that regression.

Created at 14 hours ago
MLoughry create branch fix-regression-using-compilation-stats-in-concatenated-modules
Created at 14 hours ago
pull request opened
Support generating stats using Compilation object

For very large builds, serializing the stats to JSON can take quite an extended time. Since the wepback done callback includes a webpack.Stats object that includes a Compilation with all the relevant information, this change allows developers to pass that webpack.Stats object instead of the serialized webpack.StatsCompilation JSON.

Created at 6 days ago

Fix name for concatenated modules

Created at 6 days ago

Fix chunkGroupData

Created at 1 week ago

Remove instanceof against webpack types

Created at 1 week ago
MLoughry create branch use-compilation-stats
Created at 1 week ago

Fix null ref in use slider (#24728)

  • Fix null-ref in useSlider() when unmounts before mouseUp fires

  • Add change file

Created at 3 weeks ago
closed issue
[Bug]: Null reference in `useSlider()` when `<Slider />` unmounts before window mouseUp event fires

Library

React / v8 (@fluentui/react)

System Info

System:
    OS: Linux 5.4 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (32) x64 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
    Memory: 49.57 GB / 62.81 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash

Are you reporting Accessibility issue?

No response

Reproduction

https://codepen.io/MLoughry/pen/YzLwddZ

Bug Description

Actual Behavior

When you click on a <Slider />, and the component unmounts while the mouse button is down, and you then move the mosue while the mouse button is still down, there is a null-ref in useSlider()

Uncaught TypeError: Cannot read properties of null (reading 'getBoundingClientRect')
  at @fluentui/react/lib/components/src/components/Slider/useSlider.ts:269
  at @fluentui/react/lib/components/src/components/Slider/useSlider.ts:287

Expected Behavior

There is no null-ref errror

Logs

No response

Requested priority

High

Products/sites affected

Blocking Outlook rollout

Are you willing to submit a PR to fix?

yes

Validations

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] The provided reproduction is a minimal reproducible example of the bug.
Created at 3 weeks ago
pull request closed
Fix null ref in use slider

Current Behavior

When you click on a , and the component unmounts while the mouse button is down, and you then move the mosue while the mouse button is still down, there is a null-ref in useSlider()

New Behavior

There is no null-ref errror, as the window mouseMove events are cleaned up on unmount

Related Issue(s)

Fixes #24727

Created at 3 weeks ago
pull request opened
Fix null ref in use slider

Current Behavior

When you click on a , and the component unmounts while the mouse button is down, and you then move the mosue while the mouse button is still down, there is a null-ref in useSlider()

New Behavior

There is no null-ref errror, as the window mouseMove events are cleaned up on unmount

Related Issue(s)

Fixes #24727

Created at 3 weeks ago
opened issue
[Bug]: Null reference in `useSlider()` when `<Slider />` unmounts before window mouseUp event fires

Library

React / v8 (@fluentui/react)

System Info

System:
    OS: Linux 5.4 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (32) x64 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
    Memory: 49.57 GB / 62.81 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash

Are you reporting Accessibility issue?

No response

Reproduction

https://codepen.io/MLoughry/pen/YzLwddZ

Bug Description

Actual Behavior

When you click on a <Slider />, and the component unmounts while the mouse button is down, and you then move the mosue while the mouse button is still down, there is a null-ref in useSlider()

Uncaught TypeError: Cannot read properties of null (reading 'getBoundingClientRect')
  at @fluentui/react/lib/components/src/components/Slider/useSlider.ts:269
  at @fluentui/react/lib/components/src/components/Slider/useSlider.ts:287

Expected Behavior

There is no null-ref errror

Logs

No response

Requested priority

High

Products/sites affected

Blocking Outlook rollout

Are you willing to submit a PR to fix?

yes

Validations

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] The provided reproduction is a minimal reproducible example of the bug.
Created at 3 weeks ago
create branch
MLoughry create branch fix-null-ref-in-useSlider
Created at 3 weeks ago
issue comment
v9 release strategy

The faster from checkin to release, the better. Of the three options, only #1 comes close to that. Ideally, daily releases or even continuous delivery would be better.

Created at 1 month ago
issue comment
FluentProvider apply to target without creating new div

(especially considering every application has just one instance of the provider)

@miroslavstastny This is not true. In Outlook, we have several render roots (mostly, but not exclusively, for popups and modals and the like), and we have to apply the provider to each.

Created at 2 months ago

4.3.0 (#168)

Created at 2 months ago