LukeShu
Repos
64
Followers
20
Following
11

The systemd System and Service Manager

C
10422
2988

Local development against a remote Kubernetes or OpenShift cluster

5455
417

Minimalistic configuration management

88
6

Arch Linux repository management scripts (read-only mirror)

27
13

Una red libre virtual -- Herramientas administración y configuración

3
0

open source Kubernetes-native API gateway for microservices built on the Envoy Proxy

3953
622

Events

pull request opened
Add a README.md
Created at 1 week ago
create branch
LukeShu create branch lukeshu/readme
Created at 1 week ago

Revert "Revert "kates: Implement a kubectl apply-like function""

This reverts commit b613384a2e8b3c911615c1ef049c4150043da736.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "pkg/kubeapply: Transition to use pkg/kates rather than pkg/k8s""

This reverts commit 0138a10be7c873b6af22943c14c2dd585e6d12fb.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "kubeapply: Do a better job of waiting for CRDs""

This reverts commit a4ae83e8dd9c97a2ed5da6c4c04f07f20f36af19.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "Kill off pkg/k8s""

This reverts commit c9a6559099ee9f93395f311e0f740cf37a2c13d9.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "Kill off pkg/dtest""

This reverts commit 346d6f1ba2804c1a3cc6fd8378cab7c5b1bd75ba.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "Use the external github.com/emissary-ingress/goversion""

This reverts commit 8e3db81dcc40790c445ea41f7477d0b46e52210a.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Created at 1 week ago

Update MAINTAINERS.md

Since https://github.com/emissary-ingress/emissary/issues/4588 and https://github.com/emissary-ingress/emissary/issues/4589 have passed the required votes, lets close those out.

Signed-off-by: AliceProxy alicewasko@datawire.io

Merge pull request #4595 from emissary-ingress/alicewasko/update-maintainers

Update MAINTAINERS.md

dep: bump go to 1.19.2 to address security fixes

Signed-off-by: David Dymko ddymko@datawire.io

diagnostics: enable agent to report diagnostics

Updates the helm chart and manfiest to enable Ambassador Agent to report diagnostics to Ambassador Cloud. This reduces the setup friction for Ambassador Cloud users.

Introduces new helm value agent.reportDiagnostics: true. Setting it to false will disable Diagnostics reporting on the Agent.

The agent container now sets the AES_DIAGNOSTICS_URL environment variable to the admin service based on the default manifest and the helm values file. The user only needs to modify this if they use the manual manifest and manipulate the default admin service install location (i.e. change namespace).

Signed-off-by: Lance Austin laustin@datawire.io

Merge pull request #4598 from emissary-ingress/ddymko/dep/go-1192

dep: bump go to 1.19.2 to address security fixes

Bumping the statsd-sink sample deployment versions to apps/v1

Signed-off-by: alex alex@datawire.io

Update default chart autoscaling for better experience (#4290)

helm: update default chart autoscaling for better experience

The reordering of the metrics array fixes the ArgoCD issue, while the changes to the utilization values makes the HPA not immediately jump to maxReplicas

Signed-off-by: Ian Martin ian@imartin.net

build(deps): bump zipp from 3.6.0 to 3.9.0 in /docker/test-shadow

Bumps zipp from 3.6.0 to 3.9.0.


updated-dependencies:

  • dependency-name: zipp dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

build(deps): bump typing-extensions in /docker/test-shadow

Bumps typing-extensions from 4.0.1 to 4.4.0.


updated-dependencies:

  • dependency-name: typing-extensions dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

build(deps-dev): bump black from 22.6.0 to 22.10.0 in /python

Bumps black from 22.6.0 to 22.10.0.


updated-dependencies:

  • dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

build(deps): bump google.golang.org/grpc from 1.44.0 to 1.50.0

Bumps google.golang.org/grpc from 1.44.0 to 1.50.0.


updated-dependencies:

  • dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

deps: update DEPENDENCIES.md

Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

helm: add change log entry for auto-scaling changes

Updates helm change log for recent community contribution to the helm chart. Changelong is for the contribution submitted via: https://github.com/emissary-ingress/emissary/pull/4290.

Signed-off-by: Lance Austin laustin@datawire.io

build(deps): bump importlib-metadata in /docker/test-shadow

Bumps importlib-metadata from 4.8.3 to 5.0.0.


updated-dependencies:

  • dependency-name: importlib-metadata dependency-type: direct:production update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

build(deps): bump werkzeug from 2.0.2 to 2.2.2 in /docker/test-shadow

Bumps werkzeug from 2.0.2 to 2.2.2.


updated-dependencies:

  • dependency-name: werkzeug dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

build(deps): bump click from 8.0.3 to 8.1.3 in /docker/test-shadow

Bumps click from 8.0.3 to 8.1.3.


updated-dependencies:

  • dependency-name: click dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

build(deps): bump itsdangerous in /docker/test-shadow

Bumps itsdangerous from 2.0.1 to 2.1.2.


updated-dependencies:

  • dependency-name: itsdangerous dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

build(deps): bump flask from 1.0.2 to 2.2.2 in /docker/test-shadow

Bumps flask from 1.0.2 to 2.2.2.


updated-dependencies:

  • dependency-name: flask dependency-type: direct:production update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

build(deps): bump jinja2 from 2.10.1 to 3.1.2 in /docker/test-shadow

Bumps jinja2 from 2.10.1 to 3.1.2.


updated-dependencies:

  • dependency-name: jinja2 dependency-type: direct:production update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

build(deps): bump markupsafe from 2.0.1 to 2.1.1 in /docker/test-shadow

Bumps markupsafe from 2.0.1 to 2.1.1.


updated-dependencies:

  • dependency-name: markupsafe dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com Signed-off-by: Hamzah Qudsi hqudsi@datawire.io

Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Created at 1 week ago

rm -rf vendfor # [ci-skip]

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Don't check vendor/ in to Git

I moved some things out of generate.mk in to a new deps.mk; except for the comments, this is a pure cut/paste.

Signed-off-by: Luke Shumaker lukeshu@datawire.io (cherry picked from commit 50d9cd0f55436b07a9022cd1730dd456b2dc86d8)

Merge pull request #4704 from emissary-ingress/lukeshu/v2.5-no-vendor

[v2.5] Don't check vendor/ in to Git

Created at 1 week ago
LukeShu delete branch lukeshu/v2.5-no-vendor
Created at 1 week ago
pull request closed
[v2.5] Don't check `vendor/` in to Git

Description

This is a backport of https://github.com/emissary-ingress/emissary/pull/4475

Related Issues

  • https://github.com/emissary-ingress/emissary/pull/4475

Testing

CI worked?

Checklist

  • [ ] Does my change need to be backported to a previous release? - this is a backport. IMO further backporting to 1.14 isn't worth the effort

    • What backport versions were discussed with the Maintainers in the Issue?
  • [ ] I made sure to update CHANGELOG.md. - no applicable changes

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • [ ] This is unlikely to impact how Ambassador performs at scale. - not a runtime change

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • [ ] My change is adequately tested. - yes

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • [ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently. - no tricks

  • [ ] The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Created at 1 week ago
LukeShu delete branch lukeshu/mailmap
Created at 1 week ago

Write a .mailmap file (#4693)

  • Write a .mailmap file

I was trying to make some charts about number of contributors, and was thrown off by the same person showing up multiple ways; so I started writing a .mailmap file to normalize idents.

  • For outside contributors who have used more than 1 non-@users.noreply.github.com email address, I put zero effort in to determining which address they prefer; I just picked one arbitrarily.

  • I've gone ahead and moved myself to "Former employees"--I'm only here for another week.

This is the command I use to visually scan for idents that might be duplicates:

git log --all --format=$'%cN <%cE>\n%aN <%aE>' |sort | uniq -c

Signed-off-by: Luke Shumaker lukeshu@datawire.io

  • Update Ava's information

Signed-off-by: Luke Shumaker lukeshu@datawire.io

  • .mailmap: Improve comments

Signed-off-by: Luke Shumaker lukeshu@datawire.io

  • .mailmap: Normalize more names of current employees

Signed-off-by: Luke Shumaker lukeshu@datawire.io

  • .mailmap: Results of reaching out to former employees on LinkedIn

Signed-off-by: Luke Shumaker lukeshu@datawire.io

  • .mailmap: Results of reaching out to outside contributors via email

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Created at 1 week ago
pull request closed
Write a .mailmap file

Description

I was trying to make some charts about number of contributors, and was thrown off by the same person showing up multiple ways; so I started writing a .mailmap file to normalize idents.

  • For outside contributors who have used more than 1 non-@users.noreply.github.com email address, I put zero effort in to determining which address they prefer; I just picked one arbitrarily.

  • I've gone ahead and moved myself to "Former employees"--I'm only here for another week.

This is the command I use to visually scan for idents that might be duplicates:

git log --all --format=$'%cN <%cE>\n%aN <%aE>' | sort | uniq -c

Related Issues

(none)

Testing

I've spent a lot of time looking at that above git log command looking for names that might be duplicates.

Checklist

  • [ ] Does my change need to be backported to a previous release? - no

    • What backport versions were discussed with the Maintainers in the Issue?
  • [ ] I made sure to update CHANGELOG.md. - no applicable changes

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • [ ] This is unlikely to impact how Ambassador performs at scale. - not a runtime change

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • [ ] My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • [ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

  • [ ] The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Created at 1 week ago

deps: upgrade net and text pkg in golang.org/x

Upgrades packages to remove scan warnings for cve's:

golang.org/x/net - CVE-2022-27664

  • only effected 1.19.0 and below, we are currently on 1.19.3

golang.org/x/text - CVE-2022-32149

  • API not called in code base

Signed-off-by: Lance Austin laustin@datawire.io

Revert "Revert "kates: Implement a kubectl apply-like function""

This reverts commit b613384a2e8b3c911615c1ef049c4150043da736.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "pkg/kubeapply: Transition to use pkg/kates rather than pkg/k8s""

This reverts commit 0138a10be7c873b6af22943c14c2dd585e6d12fb.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "kubeapply: Do a better job of waiting for CRDs""

This reverts commit a4ae83e8dd9c97a2ed5da6c4c04f07f20f36af19.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "Kill off pkg/k8s""

This reverts commit c9a6559099ee9f93395f311e0f740cf37a2c13d9.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "Kill off pkg/dtest""

This reverts commit 346d6f1ba2804c1a3cc6fd8378cab7c5b1bd75ba.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Created at 1 week ago

Revert "Revert "kates: Implement a kubectl apply-like function""

This reverts commit b613384a2e8b3c911615c1ef049c4150043da736.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "pkg/kubeapply: Transition to use pkg/kates rather than pkg/k8s""

This reverts commit 0138a10be7c873b6af22943c14c2dd585e6d12fb.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "kubeapply: Do a better job of waiting for CRDs""

This reverts commit a4ae83e8dd9c97a2ed5da6c4c04f07f20f36af19.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "Kill off pkg/k8s""

This reverts commit c9a6559099ee9f93395f311e0f740cf37a2c13d9.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Revert "Revert "Kill off pkg/dtest""

This reverts commit 346d6f1ba2804c1a3cc6fd8378cab7c5b1bd75ba.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Created at 1 week ago
pull request opened
Lukeshu/kubeapply

Description

A few sentences describing the overall goals of the pull request's commits.

Related Issues

List related issues.

Testing

A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.

Checklist

  • [ ] Does my change need to be backported to a previous release?

    • What backport versions were discussed with the Maintainers in the Issue?
  • [ ] I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • [ ] This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • [ ] My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • [ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

  • [ ] The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Created at 1 week ago
LukeShu create branch lukeshu/kubeapply
Created at 1 week ago
pull request opened
[v2.5] Don't check `vendor/` in to Git

Description

This is a backport of https://github.com/emissary-ingress/emissary/pull/4475

Related Issues

  • https://github.com/emissary-ingress/emissary/pull/4475

Testing

CI worked?

Checklist

  • [x] Does my change need to be backported to a previous release?

    • What backport versions were discussed with the Maintainers in the Issue?
  • [ ] I made sure to update CHANGELOG.md. - no applicable changes

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • [ ] This is unlikely to impact how Ambassador performs at scale. - not a runtime change

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • [ ] My change is adequately tested. - yes

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • [ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently. - no tricks

  • [ ] The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Created at 1 week ago
LukeShu create branch lukeshu/v2.5-no-vendor
Created at 1 week ago

.mailmap: Results of reaching out to former employees on LinkedIn

Signed-off-by: Luke Shumaker lukeshu@datawire.io

.mailmap: Results of reaching out to outside contributors via email

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Created at 2 weeks ago
delete branch
LukeShu delete branch lukeshu/leaving
Created at 2 weeks ago
pull request opened
CODEOWNERS.md: Remove myself

As stated in last week's meeting, I'm moving on from Ambassador Labs and don't anticipate being involved with Envoy Gateway going forward.

Created at 2 weeks ago
create branch
LukeShu create branch lukeshu/leaving
Created at 2 weeks ago
Improve the dependabot configuration

v2:

diff --git a/.github/workflows/dependabot.yml b/.github/workflows/dependabot.yml
index 6e4d33142..248631ad1 100644
--- a/.github/workflows/dependabot.yml
+++ b/.github/workflows/dependabot.yml
@@ -12,11 +12,10 @@ name: dependabot
       - 'dependabot/**'
 
 jobs:
-  repatriate:
+  generate:
     runs-on: ubuntu-latest
-    name: repatriate
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - name: Install Deps
@@ -38,4 +37,4 @@ jobs:
           fi
 
           git commit --signoff --message='make go-mod-tidy && make generate'
-          git push origin
+          git push origin HEAD:${{ github.ref }}
Created at 2 weeks ago

dependabot: Don't forget to run make generate

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Created at 2 weeks ago

.github: Drop setting K3D_CLUSTER_NAME

K3D_CLUSTER_NAME has been broken fo a while, so setting it evidently didn't matter.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

make ci/setup-k3d: Fix K3D_CLUSTER_NAME

The prior commit stops CI from using this toggle, but it's still useful for local dev; so fix it.

Signed-off-by: Luke Shumaker lukeshu@datawire.io

.github: Simplify calls to gh auth login

Signed-off-by: Luke Shumaker lukeshu@datawire.io

Merge pull request #4696 from emissary-ingress/lukeshu/ci-tidy

Misc minor CI tidy-up

Created at 2 weeks ago
LukeShu delete branch lukeshu/ci-tidy
Created at 2 weeks ago