KacerCZ
Repos
19
Followers
1

Events

closed issue
Missing space (typo) in PHPStan section

Apache NetBeans version

Apache NetBeans 14

What happened

Missing space (typo) in PHPStan section, after the word "path".

Screenshot attached: 3BwHjLX0tS

How to reproduce

Visit the section

Did this work correctly in an earlier version?

No / Don't know

Operating System

Windows

JDK

Not relevant

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

No response

Are you willing to submit a pull request?

No

Code of Conduct

Yes

Created at 2 months ago
issue comment
Missing space (typo) in PHPStan section

Fix was merged and will be part of NetBeans 15.

Created at 2 months ago
delete branch
KacerCZ delete branch phpstan-config-typo
Created at 2 months ago
issue comment
Missing space (typo) in PHPStan section

Thanks for your report.

I've created fix PR.

Created at 2 months ago

[NETBEANS-4044] Attempting to fix handling of patches for modular libraries.

Let iterate() initialize the indexer first.

Bugfix #4366: Handle references to other compilation units.

Adding test.

Attempting to fix test data compilation on JDK 8.

Add minimal support for Gradle default version catalog

NEON - added FlatLaf Dark specific colors to improve legibility

Merge pull request #4384 from sdedic/java/call-hierarchy-fix

#4366: Handle references to other compilation units.

Merge pull request #4383 from sdedic/maven/indexer-npe

Let iterate() initialize the indexer first.

Increment spec versions for Apache NetBeans 16 development.

Merge pull request #4395 from neilcsmith-net/spec-versions-nb160

Increment spec versions for Apache NetBeans 16 development.

modify output encoding fallack behavior to match JEP400

Merge pull request #4396 from duoduobingbing/infer-encoding-according-to-jep400

Change output encoding fallback behavior to account for JEP400

Merge pull request #4391 from jlahoda/NETBEANS-4044

[NETBEANS-4044] Fixing patching of modular libraries

Update issue forms for 15 release candidates.

Add Apache NetBeans 15 release candidate as version option. Change "No" to "No / Don't know" in options for working in earlier versions. Update feature request form to remove checkboxes.

Merge pull request #4401 from apache/delivery

Sync delivery to master after 15-rc1

Merge pull request #4409 from neilcsmith-net/issues-nb15rc

Update issue forms for 15 release candidates.

Created at 2 months ago
pull request opened
PHPStan - fixes typo in config panel and updates config file name

Use configuration file "phpstan.dist.neon" instead of "phpstan.neon.dist" because the former is opened as NEON file in NetBeans. Both configuration files are supported by PHPStan. See https://phpstan.org/config-reference#config-file

Fixes #4426

Created at 2 months ago
create branch
KacerCZ create branch phpstan-config-typo
Created at 2 months ago
delete branch
KacerCZ delete branch neon-flatlaf-dark-colors
Created at 2 months ago
pull request opened
NEON - added FlatLaf Dark specific colors to improve legibility

Changed colors of valued block, reference and number to improve legibility when using FlatLaf Dark color profile.

Before: before

After: after

Created at 2 months ago
create branch
KacerCZ create branch neon-flatlaf-dark-colors
Created at 2 months ago

Disable flaky ValidateLayerConsistencyTest

See https://github.com/apache/netbeans/issues/4211 for details

Avoid NPE in ant module suite's "Project Properties" dialog. "ProjectNav > some-module-suite > properties > Libraries" when "/nbproject/platform.properties" has "cluster.path=... /target/nbm/clusters/extra"

Recursively print type parameter's type parameters.

Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions

Default value of userdir set to local.

added tests to org.openide.util.xml.XMLUtil: methods with 100% coverage: toElementContent - found 1 redundant 'if' statement which always evaluates true findSubElement appendChildElement copyDocument - found 1 redundant 'if' statement which always evaluates true toAttributeValue checkContentCharacters findElement fromHex checkAttributeCharacter toHex findText

Improve performance of JS implementation of AlternativeLocationImpl

#getStringLocation reads the original file, but is called from the EDT, so invocations must be kept to a minimum. What is more the method is used by #compareTo and thus is potentially called often.

Two optimisations are applied:

  • the result of #getStringLocation is cached and only calculated once
  • #compareTo was rewritten to use the relative path and offset directly. Before relative path and the line number was used to create an ordering, as offset and line number are related, switching for ordering shoud have no outside result

Invoke indexer in RepositoryUpdater grouped by mimepath of file

While analysing this it was found, that the GsfParserFactory#createParser returned null as the parser for snapshots. Looking deeper, showed, that the #createParser method was invoked with snapshots of differing mimetypes.

This works, but is a violation of the contract in ParserFactory#createParser:

It is guaranteed that all snapshots in the collection will be of the same mime type and it will be the mime type, which this factory was registered for (ie. in MimeLookup)

If the snapshots are inconsistent, parsing still works, but its performance suffers. To fix this the call to ParserManager#parse in RepositoryUpdater is split. The scanned sources are grouped by their mimepath and each group is individually passed.

The observed improvements are:

Indexing Variant 1 (tour-of-heroes)

Before: ~125s After: ~105s

Indexing Variant 2 (tour-of-heros with Indexability Filter)

Before: ~52s After: ~38s

The Indexability Filter blocks scanning for all paths with paths containing node_modules and where the indexer is in the list: js, angular, requirejs, knockoutjs, TLIndexer, tests.

add maven 3.8.6

Cleanup warnings related to raw type list.. (#4331)

This pull request attempts to cleanup a lot of the warnings related to raw type list..

[repeat] /home/bwalker/src/netbeans/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/DefaultTabDataModel.java:377: warning: [unchecked] unchecked call to toArray(T[]) as a member of the raw type List [repeat] lde.setAffectedItems((TabData[]) affected.toArray(new TabData[0])); [repeat] ^ [repeat] where T is a type-variable: [repeat] T extends Object declared in method toArray(T[])

I was able to reduce the warnings in half. Of the remaining ones, the majority are related to a generated file. The few remaining ones are going to require some real work.

Merge pull request #4313 from matthiasblaesing/js_goto_declaration

Improve performance of JS implementation of AlternativeLocationImpl

Merge pull request #4273 from nbauma109/patch-4243

Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions…

Updating to codesnippetdoclet 0.82 that works on JDK-11

Using JEP-413 tags in platform and ide clusters

FlatLAF improvements and new configuration properties See the Pull Request for screenshots and links to related discussion/PRs.

Visual improvements, annotated in screenshot in Pull Request:

  1. Align and connect borders between tabs and the container panel below, including on fractional HiDPI scalings (e.g. 150%). Some visual artifacts still exist, e.g. on 125% scaling, but they are less common, and not very visible.
  2. Remove an unnecessary border around the editor area.
  3. Make sure the "X" in editor tabs are closer to the label than to the separator line.
  4. Add some top/bottom margin in the toolbar
  5. On FlatLAF Dark, make the tab background color connect with the background of the Project/Files/Services and Navigator panes.
  6. Slightly decrease the height of regular tab components.

Other visual improvements:

  • On FlatLAF Dark and Light, make the tab hover effect more subtle. Avoid showing a hover effect on the already-selected tab. Use the blueish active tab area background as a base for this color, rather than plain gray.
  • Fix positioning of "spinner" icon in sidebar tabs (see illustration in PR 2967, which did the same on the Windows LAF).
  • Properly clip editor tab borders when tab is partially invisible due to tab scrolling.

New configuration settings for FlatLAF.properties

  • EditorTab.selectedBackgroundBottomGradient (Not used in the current theme, but was tested.)
  • Add ViewTab/EditorTab.unscaledBorders (Not used in the current FlatLAF theme, but is used in the Windows LAF.)
  • EditorTab/ViewTab.selectedHoverBackground/selectedHoverForeground (Tweaks in these commits make use of selectedHoverBackground.)
  • ViewTab/EditorTab.showSelectedTabBorder (Used to explicitly enable borders around the selected tab.)

Use JEP-413 @snippet tag in ideext, java and groovy clusters

ElementUtilities performance optimization.

  • based on the original patch contributed by Michael Zucchi (@notzed), see NETBEANS-6504 or #4140
  • avoids redundant calls to c.s.t.javac.util.Name.toString since the String is recomputed on each call
  • smarter lookup by using a HashMap and ArrayList buckets
  • affects getMembers(), getLocalMembersAndVars(), getLocalVars() and getGlobalTypes()
  • some other minor improvements and cleanup to ElementUtilites
  • added tests for getMembers() and getGlobalTypes()
  • see next followup commits for ordering and more cleanup

This significantly improves auto completion performance on types with thousands of fields. Since

Co-Authored-By: Michael Zucchi notzed@gmail.com

Only allow JEP-413 @snippet syntax

language level cleanup + use ALL_ACCEPTOR instead of null checks.

don't assume QuickPickItem list is sorted.

Created at 2 months ago
issue comment
"Find usages" on a PHP class constructor does not find uses of alias classes

Bug is reproducible. Thanks for your report.

Created at 2 months ago
issue comment
JS parsing bug: "this" not declared

Reproducible also in NetBeans 14. Thanks for your report.

Created at 2 months ago
issue comment
CSS: min-width: auto => Unexpected character(s) "auto" found

Reproducible. Thanks for your report.

Created at 2 months ago

Update FlatLaf from 2.1 to 2.3

Alter FlatLaf tab colouring to address focus / selected visibility issues.

Improve colour contrast between tabs and background. Move accent colour (underline) to top of tabs and extend border up tab sides. Make view tabs active / selected behaviour same as editor tabs. Don't paint view tab separators around selected tab when different selected background colour set.

Merge pull request #4286 from neilcsmith-net/flatlaf-colours

Alter FlatLaf tab colouring to address focus visibility.

Merge pull request #4298 from DevCharly/flatlaf-2.3

Update FlatLaf from 2.1 to 2.3

Created at 2 months ago

[jackpot] improved autoboxing optimization rules

  • Boxed.valueOf() -> Boxed.parsetype (and vise versa) refactoring rule.
  • Extracted 'new Boxed($v)' -> 'Boxed.valueOf($v)' to its own rule.
  • added triggers for missing overloaded method variants.
  • removed overlapping rules.
  • added return from method/lambda case.
  • added tests

Implemnted --direct-disable module option.

Fixes unhandled ExpressionArrayAccess in PHP Editor

Merge pull request #3240 from mbien/valueof

[jackpot] Updates to autoboxing inspections

Java Record - changed state_component to record_component (#4293)

  • changed state_component to record_component

Merge pull request #4301 from sdedic/platform/direct-disable-option

Implemnted --direct-disable module option.

Git: Replace invalid chars in branch name when creating a new branch

ci: xserver for commit validation matrix.

enable xserver for for all JDKs except 19-ea due to:

NPE in org.netbeans.modules.ide.kit.VerifySimpleTemplatesTest Caused: java.lang.NullPointerException: Cannot read field "tsym" because "imp.qualid.selected.type" is null

see #4299

fix NPEs in UI code during commit validation tests.

example: java.lang.NullPointerException: Cannot invoke "java.awt.Component.getBackground()" because the return value of "javax.swing.JViewport.getView()" is null

Merge pull request #4233 from mbien/ci-headful-cv

ci xserver for commit validation matrix

Merge pull request #4306 from troizet/git_replace_invalid_characters_in_branch_name

Git: replace invalid characters in branch name

Use the copy constructor when that all one needs. Avoid using reflection and creating a clone as it can be expensive. (#4325)

Warnings like this are cleaned up..

[repeat] /home/bwalker/src/netbeans/platform/openide.nodes/src/org/openide/nodes/Children.java:1783: warning: [rawtypes] found raw type: Dupl [repeat] Dupl d = (Dupl) this.clone(); [repeat] ^ [repeat] missing type arguments for generic class Dupl [repeat] where T is a type-variable: [repeat] T extends Object declared in class Dupl

Also, cleanup some improper usage of emptyList() and it's friends.

LSPClient: Don't assume URL -> FileObject mapping exists

While working with a typescript project, I multiple times copied files, renamed, edited and closed them. I noticed, that I got a NullPointerException from the LanguageClientImpl:

java.lang.NullPointerException: Cannot invoke "org.openide.filesystems.FileObject.getLookup()" because "file" is null at org.netbeans.modules.lsp.client.bindings.LanguageClientImpl.publishDiagnostics(LanguageClientImpl.java:161) Caused: java.lang.reflect.InvocationTargetException at jdk.internal.reflect.GeneratedMethodAccessor159.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.lambda$null$0(GenericEndpoint.java:65) Caused: java.lang.RuntimeException at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.lambda$null$0(GenericEndpoint.java:67) at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.notify(GenericEndpoint.java:152)

This looks like a race condition between the LSP server reporting diagnostics and the URLMapper being updated or the LSP server reporting diagnostics after the file was already closed.

LanguageClientImpl#publishDiagnostics already guards against missing EditorCookies and Documents, so this change just expands this to the FileObject itself.

remove jdk18 reflection calls and updated the usages (#4012)

  • remove jdk18 reflection calls and updated the usages

Merge pull request #4327 from matthiasblaesing/lsp_client_improvement

LSPClient: Don't assume URL -> FileObject mapping exists

Merge pull request #4308 from KacerCZ/php-expression-array-access-fix

Fixes unhandled ExpressionArrayAccess in PHP Editor

Created at 2 months ago
delete branch
KacerCZ delete branch php-expression-array-access-fix
Created at 2 months ago
issue comment
Fixes unhandled ExpressionArrayAccess in PHP Editor

Thank you.

Created at 2 months ago