Jean85
Repos
118
Followers
199
Following
21

Run PHPUnit tests in parallel

115
12

A small, independent wrapper to get pretty versions strings

1132
13

The official PHP SDK for Sentry (sentry.io)

1657
405

The official Symfony SDK for Sentry (sentry.io)

609
140

Standards either proposed or approved by the Framework Interop Group

12356
2380

Facile.it Engineering Blog

14
12

Events

issue comment
[Messenger] ErrorDetailsStamp +RedeliveryStamp can lead to an oversize message for SQS

btw: i am surprised that the amqp library allows to send messages that break the system, they could check the header limit on sending as well and not only on receiving...

That's not what's happening: envelope gets bigger before getting sent back again, and goes over the limit.

Created at 11 hours ago
issue comment
Show skipped tests messages with `--verbose`

Another suggestion: https://github.com/johnkary/phpunit-speedtrap

Created at 1 day ago
issue comment
Add tracePropagationTargets option

What should tracePropagationTargets do? We can't do anything "automagically" in the base PHP SDK... Maybe it's feasible in the framework integrations, on the framework-provided clients.

Created at 2 weeks ago
PdoException is not catched

Thank you for opening the PR, but this is unmergeable without tests, a green build and a changelog entry.

Created at 2 weeks ago
Event System for extending PHPUnit

@sebastianbergmann this closing means that the event system is now stable? I saw that you heavily refactored it, creating a distinction between outcomes and other events (good choice!), is that permanent now? Can we start building on top of that?

Created at 3 weeks ago
Jean85 delete branch patch-1
Created at 3 weeks ago
Improve user_identity_field deprecation message

Thank you for the fast merge!

Created at 3 weeks ago
Improve user_identity_field deprecation message

This should fix #1051

Created at 3 weeks ago
Improve user_identity_field deprecation message

As discovered in https://github.com/lexik/LexikJWTAuthenticationBundle/issues/1051#issuecomment-1239327663

Created at 3 weeks ago

Improve deprecation message

As discovered in https://github.com/lexik/LexikJWTAuthenticationBundle/issues/1051#issuecomment-1239327663

Created at 3 weeks ago
Deprecation : user_identity_field - improve defaults or deprecation message

It worked, thanks! So, this issue could be fixed by changing the deprecation message from

The "lexik_jwt_authentication.user_identity_field" configuration key is deprecated since version 2.15, implement "Symfony\Component\Security\Core\User\UserInterface::getUserIdentifier()" instead.

to

The "lexik_jwt_authentication.user_identity_field" configuration key is deprecated since version 2.15, use "lexik_jwt_authentication.user_id_claim" or implement "Symfony\Component\Security\Core\User\UserInterface::getUserIdentifier()" instead.

right?

Created at 3 weeks ago
Symfony 6 support?

I am unable to upgrade a Symfony 5.4 project to Symfony 6.0 due to it using sentry/sentry-symfony

Checking for deprecation notices gives the following notice:

2x: The "Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverForV3" class implements "Doctrine\DBAL\VersionAwarePlatformDriver" that is deprecated All drivers will have to be aware of the server version in the next major release. 2x in DeprecationErrorHandler::shutdown from Symfony\Bridge\PhpUnit

Created at 3 weeks ago
issue comment
Symfony 6 support?

You can disregard those deprecations, they are not related to Symfony but to DBAL. In any case, we are unable to solve them, since we need to be compatible with both DBAL v2 and v3. See also #483

Created at 3 weeks ago
Deprecation : user_identity_field - improve defaults or deprecation message

I just stumbled in this same exact problem. I'm on SF 5.4 and I wanted to get rid of this exact deprecation.

To fix it I removed the user_identity_field: token setting, and reworked my custom user like this:

class FrontendUser extends JWTUser
{
    public static function createFromPayload($username, array $payload): self
    {
        return parent::createFromPayload($payload['token'], $payload);
    }
}

This should've been enough to fix it, but it's currently failing because of this piece of code: https://github.com/lexik/LexikJWTAuthenticationBundle/blob/d7cbef600712eb57af7cafd28130985553b50b37/Security/Authenticator/JWTAuthenticator.php#L120-L123

I could send a PR to skip this piece if $idClaim === null, but the config doesn't accept null as a value; also, UserInterface::getUserIdentifier could be called only afterwards the user is already fetched which, depending on the config, could involve a DB query.

So... how can we solve this?

Created at 3 weeks ago

Update submodule (new election results and much more)

Created at 3 weeks ago

Update the personell page with new elections

Merge pull request #1286 from jaapio/update_personell

Update the personell page with new elections

Created at 3 weeks ago
pull request closed
Update the personell page with new elections

I'm not sure if I'm supposed to do this, however, this document seemed to be outdated.

I added 2 years for all people mentioned for re-election. And added me and Navarr to the list of core committee members.

Created at 3 weeks ago
issue comment
Add auto-discovery of popular PHP frameworks

@cleptric we could simply measure the overhead of ModulesIntegration just to play it safe and if it is really low, I say we enable it by default to unify it with other SDKs.

Keep in mind to test it against Composer v1 AND v2, the inner workings are widely different.

Created at 3 weeks ago
issue comment
Add auto-discovery of popular PHP frameworks

@Jean85 We had a customer reach out and report similar issues as in https://github.com/getsentry/sentry-php/pull/1008. So you updated your package to work with Composer v1/v2 out of the box?

We support both: https://github.com/getsentry/sentry-php/blob/master/composer.json#L28

See https://github.com/jean85/pretty-package-versions#compatibility If you used v2 at any point, it upgraded that package to v2. If you go back to v1, you need to downgrade it to 1.5; I normally see this issue when there's poor dev environment hygiene, and so Composer updates go wrong.

Created at 4 weeks ago
issue comment
Add auto-discovery of popular PHP frameworks

@cleptric what do you mean? We do... Do you have issues using it?

Created at 4 weeks ago