IndraGunawan
Repos
83
Followers
53
Following
10

Rate limits protection for api-platform resources.

62
8

Support Facades for Symfony service

17
1

Creates Packagist.org mirror site.

32
3

Sequence implementation for Symfony Framework

5
4

Events

minor #46542 [Mailer] Sort transports alphabetically (OskarStark)

This PR was merged into the 5.4 branch.

Discussion

[Mailer] Sort transports alphabetically

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Spotted in #46211 | License | MIT | Doc PR | -

So the sorting does not needs to be done in #46211

cc @B-Galati

Commits

5d76dbb3cd [Mailer] Sort transports alphabetically

[WebProfilerBundle] Fix dark theme selected line highlight color & reuse css vars

[Serializer][WebProfilerBundle] Show serializer collector info in toolbar

[Serializer][WebProfilerBundle] Collect & show caller source code

Fix dark theme highlight color & reuse css vars

bug #46565 [WebProfilerBundle] Fix dark theme selected line highlight color & reuse css vars (ogizanagi)

This PR was merged into the 4.4 branch.

Discussion

[WebProfilerBundle] Fix dark theme selected line highlight color & reuse css vars

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A

When using the profiler with a dark theme, the Messenger panel was missing using the dedicated vars and was still using a light bg:

Capture d’écran 2022-06-03 à 09 56 42

and the selected lines on file excerpts (for any panel) are not contrasted enough:

Capture d’écran 2022-06-03 à 09 56 57

I suggest using a more contrasted highlight color for selected lines:

Capture d’écran 2022-06-03 à 09 56 07

Commits

5514bdf487 [WebProfilerBundle] Fix dark theme selected line highlight color & reuse css vars

[Console] Escape % in command name & description from getDefault*()

[Serializer] Fix ignore attribute in Xml files

[Security] Enforce maximum username length

Improve DE translations for Form/Validator

minor #46578 Improve DE translations for Form/Validator (sandoba)

This PR was squashed before being merged into the 4.4 branch.

Discussion

Improve DE translations for Form/Validator

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | not needed

A few changes to the German translations of the Form and Validator components.

Commits

8989377e3c Improve DE translations for Form/Validator

feature #46094 [Security][SecurityBundle] Move the Security helper to SecurityBundle (chalasr)

This PR was merged into the 6.2 branch.

Discussion

[Security][SecurityBundle] Move the Security helper to SecurityBundle

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | yes | Tickets | Fixes https://github.com/symfony/symfony/pull/46066#issuecomment-1100756367 | License | MIT | Doc PR | todo

The Security helper is a high-level service providing an easy access to commonly-needed features coming from various low-level abstractions. Basically, it's a facade. Based on this, it makes sense to me to make it available only via the full-stack framework, as proposed by Wouter in https://github.com/symfony/symfony/pull/46066#issuecomment-1100756367.

This unlocks #46066, https://github.com/symfony/symfony/pull/41274 and https://github.com/symfony/symfony/pull/41406. /cc @wouterj @johnkrovitch @Kocal

Commits

7b91bcb068 [Security] Move the Security helper to SecurityBundle

bug #46577 [Serializer] Fix ignore attribute in Xml files (alamirault)

This PR was merged into the 5.4 branch.

Discussion

[Serializer] Fix ignore attribute in Xml files

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46463 | License | MIT

Before this PR foo was ignored. Now it is not.

<class name="Symfony\Component\Serializer\Tests\Fixtures\Annotations\IgnoreDummy">
    <attribute name="foo" ignore="false" />
</class>

Instead of cast we now use XmlUtils::phpize like others XmlLoaders.

Commits

6cdcb1bb94 [Serializer] Fix ignore attribute in Xml files

feature #46569 [Serializer][WebProfilerBundle] Collect & show caller source code (ogizanagi)

This PR was squashed before being merged into the 6.2 branch.

Discussion

[Serializer][WebProfilerBundle] Collect & show caller source code

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A

As for the Messenger and Validator panels, knowing from which code was called the Serializer's methods and jumping to it in one click is useful to get a better understanding of each collected rows and their context.

Capture d’écran 2022-06-03 à 09 32 00

Capture d’écran 2022-06-03 à 09 46 43

Capture d’écran 2022-06-03 à 10 34 26


the second commit relates to https://github.com/symfony/symfony/pull/46565

Commits

0a2071242f Fix dark theme highlight color & reuse css vars 83412d2136 [Serializer][WebProfilerBundle] Collect & show caller source code

feature #46566 [Serializer][WebProfilerBundle] Show serializer collector info in toolbar (ogizanagi)

This PR was merged into the 6.2 branch.

Discussion

[Serializer][WebProfilerBundle] Show serializer collector info in toolbar

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A

Capture d’écran 2022-06-03 à 10 22 41

The numbers themselves are, most of the time, not much important, but knowing the serializer was called and which methods at a glance is helpful and allows to link directly to the Serializer panel.

Commits

130e064f46 [Serializer][WebProfilerBundle] Show serializer collector info in toolbar

[HttpKernel] Fix BackedEnumValueResolver already resolved enum value

bug #46574 [Console] Escape % in command name & description from PHP (getDefault* methods) (ogizanagi)

This PR was merged into the 5.4 branch.

Discussion

[Console] Escape % in command name & description from PHP (getDefault* methods)

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46560 | License | MIT | Doc PR | N/A

If the fix is ok to you, we should backport the getDefaultName part to 4.4 as well (even if using a % should be far less common in the name/aliases…)

Commits

7b6a485624 [Console] Escape % in command name & description from getDefault*()

[FrameworkBundle] Fix XML cache config

[Console] Escape % in command name & description from getDefault*()

[Console] Prevent PHP 8.1 str_replace deprec on null

Prevents:

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated

on getDefaultName() returning null

Created at 1 month ago
Created at 2 months ago
issue comment
[BUG] salt-minion 3004 upgrade from salt-master produces "The renderer jinja|yaml is unavailable"

atlantis plan

Created at 2 months ago

remove unneeded inputs

Created at 2 months ago
create branch
IndraGunawan create branch missing-composite-input
Created at 2 months ago
delete branch
IndraGunawan delete branch composite-input-missing
Created at 2 months ago
pull request closed
Fix missing composite inputs
Created at 2 months ago
pull request opened
Fix missing composite inputs
Created at 2 months ago
create branch
IndraGunawan create branch composite-input-missing
Created at 2 months ago
Created at 2 months ago

docs: fix code-block

Signed-off-by: Indra Gunawan indra@propertyguru.com.sg

Created at 2 months ago

docs: fix code-block

Signed-off-by: Indra Gunawan indra@propertyguru.com.sg

Created at 2 months ago
docs: sync slack integration docs

Signed-off-by: Indra Gunawan indra@propertyguru.com.sg

Created at 2 months ago
IndraGunawan create branch sync-docs
Created at 2 months ago
pull request opened
docs: fix code-block

Signed-off-by: Indra Gunawan indra@propertyguru.com.sg

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [x] My build is green (troubleshooting builds).
Created at 2 months ago
create branch
IndraGunawan create branch fix-docs
Created at 2 months ago
delete branch
IndraGunawan delete branch fix-docs
Created at 2 months ago
create branch
IndraGunawan create branch fix-docs
Created at 2 months ago
Created at 2 months ago