HypeMC
Repos
24
Followers
7
Following
1

Symfony bundle which provides a way to version your application using various versioning strategies

3
1

Logs the output into a file by dynamically creating a dedicated Monolog file handler for each Symfony command or message handler

2
0

Provides a simple way to mock built-in PHP functions in PHPUnit tests

0
0

Events

create branch
HypeMC create branch enums-in-simpleobjecthydrator.x
Created at 2 days ago
create branch
HypeMC create branch enums-in-simpleobjecthydrator
Created at 2 days ago
issue comment
[Mime] Form field values with integer keys not resolved correctly

Could you, please, elaborate, what exactly is undoing? Could you give an example of valid data part(s) that is no more possible with this MR? I think having two distinct foo[0], with two different values, in the same time is not valid. That's because of the numeric index. But, yes, having two parts named foo it should be OK.

@claudiu-cristea Actually, it depends on how the application you are browsing works. In the past, I have worked with some apis that support having the same form filed multiple times with different values, or even the same query string param multiple times. An example of a valid data part that doesn't work any more:

        $parts[] = $p14 = clone $p1;
-       $p14->setName('quuz2[corge]');
+       $p14->setName('quuz2[0][corge]');
        $parts[] = $p15 = clone $p1;
-       $p15->setName('quuz2[corge]');
+       $p15->setName('quuz2[1][corge]');
Created at 2 days ago
delete branch
HypeMC delete branch change-set-calculation-with-enums.x
Created at 2 days ago
pull request opened
Fix change set computation with enums

Fixes #10071 , uses test cases from #10073 by @mzk

My attempt at solving the issue. The ReflectionEnumProperty::getValue() method returns the value of the enum, while some hydrators pass an enum object in the data set to the UnitOfWork::$originalEntityData array.

The SimpleObjectHydrator doesn't convert strings into enums, while the ObjectHydrator (or to be more precise the AbstractHydrator::gatherRowData() method) does. Even though this doesn't seem to be causing any issues, the inconsistency seems unintentional to me, so if you think it should be fixed please let me know and I'll open a PR.

Created at 2 days ago
delete branch
HypeMC delete branch change-set-calculation-with-enums
Created at 2 days ago
create branch
HypeMC create branch change-set-computation-with-enums
Created at 2 days ago
push

Fix change set computation with enums

Created at 2 days ago
create branch
HypeMC create branch change-set-calculation-with-enums
Created at 2 days ago
create branch
HypeMC create branch change-set-calculation-with-enums.x
Created at 2 days ago

Enhancement: Use no_trailing_comma_in_singleline instead of deprecated fixers

Merge branch '8.5' into 9.5

Merge branch '9.5'

Mark properties as readonly

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Mark classes as immutable

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Delete superfluous code

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Delete code that is no longer needed

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

This is not yet immutable

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Mark properties as readonly

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Mark classes as immutable

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Mark classes as internal

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Remove superfluous import

This is not immutable

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Update Psalm baseline

Remove information from TestSuite value object we do not really need

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Remove actual data set data, only include data set name

Simplify

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Closes #5052

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Update Psalm baseline

Throw correct exception

Co-authored-by: Sebastian Bergmann sb@sebastian-bergmann.de Co-authored-by: Arne Blankerts arne@blankerts.de Co-authored-by: Andreas Möller am@localheinz.com

Created at 3 days ago
create branch
HypeMC create branch named-testwith-datasets-test
Created at 3 days ago
opened issue
OrderAttributesRector duplicates docblocks

Bug Report

| Subject | Details | | :------------- | :---------------------------------------------------------------| | Rector version | v0.14.3

In certain cases the docblock gets duplicated when using the OrderAttributesRector.

Minimal PHP Code Causing Issue

<?php

namespace Rector\Tests\CodingStyle\Rector\ClassMethod\OrderAttributesRector\AlphabeticallOrder\Fixture;

use Rector\Tests\CodingStyle\Rector\ClassMethod\OrderAttributesRector\AlphabeticallOrder\Source\AAttribute;
use Rector\Tests\CodingStyle\Rector\ClassMethod\OrderAttributesRector\AlphabeticallOrder\Source\BAttribute;

/**
 * Some comment
 */
#[BAttribute]
#[AAttribute]
class Someclass
{
}

?>

Expected Behaviour

<?php

namespace Rector\Tests\CodingStyle\Rector\ClassMethod\OrderAttributesRector\AlphabeticallOrder\Fixture;

use Rector\Tests\CodingStyle\Rector\ClassMethod\OrderAttributesRector\AlphabeticallOrder\Source\AAttribute;
use Rector\Tests\CodingStyle\Rector\ClassMethod\OrderAttributesRector\AlphabeticallOrder\Source\BAttribute;

/**
 * Some comment
 */
#[AAttribute]
#[BAttribute]
class Someclass
{
}

?>

Actual Behaviour

<?php

namespace Rector\Tests\CodingStyle\Rector\ClassMethod\OrderAttributesRector\AlphabeticallOrder\Fixture;

use Rector\Tests\CodingStyle\Rector\ClassMethod\OrderAttributesRector\AlphabeticallOrder\Source\AAttribute;
use Rector\Tests\CodingStyle\Rector\ClassMethod\OrderAttributesRector\AlphabeticallOrder\Source\BAttribute;

/**
 * Some comment
 */
#[AAttribute]
/**
 * Some comment
 */
#[BAttribute]
class Someclass
{
}

?>
Created at 5 days ago
Created at 5 days ago
Created at 5 days ago
delete branch
HypeMC delete branch enum-with-query-builder-fix
Created at 6 days ago
delete branch
HypeMC delete branch named-testwith-datasets-test
Created at 1 week ago

Update tools

Merge branch '8.5' into 9.5

Merge branch '9.5'

Be paranoid

Finalize public methods of PHPUnit\Framework\Assert and PHPUnit\Framework\TestCase

Use never return type declaration instead of never-return type annotation

Update Psalm baseline

Remove superfluous cast

Return early

Emit correct event when a depended-upon test class does not exist

Emit correct event when an expectation on output fails

Emit correct event when a PHPT test is skipped

Be consistent with regular tests and emit a Test Finished event after a PHPT test has been skipped

Create namespace for test fixture used by end-to-end event tests

Test that the right events are emitted in the right order for when an exception is raised in setUp()

Refactor

Initial work on Test\BeforeFirstTestMethodErrored event

Emit the right events in the right order when an exception is raised in setUpBeforeClass()

A test that was run in a child process that ended unexpectedly should be treated as an error, not as a failure

Emit correct event when a test that was run in a child process that ended unexpectedly

Created at 1 week ago
create branch
HypeMC create branch named-testwith-datasets-test
Created at 1 week ago

Update tools

Merge branch '8.5' into 9.5

Merge branch '9.5'

Be paranoid

Finalize public methods of PHPUnit\Framework\Assert and PHPUnit\Framework\TestCase

Use never return type declaration instead of never-return type annotation

Update Psalm baseline

Remove superfluous cast

Return early

Emit correct event when a depended-upon test class does not exist

Emit correct event when an expectation on output fails

Emit correct event when a PHPT test is skipped

Be consistent with regular tests and emit a Test Finished event after a PHPT test has been skipped

Create namespace for test fixture used by end-to-end event tests

Test that the right events are emitted in the right order for when an exception is raised in setUp()

Refactor

Initial work on Test\BeforeFirstTestMethodErrored event

Emit the right events in the right order when an exception is raised in setUpBeforeClass()

A test that was run in a child process that ended unexpectedly should be treated as an error, not as a failure

Emit correct event when a test that was run in a child process that ended unexpectedly

Created at 1 week ago
delete branch
HypeMC delete branch enum-with-query-builder-fix-test
Created at 1 week ago
push

Fix using enums with the QueryBuilder

Created at 1 week ago
push

Fix using enums with the QueryBuilder

Created at 1 week ago
create branch
HypeMC create branch enum-with-query-builder-fix-test
Created at 1 week ago
push

Fix using enums with the QueryBuilder

Created at 1 week ago
delete branch
HypeMC delete branch 2.11.x
Created at 1 week ago
create branch
HypeMC create branch 2.13.x
Created at 1 week ago
delete branch
HypeMC delete branch enum-in-where-fix-test
Created at 1 week ago