[HttpKernel] Remove private headers before storing responses with HttpCache

[FrameworkBundle] fix: fix typo about help

minor #48672 [FrameworkBundle] fix: fix typo about help (jeremyFreeAgent)

This PR was submitted for the 6.3 branch but it was merged into the 5.4 branch instead.

Discussion

[FrameworkBundle] fix: fix typo about help

| Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR |

I didn't saw that help message was elsewhere 😞.

@see https://github.com/symfony/symfony/pull/48646

Commits

1c44de799d [FrameworkBundle] fix: fix typo about help

[FrameworkBundle] Add Mailpace definition

[Console] Fix a test when pcntl is not available (following #48329)

minor #48694 [Console] Fix a test when pcntl is not available (following #48329) (HeahDude)

This PR was merged into the 5.4 branch.

Discussion

[Console] Fix a test when pcntl is not available (following #48329)

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~

The test is currently failing in AppVeyor (see https://ci.appveyor.com/project/fabpot/symfony/builds/45710392#L1577), the missing check seems present in tests above and below it. Don't know what happened.

Commits

db5ed1f1b1 [Console] Fix a test when pcntl is not available (following #48329)

bug #48688 [FrameworkBundle] Add MailPace definition (skmedix)

This PR was merged into the 6.2 branch.

Discussion

[FrameworkBundle] Add MailPace definition

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? |no | Tickets | - | License | MIT | Doc PR | -

MailPace definition is missing from mailer transports. Because of this, using mailpace+api:// throws The "mailpace+api" scheme is not supported.

Commits

b29ba10afc [FrameworkBundle] Add Mailpace definition

Fix using SYMFONY_IDE in tests

Merge branch '6.1' into 6.2

• 6.1: Fix using SYMFONY_IDE in tests

Compatibility with doctrine/annotations 2

bug #48718 Compatibility with doctrine/annotations 2 (derrabus)

This PR was merged into the 5.4 branch.

Discussion

Compatibility with doctrine/annotations 2

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48717 | License | MIT | Doc PR | N/A

Doctrine Annotations 2 has been released, including the removal of deprecated classes and methods that were still called. Unfortunately, we have never declared a conflict with Annotations 2.

Commits

650f7bd03e Compatibility with doctrine/annotations 2

Fix CS

Merge branch '5.4' into 6.0

• 5.4: Fix CS Compatibility with doctrine/annotations 2 [Console] Fix a test when pcntl is not available (following #48329) [FrameworkBundle] fix: fix typo about help

Merge branch '6.0' into 6.1

• 6.0: Fix CS Compatibility with doctrine/annotations 2 [Console] Fix a test when pcntl is not available (following #48329) [FrameworkBundle] fix: fix typo about help

Merge branch '6.1' into 6.2

• 6.1: Fix CS Compatibility with doctrine/annotations 2 [Console] Fix a test when pcntl is not available (following #48329) [FrameworkBundle] fix: fix typo about help

[SecurityBundle] Prevent RuntimeException "Impossible to access an attribute ("security_enabled") on a null variable."

bug #48735 [SecurityBundle] Prevent RuntimeException on profiler (marphi)

This PR was merged into the 6.2 branch.

Discussion

[SecurityBundle] Prevent RuntimeException on profiler

I've got RuntimeException "Impossible to access an attribute ("security_enabled") on a null variable." on the profiler page on a page without any configured firewall.

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#...

Example: I have a page without any configured firewall. The profiler looks like this:

When I click on "Security" tab. I've got:

This commit fix this issue. Now it looks good:

Commits

59da8361e3 [SecurityBundle] Prevent RuntimeException "Impossible to access an attribute ("security_enabled") on a null variable."

[VarExporter] Generate proxies for static abstract methods

bug #48742 [VarExporter] Generate proxies for static abstract methods (nicolas-grekas)

This PR was merged into the 6.2 branch.

Discussion

[VarExporter] Generate proxies for static abstract methods

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48723 | License | MIT | Doc PR | -

Commits

47fc4d5c84 [VarExporter] Generate proxies for static abstract methods

[Workflow] Allow spaces in place names so the PUML dump doesn't break

[HttpKernel] Remove private headers before storing responses with HttpCache

[Console] Fix a test when pcntl is not available (following #48329)

minor #48694 [Console] Fix a test when pcntl is not available (following #48329) (HeahDude)

This PR was merged into the 5.4 branch.

Discussion

[Console] Fix a test when pcntl is not available (following #48329)

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~

The test is currently failing in AppVeyor (see https://ci.appveyor.com/project/fabpot/symfony/builds/45710392#L1577), the missing check seems present in tests above and below it. Don't know what happened.

Commits

db5ed1f1b1 [Console] Fix a test when pcntl is not available (following #48329)

Compatibility with doctrine/annotations 2

bug #48718 Compatibility with doctrine/annotations 2 (derrabus)

This PR was merged into the 5.4 branch.

Discussion

Compatibility with doctrine/annotations 2

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48717 | License | MIT | Doc PR | N/A

Doctrine Annotations 2 has been released, including the removal of deprecated classes and methods that were still called. Unfortunately, we have never declared a conflict with Annotations 2.

Commits

650f7bd03e Compatibility with doctrine/annotations 2

Fix CS

[Workflow] Allow spaces in place names so the PUML dump doesn't break

bug #48738 [Workflow] Allow spaces in place names so the PUML dump doesn't break (Kamil Musial)

This PR was squashed before being merged into the 5.4 branch.

Discussion

[Workflow] Allow spaces in place names so the PUML dump doesn't break

Remove state alias as not needed and use escaped name for a description

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT

Current PlantUmlDumper implementation doesn't allow states to have a description if state name contains spaces.

Sample definition:

framework:
    workflows:
        test:
           ...
            places:
                - 'place a'
                - 'place b'
            transitions:
                't 1':
                    from: 'place a'
                    to:   'place b'

produces following puml:

state "place a" <<initial>> as place a
place a : My custom place description
state "place b"
agent "t 1"
"place a" --> "t 1"
"t 1" --> "place b"

which contains a syntax error in line state "place a" <<initial>> as place a

A solution is to remove the state alias and use escaped name as a key:

...
state "place a" <<initial>>
"place a" : My custom place description

And then the diagram looks like:

Commits

33bd0fe129 [Workflow] Allow spaces in place names so the PUML dump doesn't break

[Validator] Fix IBAN format for Tunisia and Mauritania

bug #48746 [Validator] Fix IBAN format for Tunisia and Mauritania (smelesh)

This PR was merged into the 5.4 branch.

Discussion

[Validator] Fix IBAN format for Tunisia and Mauritania

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a

IBAN checksum (2 digits after country code) must not be hardcoded since it's calculated based on the rest of the IBAN characters.

Commits

b72f013585 [Validator] Fix IBAN format for Tunisia and Mauritania

[VarExporter] Fix exporting classes with __unserialize() but not __serialize()

bug #48724 [VarExporter] Fix exporting classes with __unserialize() but not __serialize() (fancyweb)

This PR was merged into the 5.4 branch.

Discussion

[VarExporter] Fix exporting classes with __unserialize() but not __serialize()

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | https://github.com/symfony/symfony/issues/48706 indirectly | License | MIT | Doc PR | -

This is an edge case not supported yet, highlighted by our own symfony/expression-language GetAttrNode class.

Commits

6ccb85e185 [VarExporter] Fix exporting classes with __unserialize() but not __serialize()

Use static methods inside data providers

minor #48709 Use static methods inside data providers (OskarStark)

This PR was squashed before being merged into the 5.4 branch.

Discussion

Use static methods inside data providers

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a

refs https://github.com/symfony/symfony/pull/48668

follows

• https://github.com/symfony/symfony/pull/48625

Commits

9a18048d1a Use static methods inside data providers

Update RedisTrait.php

[Cache] RedisTrait::createConnection does not pass auth value from redis sentinel cluster DSN

bug #48711 [Cache] RedisTrait::createConnection does not pass auth value from redis sentinel cluster DSN (evgkord)

This PR was merged into the 5.4 branch.

Discussion

[Cache] RedisTrait::createConnection does not pass auth value from redis sentinel cluster DSN

[Cache] RedisTrait::createConnection does not pass auth value from redis sentinel cluster DSN

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no - bugfix | Deprecations? | no | Tickets | Fix #48712 | License | MIT | Doc PR | none - bugfix

Commits

26ba375701 Update RedisTrait.php

Fix integration test gha

minor #48761 Fix integration test gha (kbond)

This PR was submitted for the 4.4 branch but it was merged into the 5.4 branch instead.

Discussion

Fix integration test gha

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a

This should fix the failing integration tests. grokzen/redis-cluster has de-listed the 5.0.4 tag.

Commits

4a38f23e6c Fix integration test gha

[CssSelector] Fix escape patterns

bug #48771 [CssSelector] Fix escape patterns (fancyweb)

This PR was merged into the 5.4 branch.

Discussion

[CssSelector] Fix escape patterns

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | https://github.com/symfony/symfony/issues/46682 and https://github.com/symfony/symfony/issues/44516 | License | MIT | Doc PR | -

I rechecked the original Python source code we "borrowed" (https://github.com/scrapy/cssselect/blob/master/cssselect/parser.py) and fixed some issues.

Commits

7de8f994a3 [CssSelector] Fix escape patterns

Thank you for merging :) 🎉

| Q | A | |---|---| | Feature PR | https://github.com/symfony/symfony/pull/47719 | | PR Author | @HeahDude | | Merged in | 6.3

but it causes an issue with non-scalar values that get coerced to the same string

Why no using array_unique(..., \SORT_REGULAR) instead?

[Console] Fix clear line with question in section

fix dumping top-level tagged values

[Validator] Update ValidatorBuilder comment for enableAnnotationMapping

[Intl] Add a special locale to strip emojis easily with EmojiTransliterator

[Translation] Fix extraction when dealing with VariadicPlaceholder parameters

Point Security::* constants to SecurityRequestAttributes::* ones

bug #48554 [Security] Fix invalid deprecation messages in Security constants (IonBazan)

This PR was merged into the 6.2 branch.

Discussion

[Security] Fix invalid deprecation messages in Security constants

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

This PR changes invalid deprecation message, suggesting to use \Symfony\Bundle\SecurityBundle\Security::ACCESS_DENIED_ERROR instead of \Symfony\Component\Security\Core\Security::ACCESS_DENIED_ERROR, while \Symfony\Component\Security\Http\SecurityRequestAttributes::ACCESS_DENIED_ERROR should be used.

For reference: #47760

Commits

3fd5a40ef1 Point Security::* constants to SecurityRequestAttributes::* ones

[TwigBundle] Alias BodyRendererInterface

[Translator] Fix typo "internal" / "interval"

minor #48597 [Contracts] Fix typo "internal" / "interval" (Kocal)

This PR was merged into the 5.4 branch.

Discussion

[Contracts] Fix typo "internal" / "interval"

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A

Rename getInternal to getInterval in Translator tests.

Commits

ef8c3cdfd3 [Translator] Fix typo "internal" / "interval"

[SecurityBundle] Fix authenticator existence check in Security::login()

Fix missing command not matching namespace error message

[VarExporter] Fix adding a key to an uninitialized array

bug #48605 [VarExporter] Fix adding a key to an uninitialized array (nicolas-grekas)

This PR was merged into the 6.2 branch.

Discussion

[VarExporter] Fix adding a key to an uninitialized array

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #48562 | License | MIT | Doc PR | -

Commits

57c6a623b3 [VarExporter] Fix adding a key to an uninitialized array

[Console] Fixed typo

Fix getting the name of closures on PHP 8.1.11+

[ErrorHandler][DebugClassLoader] Fix some new return types support

[HttpKernel] fix wrong deprecation message

bug #48608 [HttpKernel] fix wrong deprecation message (soyuka)

This PR was merged into the 6.3 branch.

Discussion

[HttpKernel] fix wrong deprecation message

| Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | License | MIT

Introduced in https://github.com/symfony/symfony/pull/47680

Not sure about how to catch the deprecation.

Commits

6bfc18dfa7 [HttpKernel] fix wrong deprecation message

bug #48618 [ErrorHandler] [DebugClassLoader] Fix some new return types support (fancyweb)

This PR was merged into the 5.4 branch.

Discussion

[ErrorHandler] [DebugClassLoader] Fix some new return types support

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

It looks like we don't advise return types based on the PHP version anymore so let's add true and never (false and null are already there).

We can now advise returning null since it's valid. I treated it as a special case because the nullable logic is complicated :sweat_smile:

Commits

e18c36ade3 [ErrorHandler][DebugClassLoader] Fix some new return types support