775
508
109
⚡️ A library for building performant and instant search experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue
A quarantine-ready Wikipedia game, to be played by two people
Float a number of things up on a page (hearts, flowers, emojis, words ...)
Events
fix(insights): pass clickAnalytics automatically
FX-2191
Update and rename lang/en/index.md to lang/en/kongpcmail/index.md
types are happy again
eslint
HitsPerPage doesn’t work correctly with routeToState()
Bug 🐞
What is the current behavior?
- Use the
ais-hits-per-pagecomponent as described in the docs - Then set up the routing as per the "User-friendly URLs" section detailed here: https://www.algolia.com/doc/guides/building-search-ui/going-further/routing-urls/js/#user-friendly-urls
- Using the widget updates the UI state correctly and also updates the URL
- Reloading the page sets the state correctly but doesn’t update the UI of the widget
Make a sandbox with the current behavior
Sandbox example: https://codesandbox.io/embed/vueinstantsearchv2starter-8jx9i
What is the expected behavior?
The dropdown should reflect the selected option in the URL when you have selected something other than the default and then reloaded the page.
Does this happen only in specific situations?
What is the proposed solution?
Unsure!
What is the version you are using?
v2.1.0
fix(HitsPerPage): compute selected from isRefined (#5469)
- fix(HitsPerPage): compute selected from isRefined
This makes it responsive to the URL, as expected like other widgets.
fixes https://github.com/algolia/instantsearch/issues/5397
Slight improvement in the HitsPerPage + SortBy tests, as it was relying on Vue state instead of the DOM
I wanted both to be exactly the same, but SortBy doesn't have isRefined on the items apparently.
- deasync
fix(HitsPerPage): compute selected from isRefined
Summary
fixes https://github.com/algolia/instantsearch/issues/5397
Slight improvement in the HitsPerPage + SortBy tests, as it was relying on Vue state instead of the DOM
I wanted both to be exactly the same, but SortBy doesn't have isRefined on the items apparently.
Workaround in the example to make HitsPerPage responsive to the URL is also removed.
Result
This makes HitsPerPage responsive to the URL, as expected like other widgets.
fix(HitsPerPage): compute selected from isRefined
Yes, I doubted to write a common test here, but I was juggling too many other things to write it just yet
`createURL` always returns root/empty url on first render
Yes, we have not found a method to solve this problem yet.
Add sheep
they stink, bah, avoid!!! https://data.stad.gent/explore/dataset/sheep-tracking-gent/information/
actually implement
right path
HitsPerPage doesn’t work correctly with routeToState()
This makes sense, I've just opened a PR which fixes it so you won't need that workaround anymore in the future.
fix(HitsPerPage): compute selected from isRefined
Summary
fixes https://github.com/algolia/instantsearch/issues/5397
Slight improvement in the HitsPerPage + SortBy tests, as it was relying on Vue state instead of the DOM
I wanted both to be exactly the same, but SortBy doesn't have isRefined on the items apparently.
Workaround in the example to make HitsPerPage responsive to the URL is also removed.
Result
This makes HitsPerPage responsive to the URL, as expected like other widgets.
fix(types): expose InstantSearchStatus (#5463)
this isn't needed now, but i needed in a different iteration. It's probably interesting if it's exposed
ci(shipjs): only tag non-tagged packages (#5466)
-
ci(shipjs): only tag non-tagged packages
-
simpler
chore(build): resolve scoped packages correctly
chore(jest): use local InstantSearch.js
mapping all files (widgets, connectors, utils) allows us to run jest --watch without ever needing to build to see updates
