Haroenv
Repos
775
Followers
508
Following
109

⚡️ A library for building performant and instant search experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue

3070
411

A quarantine-ready Wikipedia game, to be played by two people

14
2

Fast and easy searching inside a page

1698
72

Yarn package manager website

406
860

Float a number of things up on a page (hearts, flowers, emojis, words ...)

215
15

the shittiest job titles you'll ever see

107
19

Events

pull request opened
fix(insights): pass clickAnalytics automatically

FX-2191

Created at 20 hours ago
create branch
Haroenv create branch wip/insights-auto-clickAnalytics
Created at 20 hours ago
pull request closed
Update and rename lang/en/index.md to lang/en/kongpcmail/index.md
Created at 20 hours ago

types are happy again

eslint

Created at 22 hours ago
closed issue
HitsPerPage doesn’t work correctly with routeToState()

Bug 🐞

What is the current behavior?

  • Use the ais-hits-per-page component as described in the docs
  • Then set up the routing as per the "User-friendly URLs" section detailed here: https://www.algolia.com/doc/guides/building-search-ui/going-further/routing-urls/js/#user-friendly-urls
  • Using the widget updates the UI state correctly and also updates the URL
  • Reloading the page sets the state correctly but doesn’t update the UI of the widget

Make a sandbox with the current behavior

Sandbox example: https://codesandbox.io/embed/vueinstantsearchv2starter-8jx9i

What is the expected behavior?

The dropdown should reflect the selected option in the URL when you have selected something other than the default and then reloaded the page.

Does this happen only in specific situations?

What is the proposed solution?

Unsure!

What is the version you are using?

v2.1.0

Created at 1 day ago
delete branch
Haroenv delete branch fix/vue-hits-per-page-url
Created at 1 day ago

fix(HitsPerPage): compute selected from isRefined (#5469)

  • fix(HitsPerPage): compute selected from isRefined

This makes it responsive to the URL, as expected like other widgets.

fixes https://github.com/algolia/instantsearch/issues/5397

Slight improvement in the HitsPerPage + SortBy tests, as it was relying on Vue state instead of the DOM

I wanted both to be exactly the same, but SortBy doesn't have isRefined on the items apparently.

  • deasync
Created at 1 day ago
pull request closed
fix(HitsPerPage): compute selected from isRefined

Summary

fixes https://github.com/algolia/instantsearch/issues/5397

Slight improvement in the HitsPerPage + SortBy tests, as it was relying on Vue state instead of the DOM

I wanted both to be exactly the same, but SortBy doesn't have isRefined on the items apparently.

Workaround in the example to make HitsPerPage responsive to the URL is also removed.

Result

This makes HitsPerPage responsive to the URL, as expected like other widgets.

Created at 1 day ago
issue comment
fix(HitsPerPage): compute selected from isRefined

Yes, I doubted to write a common test here, but I was juggling too many other things to write it just yet

Created at 1 day ago
issue comment
`createURL` always returns root/empty url on first render

Yes, we have not found a method to solve this problem yet.

Created at 1 day ago
closed issue
Add sheep

they stink, bah, avoid!!! https://data.stad.gent/explore/dataset/sheep-tracking-gent/information/

Created at 1 day ago

don't parse twice lol

Created at 1 day ago

actually implement

right path

Created at 1 day ago

chore(jest): avoid overlap

Created at 1 day ago
issue comment
HitsPerPage doesn’t work correctly with routeToState()

This makes sense, I've just opened a PR which fixes it so you won't need that workaround anymore in the future.

Created at 1 day ago
pull request opened
fix(HitsPerPage): compute selected from isRefined

Summary

fixes https://github.com/algolia/instantsearch/issues/5397

Slight improvement in the HitsPerPage + SortBy tests, as it was relying on Vue state instead of the DOM

I wanted both to be exactly the same, but SortBy doesn't have isRefined on the items apparently.

Workaround in the example to make HitsPerPage responsive to the URL is also removed.

Result

This makes HitsPerPage responsive to the URL, as expected like other widgets.

Created at 1 day ago
create branch
Haroenv create branch fix/vue-hits-per-page-url
Created at 1 day ago

fix(types): expose InstantSearchStatus (#5463)

this isn't needed now, but i needed in a different iteration. It's probably interesting if it's exposed

ci(shipjs): only tag non-tagged packages (#5466)

  • ci(shipjs): only tag non-tagged packages

  • simpler

chore(build): resolve scoped packages correctly

chore(jest): use local InstantSearch.js

mapping all files (widgets, connectors, utils) allows us to run jest --watch without ever needing to build to see updates

Created at 2 days ago