GMTA
Repos
33
Followers
49
Following
18

Events

Base: Add some emoji

Emoji included: โ™Ÿ - U+265F BLACK CHESS PAWN โฃ - U+2763 HEAVY HEART EXCLAMATION MARK ORNAMENT โค - U+2764 HEAVY BLACK HEART ๐Ÿœ - U+1F35C STEAMING BOWL ๐ŸŽŠ - U+1F38A CONFETTI BALL ๐ŸŽŸ - U+1F39F ADMISSION TICKETS ๐Ÿพ - U+1F43E PAW PRINTS ๐Ÿ’“ - U+1F493 BEATING HEART ๐Ÿ’” - U+1F494 BROKEN HEART ๐Ÿ’• - U+1F495 TWO HEARTS ๐Ÿ’– - U+1F496 SPARKLING HEART ๐Ÿ’— - U+1F497 GROWING HEART ๐Ÿ’˜ - U+1F498 HEART WITH ARROW ๐Ÿ’™ - U+1F499 BLUE HEART ๐Ÿ’š - U+1F49A GREEN HEART ๐Ÿ’› - U+1F49B YELLOW HEART ๐Ÿ’œ - U+1F49C PURPLE HEART ๐Ÿ’ - U+1F49D HEART WITH RIBBON ๐Ÿ“ฐ - U+1F4F0 NEWSPAPER ๐Ÿ–ค - U+1F5A4 BLACK HEART ๐Ÿ—‘ - U+1F5D1 WASTEBASKET ๐ŸšŽ - U+1F68E TROLLEYBUS ๐Ÿค - U+1F90D WHITE HEART ๐ŸคŽ - U+1F90E BROWN HEART ๐Ÿงก - U+1F9E1 ORANGE HEART ๐Ÿงฌ - U+1F9EC DNA DOUBLE HELIX

Everywhere: Fix badly-formatted includes

LibDebug: Break inclusion cycle through many forward-declarations

LibPDF: Break inclusion cycle by removing unnecessary include

LibJS: Break inclusion cycle by removing unnecessary include

LibJS: Break another inclusion cycle by removing unnecessary include

LibWeb: Break inclusion cycle through forward-declaration

LibWeb: Break inclusion cycle by removing unnecessary include

LibCompress+Tests: Demonstrate and fix faulty metadata length

The test-case is heavily inspired by: https://github.com/google/brotli/blob/master/tests/testdata/x.compressed.01 Or in words: A metadata meta-block containing Y (which should be ignored), and then the actual data (a single Z). The bug used to skip one metadata byte too few, and thus read garbage.

LibGL: Prevent segfault due to texture destruction

Destruction of GL::GLContext resulted in the destruction of GPU::Driver before the destruction of the allocated textures, which in turn point to GPU::Image objects. Since the destruction of GPU::Driver unloads the shared library, we were trying to invoke non-existing code.

Fix this by moving m_driver up in GLContext so that it's last in line for destruction.

Created at 2 weeks ago
pull request opened
LibGL: Prevent segfault due to texture destruction

Destruction of GL::GLContext resulted in the destruction of GPU::Driver before the destruction of the allocated textures, which in turn point to GPU::Image objects. Since the destruction of GPU::Driver unloads the shared library, we were trying to invoke non-existing code.

Fix this by moving m_driver up in GLContext so that it's last in line for destruction.

This problem was exposed when running the LibGL tests in Lagom, which has a functioning implementation of dlclose(). Inside Serenity, dlclose() is still something of a noop and as such did not expose this problem.

Created at 2 weeks ago
create branch
GMTA create branch libgl-fix-texture-segfault
Created at 2 weeks ago
pull request opened
Ports+LibGL: Fix SDL2 build and remove `GL::present_context`

Recent changes broke the SDL2 port build, this fixes that. Also remove GL::present_context now that we're there.

CC @ADKaster

Created at 2 weeks ago

LibGL: Remove GL::present_context

No need for a static method if all it does is invoke the object method.

Created at 2 weeks ago
create branch
GMTA create branch libgl-sdl2-fix-context
Created at 2 weeks ago
pull request opened
LibSoftGPU: Return a `const&` texel in `Image` to prevent copying

On every texel access, some floating point instructions involved in copying 4 floats popped up. Let Image::texel() const return a FloatVector4 const& to prevent these operations.

This results in a ~7% FPS increase in GLQuake on my machine.

Created at 2 weeks ago