71
13
4
Elixir is a dynamic, functional language designed for building scalable and maintainable applications
Simple angular directive for button showing progress and result of promise (eg resource request call)
Connect to shell of containerized application like you were used to before Docker
Events
DocX push DocX/kubeclient
add test for watch with empty groups
DocX push DocX/kubeclient
add unit test for empty config values
support impersonation via aut_options and in kubectl config
@cben thanks for the review. I've added the changelog and unit test for watch. Please take a look.
DocX push DocX/kubeclient
add changelog
add unit test for watch
Kubernetes API Authentication Proxy Request Headers
This is also issue with HTTP client libraries in ruby that does not support sending multiple request headers with same name. It is of course possible to send it on IO level but that is impractical.
Same goes for the Impersonate-User header
Impossible to make request with same-name multi-value headers
There is actually open issue in Kubernetes about this. Apparently comma has special semantics for Kubernetes, so just simply joining multiple values with comma is not possible.
Impossible to make request with same-name multi-value headers
The golang kubernetes client supports multiple group headers for example:
https://github.com/kubernetes/client-go/blob/c6bd30b9ec5f668df191bc268c6f550c37726edb/transport/round_trippers.go#L251-L252
DocX push DocX/kubeclient
fix: handle multi value impersonation fields
DocX push DocX/kubeclient
fix: handle multi value impersonation fields
DocX push DocX/kubeclient
fix: handle multi value impersonation fields
Impossible to make request with same-name multi-value headers
Basic Info
- Faraday Version: 2.7.4
- Ruby Version: 3.1.0
Issue description
Setting multi-value headers in request method results in the headers to be send as single header with values joined by comma ,.
This makes it impossible to use some APIs that expects multiple values to be send as independent headers with the same name, example https://kubernetes.io/docs/reference/access-authn-authz/authentication/#user-impersonation
Steps to reproduce
Make request with Faraday:
require "faraday"
Faraday.get("http://localhost/", {}, { "Test" => ["foo", "bar"] })
Received request headers on server side:
GET / HTTP/1.1
Host: localhost
User-Agent: Faraday v2.7.4
Accept: */*
Accept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3
Test: foo, bar
Expected headers:
GET / HTTP/1.1
Host: localhost
User-Agent: Faraday v2.7.4
Accept: */*
Accept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3
Test: foo
Test: bar
DocX push DocX/kubeclient
fix: handle multi value impersonation fields
support impersonation via auth_options and in kubectl config
Hi @grosser I've updated your work to latest master and tested it works. I've run into the missing impersonation when working on our internal project. Getting the update makes it work.
I've made new PR here: https://github.com/ManageIQ/kubeclient/pull/600 but feel free to update this PR if you think you would loose the credit :)
DocX push DocX/kubeclient
fix: add headers to faraday client
support impersonation via aut_options and in kubectl config
This PR is rebase and update of https://github.com/ManageIQ/kubeclient/pull/524 to current master version
We tested it and it works as expected
fix: handle informer.stop_worker race conditions
@cben thanks for merging the other PR. resolved the conflict and rebased the commits to one.
DocX push DocX/kubeclient
fix: handle Informer#stop_worker race conditions
DocX push DocX/kubeclient
feat: allow passing options to Informer
Merge pull request #598 from DocX/docx/allow-options-pass-to-informer
feat: allow passing options to Informer
Merge branch 'master' into docx/fix-watcher-race-condition
fix: handle informer.stop_worker race conditions
@cben thanks. the error looks like it was flake, however i've updated the unit test code anyway to be more robust and less time-dependent. hopefully it should help.
