DanielRuf
Repos
5
Followers
551
Following
2

NinjaFirewall setup documentation - in English and German

7
2

patches for SNYK-JS-JQUERY-174006, CVE-2019-11358, CVE-2019-5428

24
20

patches for SNYK-JS-JQUERY-565129, SNYK-JS-JQUERY-567880, CVE-2020-1102, CVE-2020-11023, includes the patches for SNYK-JS-JQUERY-174006, CVE-2019-11358, CVE-2019-5428

17
8

Events

started
Created at 1 day ago
Update and rearrange content for readability

@LoganTann now you should be able to merge. If not, please let me know.

Created at 1 day ago
Update and rearrange content for readability

@materializecss/maintainers I don't have the right to run the CI. Can someone take care of it in order to get this validated for merge ?

I did now.

Created at 2 days ago
issue comment
Update READMEs and delete deprecated docs

Perfect, thank you very much =)

Created at 6 days ago
issue comment
Fix typo in README

Besides that, there is a very old DOCS.md file at https://github.com/ionos-cloud/sdk-nodejs/blob/master/DOCS.md which contains more suche cases.

Not sure if this file is still used or obsolete like the old lowercase files (see https://github.com/ionos-cloud/sdk-nodejs/issues/5#issuecomment-1259487707).

Created at 1 week ago
issue comment
Fix typo in README

Hi, there is also one more at https://github.com/ionos-cloud/sdk-nodejs/tree/master/docs#usage

Created at 1 week ago
issue comment
Wrong documentation / example in readme

Looks like all these md files with a lowercase filename are from the v5 API and should be removed for v6:

grafik

Created at 1 week ago
issue comment
datacentersGet returns nothing

Resolved, we had to use import instead of require. Maybe you want to extend the documentation with import * as sdk from '@ionos-cloud/sdk-nodejs';

Created at 1 week ago
closed issue
datacentersGet returns nothing

Description

I have wondered why DataCentersApi.datacentersGet() did nothing and returns nothing.

dcApi.datacentersGet().then((response: any, error: any) => log.debug(error));

SDK version:

6.1.1

How to Reproduce

            // initialize new SDK instance
            const dcApi = new sdk.DataCentersApi(sdkConfig);
            dcApi.datacentersGet().then((response: any) => log.debug(error));

Error and Debug Output

Created at 1 week ago
issue comment
datacentersGet returns nothing

Trying some workarounds. Closing until I can provide a simple reproducible test case.

Created at 1 week ago
opened issue
Wrong hostname / URL used in requests

Description

I have wondered why DataCentersApi.datacentersGet() did nothing.

It looks like the configuration does not correctly set the API hostname and path:

grafik

grafik

Expected behavior

Correct hostname and path https://api.ionos.com/cloudapi/v6 should be used.

SDK version:

6.1.1

How to Reproduce

            // initialize new SDK instance
            const dcApi = new sdk.DataCentersApi(sdkConfig);
            dcApi.datacentersGet().then((response: any) => log.debug(error));

Error and Debug Output

Created at 1 week ago
issue comment
Wrong documentation / example in readme

Should probably be "DataCentersApi" - mind the extra "s" before "Api".

The file was renamed there: https://github.com/ionos-cloud/sdk-nodejs/commits/master/api/data-centers-api.ts

Created at 1 week ago
issue comment
Wrong documentation / example in readme

Should probably be "DataCentersApi" - mind the extra "s" before "Api".

Created at 1 week ago
opened issue
Wrong documentation / example in readme

Description

The example code form the readme thows TypeError: sdk.DataCenterApi is not a constructor

Expected behavior

It should work.

Environment

not relevant

Node version: not relevant

SDK version:

6.1.1

OS: not relevant

Configuration Files

not relevant

How to Reproduce

Use the code example from the readme.

Created at 1 week ago
issue comment
Fatal Error with JetPopup and Elementor 3.7.7

See also https://github.com/elementor/elementor/issues/19894

Created at 1 week ago
issue comment
Fatal Error after updating to 3.7.7

Duplicate of https://github.com/elementor/elementor/issues/19894 which was unfortunately closed.

As a workaround see https://github.com/elementor/elementor/issues/19894#issuecomment-1256314016

Created at 1 week ago
Created at 1 week ago
issue comment
Fatal error in Elementor 3.7.7 when a widget with responsive controls is placed

@udidol can you check this please? Also see my remarks regarding the overall process, which felt a bit rushed. Thank you very much.

https://github.com/elementor/elementor/commit/06ab0228a2ce175dfc529579c6d9d0de36dae8e8

https://github.com/elementor/elementor/issues/19487

https://github.com/elementor/elementor/pull/19818

Created at 1 week ago
Created at 1 week ago
issue comment
Fatal error in Elementor 3.7.7 when a widget with responsive controls is placed

As pointed out by @DanielRuf (thanks Daniel! 🙏), the methods you are using have been deprecated.

@nicholaszein well, normally I would expect:

  • deprecation notice in a patch / minor release, no logic changes
  • no logic changes for this original function
  • new function with different name and logic is added
  • deprecation notice is elevated to error / fatal error in next minor / major release
  • clear documentation of this breaking change in the docs / readme
  • clear migration guide linked in the relevant function and deprecation message

Your links suggest, that this was deprecated in 3.2. But you added the deprecation warning (for 3.7.6) only starting with the last 3.7.7 update.

https://wiki.php.net/rfc/e-user-deprecated-warning

Changelog says Tweak and 2x Fix. This does not reflect your breaking changes.

The @deprecated 3.7.6 annotation makes not much sense , and so does ->deprecation->deprecated_function. Because you basically mark it as deprecated, throw the deorecation warning, change the implementation (that is not how deorecated functions should be handled) and directly break it in the same patch release.

All in one single release. That is the fastest move from deprecation to breaking change of something that I have ever witnessed.

Marking something as deprecated is a way to tell the consumers that it will be removed or lead to a breaking change in the (near) future, but not in the exact same release.

https://stackoverflow.com/questions/194121/how-to-deprecate-a-function-in-php

To me this release, the deprecation and the overall handling including the closure of the issue feels a bit rushed. You may reconsider to give consumers and developers a bit time from deprecation until the final braking change, and want to revert the change in the original function but use the new one internally. Good developers read the errorlog and resolve all the deprecation warnings while the application still works as expected.

Created at 1 week ago
issue comment
[URGENT] Fatal error in Elementor 3.7.7 when a widget with responsive controls is placed

@artkrsk can you try to change this function back to the previous state?

Alternatively you can change $control = $controls_stack[ $parser_control_name . $device_suffix ]; to $control = $controls_stack[ $parser_control_name ]; to have the exact same logic in the if and else part.

Created at 1 week ago
issue comment
[URGENT] Fatal error in Elementor 3.7.7 when a widget with responsive controls is placed

The only relevant change seems to be this, which probably causes this (according to the stacktrace):

diff --color -x '*.css' -x '*.js' -ur elementor.3.7.6/elementor/core/files/css/base.php elementor.3.7.7/elementor/core/files/css/base.php
--- elementor.3.7.6/elementor/core/files/css/base.php	2022-08-15 11:06:56.000000000 +0200
+++ elementor.3.7.7/elementor/core/files/css/base.php	2022-09-20 10:26:10.000000000 +0200
@@ -436,7 +436,14 @@
 	 */
 	public function parse_property_placeholder( array $control, $value, array $controls_stack, $value_callback, $placeholder, $parser_control_name = null ) {
 		if ( $parser_control_name ) {
-			$control = $controls_stack[ $parser_control_name ];
+			// If both the processed control and the control name found in the placeholder are responsive
+			if ( ! empty( $control['responsive'] ) && ! empty( $controls_stack[ $parser_control_name ]['responsive'] ) ) {
+				$device_suffix = Controls_Manager::get_responsive_control_device_suffix( $control );
+
+				$control = $controls_stack[ $parser_control_name . $device_suffix ];
+			} else {
+				$control = $controls_stack[ $parser_control_name ];
+			}
Created at 1 week ago
issue comment
[URGENT] Fatal error in Elementor 3.7.7 when a widget with responsive controls is placed

Others report the same.

Here is a diff of the PHP files between 3.7.6 and 3.7.7:

diff --color -x '*.css' -x '*.js' -ur elementor.3.7.6/elementor/core/admin/menu/admin-menu-manager.php elementor.3.7.7/elementor/core/admin/menu/admin-menu-manager.php
--- elementor.3.7.6/elementor/core/admin/menu/admin-menu-manager.php	2022-08-29 12:01:52.000000000 +0200
+++ elementor.3.7.7/elementor/core/admin/menu/admin-menu-manager.php	2022-09-19 16:26:20.000000000 +0200
@@ -49,17 +49,19 @@
 	private function register_wp_menus() {
 		do_action( 'elementor/admin/menu/register', $this );
 
+		$hooks = [];
+
 		foreach ( $this->get_all() as $item_slug => $item ) {
 			$is_top_level = empty( $item->get_parent_slug() );
 
 			if ( $is_top_level ) {
-				$this->register_top_level_menu( $item_slug, $item );
+				$hooks[ $item_slug ] = $this->register_top_level_menu( $item_slug, $item );
 			} else {
-				$this->register_sub_menu( $item_slug, $item );
+				$hooks[ $item_slug ] = $this->register_sub_menu( $item_slug, $item );
 			}
 		}
 
-		do_action( 'elementor/admin/menu/after_register', $this );
+		do_action( 'elementor/admin/menu/after_register', $this, $hooks );
 	}
 
 	private function register_top_level_menu( $item_slug, Admin_Menu_Item $item ) {
@@ -68,7 +70,7 @@
 		$page_title = $has_page ? $item->get_page_title() : '';
 		$callback = $has_page ? [ $item, 'render' ] : '';
 
-		add_menu_page(
+		return add_menu_page(
 			$page_title,
 			$item->get_label(),
 			$item->get_capability(),
@@ -83,7 +85,7 @@
 		$page_title = $has_page ? $item->get_page_title() : '';
 		$callback = $has_page ? [ $item, 'render' ] : '';
 
-		add_submenu_page(
+		return add_submenu_page(
 			$item->get_parent_slug(),
 			$page_title,
 			$item->get_label(),
diff --color -x '*.css' -x '*.js' -ur elementor.3.7.6/elementor/core/common/modules/connect/admin.php elementor.3.7.7/elementor/core/common/modules/connect/admin.php
--- elementor.3.7.6/elementor/core/common/modules/connect/admin.php	2022-09-14 16:21:22.000000000 +0200
+++ elementor.3.7.7/elementor/core/common/modules/connect/admin.php	2022-09-19 16:26:20.000000000 +0200
@@ -20,11 +20,7 @@
 	 * @access public
 	 */
 	public function register_admin_menu( Admin_Menu_Manager $admin_menu ) {
-
 		$admin_menu->register( static::PAGE_ID, new Connect_Menu_Item() );
-
-		// TODO: Find a way to get the hook name from the register.
-		add_action( 'load-elementor_page_' . static::PAGE_ID, [ $this, 'on_load_page' ] );
 	}
 
 	/**
@@ -64,5 +60,11 @@
 		self::$url = admin_url( 'admin.php?page=' . self::PAGE_ID );
 
 		add_action( 'elementor/admin/menu/register', [ $this, 'register_admin_menu' ] );
+
+		add_action( 'elementor/admin/menu/after_register', function ( Admin_Menu_Manager $admin_menu, array $hooks ) {
+			if ( ! empty( $hooks[ static::PAGE_ID ] ) ) {
+				add_action( 'load-' . $hooks[ static::PAGE_ID ], [ $this, 'on_load_page' ] );
+			}
+		}, 10, 2 );
 	}
 }
diff --color -x '*.css' -x '*.js' -ur elementor.3.7.6/elementor/core/files/css/base.php elementor.3.7.7/elementor/core/files/css/base.php
--- elementor.3.7.6/elementor/core/files/css/base.php	2022-08-15 11:06:56.000000000 +0200
+++ elementor.3.7.7/elementor/core/files/css/base.php	2022-09-20 10:26:10.000000000 +0200
@@ -436,7 +436,14 @@
 	 */
 	public function parse_property_placeholder( array $control, $value, array $controls_stack, $value_callback, $placeholder, $parser_control_name = null ) {
 		if ( $parser_control_name ) {
-			$control = $controls_stack[ $parser_control_name ];
+			// If both the processed control and the control name found in the placeholder are responsive
+			if ( ! empty( $control['responsive'] ) && ! empty( $controls_stack[ $parser_control_name ]['responsive'] ) ) {
+				$device_suffix = Controls_Manager::get_responsive_control_device_suffix( $control );
+
+				$control = $controls_stack[ $parser_control_name . $device_suffix ];
+			} else {
+				$control = $controls_stack[ $parser_control_name ];
+			}
 
 			$value = call_user_func( $value_callback, $control );
 		}
diff --color -x '*.css' -x '*.js' -ur elementor.3.7.6/elementor/core/kits/documents/tabs/settings-site-identity.php elementor.3.7.7/elementor/core/kits/documents/tabs/settings-site-identity.php
--- elementor.3.7.6/elementor/core/kits/documents/tabs/settings-site-identity.php	2022-09-15 14:00:20.000000000 +0200
+++ elementor.3.7.7/elementor/core/kits/documents/tabs/settings-site-identity.php	2022-09-20 10:26:10.000000000 +0200
@@ -102,24 +102,6 @@
 		);
 
 		$this->add_control(
-			'custom_logo_promotion',
-			[
-				'type' => Controls_Manager::RAW_HTML,
-				'raw' => '<p>' . esc_html__( 'Add a logo to display on your website. Don\'t have one yet? Create a professional logo with Fiverr\'s logo maker.', 'elementor' ) .
-					'</p>' .
-					sprintf(
-						'<a target="_blank" class="elementor-button e-logo-maker" href="%s">%s</a>',
-						'https://go.fiverr.com/visit/?bta=496327&brand=fiverrcpa&utm_campaign=SiteLogo&landingPage=https%3A%2F%2Fwww.fiverr.com%2Flogo-maker%2Felementor',
-						esc_html__( 'Create a Logo in Minutes', 'elementor' )
-					),
-				'condition' => [
-					'site_logo[url]' => '',
-				],
-				'content_classes' => 'elementor-panel-alert elementor-panel-alert-success',
-			]
-		);
-
-		$this->add_control(
 			'site_favicon',
 			[
 				'label' => esc_html__( 'Site Favicon', 'elementor' ),
diff --color -x '*.css' -x '*.js' -ur elementor.3.7.6/elementor/elementor.php elementor.3.7.7/elementor/elementor.php
--- elementor.3.7.6/elementor/elementor.php	2022-09-15 14:00:20.000000000 +0200
+++ elementor.3.7.7/elementor/elementor.php	2022-09-20 14:50:38.000000000 +0200
@@ -4,7 +4,7 @@
  * Description: The Elementor Website Builder has it all: drag and drop page builder, pixel perfect design, mobile responsive editing, and more. Get started now!
  * Plugin URI: https://elementor.com/?utm_source=wp-plugins&utm_campaign=plugin-uri&utm_medium=wp-dash
  * Author: Elementor.com
- * Version: 3.7.6
+ * Version: 3.7.7
  * Author URI: https://elementor.com/?utm_source=wp-plugins&utm_campaign=author-uri&utm_medium=wp-dash
  *
  * Text Domain: elementor
@@ -27,7 +27,7 @@
 	exit; // Exit if accessed directly.
 }
 
-define( 'ELEMENTOR_VERSION', '3.7.6' );
+define( 'ELEMENTOR_VERSION', '3.7.7' );
 define( 'ELEMENTOR_PREVIOUS_STABLE_VERSION', '3.1.4' );
 
 define( 'ELEMENTOR__FILE__', __FILE__ );
diff --color -x '*.css' -x '*.js' -ur elementor.3.7.6/elementor/includes/base/controls-stack.php elementor.3.7.7/elementor/includes/base/controls-stack.php
--- elementor.3.7.6/elementor/includes/base/controls-stack.php	2022-09-14 16:21:22.000000000 +0200
+++ elementor.3.7.7/elementor/includes/base/controls-stack.php	2022-09-20 14:50:38.000000000 +0200
@@ -1352,19 +1352,14 @@
 	/**
 	 * Get Responsive Control Device Suffix
 	 *
+	 * @deprecated 3.7.6
 	 * @param array $control
 	 * @return string $device suffix
 	 */
 	protected function get_responsive_control_device_suffix( $control ) {
-		if ( ! empty( $control['responsive']['max'] ) ) {
-			$query_device = $control['responsive']['max'];
-		} elseif ( ! empty( $control['responsive']['min'] ) ) {
-			$query_device = $control['responsive']['min'];
-		} else {
-			return '';
-		}
+		Plugin::$instance->modules_manager->get_modules( 'dev-tools' )->deprecation->deprecated_function( __METHOD__, '3.7.6', 'Elementor\Controls_Manager::get_responsive_control_device_suffix()' );
 
-		return 'desktop' === $query_device ? '' : '_' . $query_device;
+		return Controls_Manager::get_responsive_control_device_suffix( $control );
 	}
 
 	/**
@@ -1410,7 +1405,7 @@
 			$condition_name_to_check = $pure_condition_key;
 
 			if ( $are_control_and_condition_responsive ) {
-				$device_suffix = $this->get_responsive_control_device_suffix( $control );
+				$device_suffix = Controls_Manager::get_responsive_control_device_suffix( $control );
 
 				$condition_name_to_check = $pure_condition_key . $device_suffix;
 
diff --color -x '*.css' -x '*.js' -ur elementor.3.7.6/elementor/includes/managers/controls.php elementor.3.7.7/elementor/includes/managers/controls.php
--- elementor.3.7.6/elementor/includes/managers/controls.php	2022-09-14 16:21:22.000000000 +0200
+++ elementor.3.7.7/elementor/includes/managers/controls.php	2022-09-20 10:26:10.000000000 +0200
@@ -1079,6 +1079,24 @@
 	}
 
 	/**
+	 * Get Responsive Control Device Suffix
+	 *
+	 * @param array $control
+	 * @return string $device suffix
+	 */
+	public static function get_responsive_control_device_suffix( array $control ): string {
+		if ( ! empty( $control['responsive']['max'] ) ) {
+			$query_device = $control['responsive']['max'];
+		} elseif ( ! empty( $control['responsive']['min'] ) ) {
+			$query_device = $control['responsive']['min'];
+		} else {
+			return '';
+		}
+
+		return 'desktop' === $query_device ? '' : '_' . $query_device;
+	}
+
+	/**
 	 * Add custom attributes controls.
 	 *
 	 * This method adds a new control for the "Custom Attributes" feature. The free
diff --color -x '*.css' -x '*.js' -ur elementor.3.7.6/elementor/readme.txt elementor.3.7.7/elementor/readme.txt
--- elementor.3.7.6/elementor/readme.txt	2022-09-15 14:00:20.000000000 +0200
+++ elementor.3.7.7/elementor/readme.txt	2022-09-20 14:50:38.000000000 +0200
@@ -4,7 +4,7 @@
 Requires at least: 5.0
 Tested up to: 6.0
 Requires PHP: 7.0
-Stable tag: 3.7.6
+Stable tag: 3.7.7
 License: GPLv3
 License URI: https://www.gnu.org/licenses/gpl-3.0.html
 
@@ -240,6 +240,11 @@
 
 See Elementor Developer Edition versions changelog [here](https://go.elementor.com/dev-changelog/)
 
+= 3.7.7 - 2022-09-20 =
+* Tweak: Removed the option to create a custom logo in Site Settings ([#19823](https://github.com/elementor/elementor/issues/19823))
+* Fix: Custom X Position of background image doesn't work for non-desktop devices ([#19487](https://github.com/elementor/elementor/issues/19487), [#19662](https://github.com/elementor/elementor/issues/19662), [#19669](https://github.com/elementor/elementor/issues/19669), [#19527](https://github.com/elementor/elementor/issues/19527))
+* Fix: Connect & activate to Elementor account issue with various WordPress site languages
+
 = 3.7.6 - 2022-09-15 =
 * Fix: Replaced link for better clarity in Site Settings
 
Created at 1 week ago
Created at 1 week ago