DJTB
Repos
14
Followers
38
Following
8

Javascript library for detecting and transliterating Hiragana <--> Katakana <--> Romaji

584
68

UI and Client functionality for KaniWani

38
4

React Furigana Component

29
7

Japanese pitch accent utils

17
0

Events

closed issue
Text selections mixes furigana with kanji

I'm submitting a…

  • [ ] Regression (a behavior that used to work and stopped working in a new release)
  • [X] Bug report
  • [ ] Feature request
  • [ ] Documentation issue or request
  • [ ] Support request

Expected Behavior

When selecting kanji symbols, only kanji symbols are selected.

Current Behavior

When copying kanji which has furigana above it, the furigana symbols will be mixed together with kanji. For example, when I select お見舞い and copy it, my clipboard content is:

お
みま
見舞
い

Possible Solution

Use user-select: none for furigana span?

Steps to Reproduce (for bugs)

  1. Open Demo page
  2. Try to copy any kanji with uses ReactFuri component and has furi symbols
  3. Paste that text somewhere
Created at 2 weeks ago
issue comment
Text selections mixes furigana with kanji

Great detail investigating further, though I think this is outside of the scope of this package if Safari and Brave ignore the css.

Any consumers that are displaying text that they expect users may want to copy could either: a) provide a furigana toggle so users can hide furigana before copying b) provide a small copy to clipboard button that adds text without furigana

Created at 2 weeks ago
Created at 2 weeks ago
issue comment
Text selections mixes furigana with kanji

Thanks for the issue report. Can you provide more details? The furi span already has user-select: none; applied and is not copied (at least on Chrome and Firefox I checked quickly).

Created at 3 weeks ago
issue comment
Text selections mixes furigana with kanji

Thanks for the issue report. Makes sense that this should be ignored when copying 👍

Created at 3 weeks ago
issue comment
[BUG]: Cannot generate colors

I'm not sure since I didn't keep this repo around. It was created with https://pub.dev/packages/very_good_cli.

I am currently on:

Flutter 3.3.10 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 135454af32 (3 weeks ago) • 2022-12-15 07:36:55 -0800
Engine • revision 3316dd8728
Tools • Dart 2.18.6 • DevTools 2.15.0

But I expect when I filed this bug I would have been using Flutter 3.3.8 and Dart 2.18.x

Happy to close this issue if you were unable to reproduce.

Created at 4 weeks ago
issue comment
Support path method to an asset folder

Similarly easy_localization only accepts a path, so I'm hardcoding the path. Note you have to declare the translations within assets in pubspec already, so flutter_gen is picking it up regardless - it's just not accessible since only the values for the files: en-us etc are available - but not helpful in this instance.

 EasyLocalization(
    supportedLocales: [Locale('en', 'US'), Locale('de', 'DE')],
    path: 'assets/translations', // <-- change the path of the translation files 
    fallbackLocale: Locale('en', 'US'),
    child: MyApp()
)
Created at 1 month ago
opened issue
[BUG]: Cannot generate colors

Is there an existing issue for this?

  • [X] I have searched the existing issues

Version

5.1.0+1

Command type

build_runner (Default)

What happened?

First time checking out this package.

Attempting to run with the following colors file (taken from the example dir)

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <color name="white">#FFFFFF</color>
    <color name="black">#000000</color>
    <color name="gray_70">#EEEEEE</color>
    <color name="gray_410">#979797</color>
    <color name="crimson_red" type="material">#CF2A2A</color>
    <color name="yellow_ocher" type="material material-accent">#DF9527</color>
</resources>

throws

Unhandled exception:
FormatException: Invalid radix-16 number (at line 2, character 2)

Not sure what I'm doing wrong here or if it's a legitimate bug 🤷

Relevant a pubspec.yaml.

name: theme_x
version: 0.1.0+1
publish_to: none

environment:
  sdk: '>=2.18.0 <3.0.0'
  flutter: 3.3.8

dependencies:
  flutter:
    sdk: flutter

dev_dependencies:
  build_runner: ^2.3.3
  flutter_gen_runner: ^5.1.0+1
  flutter_test:
    sdk: flutter
  very_good_analysis: ^3.1.0

flutter_gen:
  colors:
    inputs:
      - assets/colors/colors.xml

flutter:
  uses-material-design: true # Include the Material Icons font

  # Assets for the application
  assets:
    - assets/audio/
    - assets/images/
    - assets/text/
    - assets/translations/

  fonts:
    - family: Graphik
      fonts:
        - asset: assets/fonts/Graphik-Regular.otf
          weight: 400
        - asset: assets/fonts/Graphik-Medium.otf
          weight: 500
        - asset: assets/fonts/Graphik-Semibold.otf
          weight: 600
    - family: Boing
      fonts:
        - asset: assets/fonts/Boing-Medium.ttf
          weight: 500
    - family: Icons
      fonts:
        - asset: assets/fonts/Stile_X_Icons.ttf

Relevant log output

FlutterGen v5.1.0+1 Loading ... theme_x/pubspec.yaml
Unhandled exception:
FormatException: Invalid radix-16 number (at line 2, character 2)

 ^

#0      int._handleFormatError (dart:core-patch/integers_patch.dart:131)
#1      int._parse (dart:core-patch/integers_patch.dart:72)
#2      int.parse (dart:core-patch/integers_patch.dart:65)
#3      new HexColor (package:color/hex_color.dart:18)
#4      swatchFromPrimaryHex (package:flutter_gen_core/utils/color.dart:20)
#5      _colorStatement (package:flutter_gen_core/generators/colors_generator.dart:64)
#6      MappedListIterable.elementAt (dart:_internal/iterable.dart:413)
#7      ListIterable.forEach (dart:_internal/iterable.dart:39)
#8      generateColors (package:flutter_gen_core/generators/colors_generator.dart:55)
#9      FlutterGenerator.build (package:flutter_gen_core/flutter_generator.dart:53)
#10     main (file:///Users/runner/work/flutter_gen/flutter_gen/packages/command/bin/flutter_gen_command.dart:48)
#11     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:295)
#12     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192)

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct
Created at 1 month ago
Android Automatic Proxy from PAC Url

Should this package be able to derive a proxy from automatic url (via pac file) settings in Android or only on iOS?

When debugging locally it seems to discover host:localhost and port:-1 instead of 192.168.8.147:8888 which is what the findProxyForURL function in my pac returns, but trying with Platform Proxy I see the expected 192.168.8.147:8888.

I'm not sure if this is just an issue with debugging my local android setup (it seems to send traffic via a direct connection even when I set an automatic proxy...)

For what it's worth, I can see that platform_proxy does extra work in the native code https://gitlab.com/yamsergey/platform_proxy/-/tree/master/android/src/main/java/io/yamsergey/flutter/platform_proxy

I tried working that logic into flutter_system_proxys java code but ran into some issues which I don't have the experience with java to figure out easily 😅

Created at 1 month ago
issue comment
iOS: Support "Automatic" proxy configuration

Apologies if the tone sounded demanding, I am using that code already - I simply wanted to pass on the information since it seemed like something you were working on.

You're welcome!

Created at 1 month ago
Created at 1 month ago
issue comment
iOS: Support "Automatic" proxy configuration

I've had some success with https://gitlab.com/yamsergey/platform_proxy which is described here: https://yamsergey.medium.com/flutter-and-proxy-1e2b6acd24f5

I was able to retrieve a domain and port from automatic settings (that use a pac) on both an iphone and android device.

Perhaps the same logic could be applied in system_proxy?

Created at 1 month ago
Created at 1 month ago
delete branch
DJTB delete branch minor_updates
Created at 1 month ago

build: update deps (minor, patch only)

build: bump desired node version - remove unused config file

docs: remove defunct slack invite link

feat: allow single character notes

Merge pull request #141 from Kaniwani/minor_updates

Minor updates

Created at 1 month ago
pull request closed
Minor updates

Update some dependencies for security patches - ignored major bumps for now as they may require some heavy migration. Removed min length of 10 characters for reading notes, changed to 1, for user wanting to note down the pitch accent easily. Removed slack link that isn't working anyway.

Created at 1 month ago
pull request opened
Minor updates

Update some dependencies for security patches - ignored major bumps for now as they may require some heavy migration. Removed min length of 10 characters for reading notes, changed to 1, for user wanting to note down the pitch accent easily. Removed slack link that isn't working anyway.

Created at 1 month ago

docs: remove defunct slack invite link

feat: allow single character notes

Created at 1 month ago
create branch
DJTB create branch minor_updates
Created at 1 month ago
How to customize detect camera frame?

I just used what was in qr_scanner

Tweak the following:

Stack(
  children: [
    MobileScanner(/* options */),
    Positioned(
      top: 200,
      right: 0,
      bottom: 0,
      left: 0,
      child: QrScannerOverlayShape(cutOutSize: 250),
    ),
),

and this https://github.com/juliuscanute/qr_code_scanner/blob/master/lib/src/qr_scanner_overlay_shape.dart

Created at 1 month ago
issue comment
CTRL + SPACE not working as "show autocomplete" shortcut

These may be new keyboard shortcuts in ventura. image

Created at 2 months ago
issue comment
Convert to Typescript?

Awesome, any contributions are more than welcome! I think react-furi would be a fairly quick conversion afterwards.

Created at 2 months ago
started
Created at 2 months ago
pull request closed
Add C# port to readme and site

Hello!

I've ported WanaKana to C#.

I'm a long-time WaniKani student/fan. Thanks for all your great work.

Created at 2 months ago

Update README.md

Update index.html

Merge pull request #148 from kmoroz/c#-port

Add C# port to readme and site

Created at 2 months ago
delete branch
DJTB delete branch main
Created at 2 months ago
create branch
DJTB create branch master
Created at 2 months ago
create branch
DJTB create branch main
Created at 2 months ago
create repository
DJTB create repository
Created at 2 months ago