1ed
Repos
78
Followers
59
Following
137

Events

Created at 1 week ago
Created at 1 week ago
Created at 2 weeks ago
Created at 3 weeks ago
push
1ed push 1ed/ux

[Live] Fix Live Collection for forms with unnamed root

Created at 3 weeks ago
issue comment
[LiveComponent] LiveCollectionType does not play well without block prefix

Thanks for the reproducer. Should be fixed by #717

Created at 3 weeks ago
create branch
1ed create branch fix-live-forms-for-empty-rootname
Created at 3 weeks ago
pull request opened
[Live] Fix handling forms with unnamed root

| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | Fix #715 | License | MIT

Created at 3 weeks ago
started
Created at 3 weeks ago
delete branch
1ed delete branch fix-profiler-email-headers-6.2
Created at 1 month ago
pull request opened
[WebProfilerBundle] Render original (not encoded) email headers

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

Backported version of https://github.com/symfony/symfony/pull/49400

Created at 1 month ago
create branch
1ed create branch fix-profiler-email-headers-5.4
Created at 1 month ago

[Notifier] Replace tests dummy instances by already in place mocks

minor #49398 [Notifier] Replace tests dummy instances by already in place mocks (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion

[Notifier] Replace tests dummy instances by already in place mocks

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix https://github.com/symfony/symfony/pull/49385#issuecomment-1431677676 | License | MIT | Doc PR | NA

Replacing dummy classes to use already existing mocks and stubs (MockHttpClient, NullLogger and so on).

Commits

83120cb824 [Notifier] Replace tests dummy instances by already in place mocks

Fix test provider

CS fix

Fix tests

Bump absolute lowest dep to 4.4

Fix Request locale property doc types

minor #49414 Fix Request locale property doc types (bytestream)

This PR was submitted for the 6.2 branch but it was merged into the 5.4 branch instead.

Discussion

Fix Request locale property doc types

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR |

As shown by https://github.com/symfony/symfony/blob/b9eef0fb17a75b533b67ae15d291126a1ae8c93f/src/Symfony/Component/HttpFoundation/Request.php#L1391 the locale property can be null.

Commits

a05604e0b6 Fix Request locale property doc types

use TestCase suffix for abstract tests in Tests directories

minor #49419 [Intl] use TestCase suffix for abstract tests in Tests directories (xabbuh)

This PR was merged into the 5.4 branch.

Discussion

[Intl] use TestCase suffix for abstract tests in Tests directories

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR |

Commits

ec7a81e5e7 use TestCase suffix for abstract tests in Tests directories

[BC Break] Make data providers for abstract test cases static

[Translation][Mailer] Convert $this calls to static ones in data providers

bug #49368 [BC Break] Make data providers for abstract test cases static (OskarStark, alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion

[BC Break] Make data providers for abstract test cases static

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Refs #48668 | License | MIT | Doc PR | -

Follows https://github.com/symfony/symfony/pull/48668#issuecomment-1429413004

Todos

  • [x] Bump min version in composer.json Notifier @OskarStark
  • [x] Bump min version in composer.json Translation @OskarStark
  • [x] Bump min version in composer.json Mailer @OskarStark
  • [x] Bump min version in composer.json Security @OskarStark - nothing todo
  • [x] document BC break in CHANGELOG files Notifier @OskarStark
  • [x] document BC break in CHANGELOG files Translation @OskarStark
  • [x] document BC break in CHANGELOG files Mailer @OskarStark
  • [x] document BC break in CHANGELOG files Security @OskarStark
  • [x] document BC break in UPGRADE files Notifier @OskarStark
  • [x] document BC break in UPGRADE files Translation @OskarStark
  • [x] document BC break in UPGRADE files Mailer @OskarStark
  • [x] document BC break in UPGRADE files Security @OskarStark
  • [x] remove $this in static methods @alexandre-daubois
  • [x] make tests green

Commits

c444a430d1 [Translation][Mailer] Convert $this calls to static ones in data providers 77c8444a3d [BC Break] Make data providers for abstract test cases static

Created at 1 month ago
issue comment
[WebProfilerBundle] Tweak Mailer panel rendering

Should I fix the encoding stuff in 5.4 too (the tabs are different, so I think that's ok there)? It will cause conflicts, because the redesign.

Created at 1 month ago

[WebProfilerBundle] Render original (not encoded) email headers

[WebProfilerBundle] Change default tab to HTML Preview

Created at 1 month ago
create branch
1ed create branch fix-notification-email-raw
Created at 1 month ago
pull request opened
[TwigBridge] Fix raw content rendering in HTML notification emails

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR |

Applying nl2br on raw HTML seems wrong to me and it also makes raw ineffective.

Created at 1 month ago
pull request opened
[WebProfilerBundle] Tweak Mailer panel rendering

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

Before

Screenshot from 2023-02-15 23-03-29

After

Screenshot from 2023-02-15 23-04-05

Created at 1 month ago
create branch
1ed create branch fix-profiler-email-headers-6.2
Created at 1 month ago

Update CHANGELOG for 5.4.9

Update VERSION for 5.4.9

Merge pull request #46467 from fabpot/release-5.4.9

released v5.4.9

Bump Symfony version to 5.4.10

CS fix

Fix typo

Merge branch '4.4' into 5.4

  • 4.4: Fix typo CS fix Bump Symfony version to 4.4.43 Update VERSION for 4.4.42 Update CONTRIBUTORS for 4.4.42 Update CHANGELOG for 4.4.42

[DependencyInjection] remove static cache from ServiceSubscriberTrait

bug #46478 [Contracts] remove static cache from ServiceSubscriberTrait (kbond)

This PR was merged into the 4.4 branch.

Discussion

[Contracts] remove static cache from ServiceSubscriberTrait

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a

I found an edge case when using this trait on a class that extends a parent class that implements getSubscribedServices(). The issue occurs if the parent dynamically determines the return value of getSubscribedServices() based on something in the child class (in my case, using reflection). It's fine if only one class extends this parent but when multiple do, only the first class registered in the container has the proper services. The next classes have the same as the first because of the static variable.

Commits

d0843be177 [DependencyInjection] remove static cache from ServiceSubscriberTrait

[WebProfilerBundle] Fix AJAX requests info are truncated in the WDT

Merge branch '4.4' into 5.4

  • 4.4: [DependencyInjection] remove static cache from ServiceSubscriberTrait

[PropertyInfo] Fix extracting int range type

[Serializer] Get attributeContext after converting name

[Workflow] Add ZEturf as backer

minor #46531 [Workflow] Add ZEturf as backer (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion

[Workflow] Add ZEturf as backer

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

Commits

7bffa1e056 [Workflow] Add ZEturf as backer

minor #46507 [WebProfilerBundle] Fix AJAX requests info are truncated in the WDT (tucksaun)

This PR was merged into the 4.4 branch.

Discussion

[WebProfilerBundle] Fix AJAX requests info are truncated in the WDT

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #45741?, replaces #46495 ? | License | MIT | Doc PR | n/a

At some point (I guess during the WDT redesign, #15160), something changed making the AJAX request table in the WDT just a little bit larger. This causes the requests to be truncated when the URL is too long:

This PR fixes this by increasing the max-width of the WDT info panel to 525px:

We could reduce the width of the request table to fit in, but 525px seems reasonable enough nowadays and provides more information about the URL.

Commits

a5c2e1d2fb [WebProfilerBundle] Fix AJAX requests info are truncated in the WDT

Merge branch '4.4' into 5.4

  • 4.4: [WebProfilerBundle] Fix AJAX requests info are truncated in the WDT

bug #46515 [PropertyInfo] Fix extracting int range type (norkunas)

This PR was merged into the 5.4 branch.

Discussion

[PropertyInfo] Fix extracting int range type

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

Commits

16dbefa4f2 [PropertyInfo] Fix extracting int range type

[Security] Fix some phpdoc

[Mailer] Sort transports alphabetically

Created at 1 month ago