0xmohit
Repos
62
Followers
15

Events

cmd/ursrv: Attempt to fix js failure to load (#6747)

Following what was said in:

https://support.google.com/maps/thread/44057943?hl=en

lib/model: Fix minor flakiness in TestModTimeWindow

various: Master is now main

Also cleans out various old strings from the translation strings.

build(deps): bump github.com/lucas-clemente/quic-go (#6742)

Bumps github.com/lucas-clemente/quic-go from 0.16.1 to 0.17.1.

Signed-off-by: dependabot-preview[bot] support@dependabot.com

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

lib/connections: Try TCP punchthrough (fixes #4259) (#5753)

lib/scanner, lib/model: Improve error handling when scanning (#6736)

all: Make all error implementations pointer types (#6726)

This matches the convention of the stdlib and avoids ambiguity: when customErr{} and &customErr{} both implement error, client code needs to check for both.

Memory use should remain the same, since storing a non-pointer type in an interface value still copies the value to the heap.

cmd/stdiscosrv: Don't abuse wrong header (#6749)

build: Update integration tests and add to build.go (#6744)

lib/model: Check dir before deletion when pulling (#6741)

gui, man, authors: Update docs, translations, and contributors

lib/db: Use explicit byte type for type prefixes (#6754)

This makes Go 1.15 test/vet happy, avoiding "conversion from untyped int to string yields a string of one rune" warning where we do string(KeyTypeWhatever) in namespaced.go.

It also clarifies and enforces the currently allowed range of these numbers so I think it's fine.

lib/db: Improve error message on meta inconsistency (#6751)

lib/rand: Various minor fixes (#6752)

crypto/rand output is cryptographically secure by the Go library documentation's promise. That, rather than strength (= passes randomness tests) is the property that Syncthing needs).

all: Add copy-on-write filesystem support (fixes #4271) (#6746)

lib: Print nicely rounded durations (#6756)

gui, lib/ignore: Handle editing ignores with error (fixes #5425) (#6757)

This changes the error handling in loading ignores slightly:

  • There is a new ParseError type that is returned as the error (somewhere in the chain) when the problem was not an I/O error loading the file, but some issue with the contents.

  • If the file was read successfully but not parsed successfully we still return the lines read (in addition to nil patterns and a ParseError).

  • In the API, if the error IsParseError then we return a successful HTTP response with the lines and the actual error included in the JSON object.

  • In the GUI, as long as the HTTP call to load the ignores was successful we can edit the ignores. If there was an error we show this as a validation error on the dialog.

Also some cleanup on the Javascript side as it for some reason used jQuery instead of Angular for this editor...

lib/model: Don't stay scanning forever on fail (#6761)

lib/fs: Add support for Windows duplicate extents (#6764)

lib/model: Don't ignore stat failure in performFinish (#6766)

Created at 2 weeks ago

C+A: add Peter Etelej (Individual CLA)

Change-Id: Ifd271510b181b25261cdcd93f75da67d8b16996d

website: mention CoC on community page

Also fix related markdown typo in README.

Change-Id: I90d89e88d00ee2225bea4bd65ce213e729218616

make.go: fixes for building on windows

Replace exeName() with functions runtimeExeName() and buildExeName().

runtimeExeName() returns the executable name on the OS make.go itself is running on.

buildExeName() returns the executable name on the build (target) OS.

Change-Id: I50b17e3991477d7507f4cb4c6f7676190182ddbd

Merge "make.go: fixes for building on windows"

serverinit: add some more comments

Change-Id: Ieddb7d47f2ad0e5873af434e174ca9687d0df6e3

Merge "serverinit: add some more comments"

blobserver/blobpacked: add more debug

For #1068

Change-Id: I4c1210480d869f8d4fb1b53d28d69cc02ad51d72

blobserver/blobpacked: re-validate large integrity after repair

Also:

  • lowercase the SHOUTYCASE log prefix
  • close the meta index on Close (from mpl's CL)

For #1068

Change-Id: I26d9d77338ac850a20d9d631c0424129f6f98fe2

pkg/client: accept verified certificate on android

The android uploader used to only accept a server TLS certificate when its fingerprint was specified as trusted in the client configuration. As a result, certificates obtained by Let's Encrypt (or other CAs, for that matter) were rejected unless treated as self-signed.

With this change, any connection verified by the standard TLS client (using the system's root CA pool) is accepted as long as no additional certificate fingerprint is given.

Closes #974

Change-Id: I499d41e9f48df709dda60724c6f55eca888feeb7

pkg/types/camtypes: more LocationBounds fixes

addresses comments in https://camlistore-review.googlesource.com/c/camlistore/+/10986

Change-Id: I7bb58ab1852d543bb59a4e191f21d17a8eaacad7

blobserver/blobpacked: add new z: meta rows

As discussed in issue #1068, part of the problem with reindexing and then checking the integrity of the index, is that neither b: nor w: meta rows are keyed by the blobRef of the packed blob (the "zipRef").

This can lead, among other things, to reindexing actually erasing all trace of a zipRef as it may have been in the value of a row, that gets subsequently overwritten by a row that has a different value, but an identical key (since e.g. w: rows are keyed by wholeRef).

To address that issue, this change introduces a new kind of meta row, prefixed by z: , which indexes the following information: key: blobref of the zip, prefixed by "z:" value: size of the zip, blobref of the contents of the whole file, size of the whole file, position in the whole file of the data in the zip, size of the data in the zip.

Fixes #1068

Change-Id: Iae61fe823cda0accb22e55ea075407a2b8fd11f8

Merge "blobserver/blobpacked: add new z: meta rows"

server/camlistored/ui: relax requirements for thumber

We actually don't need to know the filename of an image for a valid thumber to be created, so this change is removing such a strict check, which was making foursquare venue photos not be displayed.

Also fix broken initialization of the thumber in foursquare container.

Change-Id: Iefb36fc403a3c1101d83f6af916b447e149f5acf

pkg/importer/gphotos: use "drive" space as "photos" is deprecated

I have not found any doc stating that the photos Space is not supposed to work anymore, but Brad said so in the bug, and some testing seemed to confirm it. So this change switches to using the "drive" Space which contains all files in Google Drive, including the photos from Google Photos, as long as the option to have the Google Photos folder in Drive is enabled.

Fortunately, we can still request the Spaces property of the file, and use that to filter out all of the non-photos files. For now...

Fixes #987

Change-Id: I7f257b70804fd72c730ded158173ec6ae64fde5b

Merge "pkg/importer/gphotos: use "drive" space as "photos" is deprecated"

pkg/client: check client/server version mismatch

Since the search API changed at 2018-01-13-6e8a5930c9fee81640c6c75a9a549fec98064186, a server built before that revision is incompatible with a client built at or after that revision.

This change adds a check that is run when this incompatibility could manifest by a JSON parsing error, in order to clarify the error message.

As a side note, even if there was not this search API breakage, a server built before 27bacd3df17fc004bbec69f1374b6aebb2e838c7 would panic anyway if a client built at or after 38f10a7bd0f97475c2b876a7fde08e4ce47bf224 tried uploading to it. Because of the wrong assumption that br.Hash() is never nil, which can actually happen after sha224 is introduced (client-side), and the server does not know about sha224.

Fixes #1074

Change-Id: I3dabf25c0200625e177e0f26308465cd35e8c750

Merge "pkg/client: check client/server version mismatch"

.gitignore: quit worrying about keys in tests

Since 'dep ensure' now auto-prunes go tests, we don't have to worry about keys in tests anymore.

And as a side-effect: Fixes #1039

Change-Id: I57ab1ffc6a29db8e7ff902ee2515112b1bd7de86

clients/android: show camput error messages

So far, errors in the uploader configuration leading to upload failures are not reported to the user in a meaningful way. The upload process simply stops without further feedback, which is annoying especially when either certificate hash or password are wrong.

This change adds a text widget below the upload stats, reporting camput's stderr output as-is. While not ideal from a usability standpoint (log entries are too wide and too verbose, and not clearly marked as errors), it is better to receive those verbose messages than none at all. The error text widget is cleared when a new upload is started.

Change-Id: I75e79d802cf64981b92c80ce9fc12d2a26552169

vendor: update gopherjs to 82b322028c96512b15077093b16a5f1c7ea897ac

Change-Id: I19128ea01fad41267eaf870e57e799388123c3fb

Created at 2 weeks ago

Merge pull request #8660 from retronym/backport/sbt-bump

[backport] Upgrade 2.12.x build to SBT 1.3.7 [ci: last-only]

Make junit/test pass on JDK 14

Avoid duplicate repl-jline.properties entries in compiler/packageBin

I removed generatePropertiesFileSettings from commonSettings leaving projects that really need to use it to directly add it to the settings. This was already being done (redundatly in some cases) in library, reflect, compiler, partestExtras and partestJavaAgent.

Before this PR (but after the SBT upgrade on 2.12.x branch):

➜  sbt 'show compiler/Compile/packageBin/mappings' | egrep 'repl-jline\.properties'
[info] * (/Users/jz/code/scala-2.12.x-reference/build/quick/classes/repl-jline/repl-jline.properties,repl-jline.properties)
[info] * (/Users/jz/code/scala-2.12.x-reference/build/quick/classes/repl-jline-embedded/repl-jline.properties,repl-jline.properties)

➜  sbt scala
[info] Loading global plugins from /Users/jz/.sbt/1.0/plugins
[info] Loading settings for project scala-2-12-x-reference-build-build from plugins.sbt ...
[info] Loading project definition from /Users/jz/code/scala-2.12.x-reference/project/project
[info] Loading settings for project scala-2-12-x-reference-build from plugins.sbt,build.sbt ...
[info] Loading project definition from /Users/jz/code/scala-2.12.x-reference/project
[info] Loading settings for project root from build.sbt ...
[info] Resolving key references (18230 settings) ...
[error] Could not determine commit date + SHA: org.eclipse.jgit.errors.MissingObjectException: Missing unknown b8c33ad8f1d1238bc03c148854972522f0357f44
[info] *** Welcome to the sbt build definition for Scala! ***
[info] Check README.md for more information.
[error] java.util.zip.ZipException: duplicate entry: repl-jline.properties

After this PR:

fg: no current job
➜  sbt 'show compiler/Compile/packageBin/mappings' | egrep 'repl-jline\.properties'
[info] * (/Users/jz/code/scala-2.12.x-reference/build/quick/classes/repl-jline-embedded/repl-jline.properties,repl-jline.properties)

➜  sbt scala
[info] Loading global plugins from /Users/jz/.sbt/1.0/plugins
[info] Loading settings for project scala-2-12-x-reference-build-build from plugins.sbt ...
[info] Loading project definition from /Users/jz/code/scala-2.12.x-reference/project/project
[info] Loading settings for project scala-2-12-x-reference-build from plugins.sbt,build.sbt ...
[info] Loading project definition from /Users/jz/code/scala-2.12.x-reference/project
[info] Loading settings for project root from build.sbt ...
[info] Resolving key references (18194 settings) ...
[info] *** Welcome to the sbt build definition for Scala! ***
[info] Check README.md for more information.
[info] running (fork) scala.tools.nsc.MainGenericRunner -usejavacp
Welcome to Scala 2.12.11-20200203-035143-5bdfd31 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_221).
Type in expressions for evaluation. Or try :help.

Prior to the SBT upgrade, we also had the duplicate mapping:

sbt 'show compiler/compile:packageBin::mappings' | egrep 'repl-jline\.properties'
[info] * (/Users/jz/code/scala-2.12.x-reference/build/quick/classes/repl-jline/repl-jline.properties,repl-jline.properties)
[info] * (/Users/jz/code/scala-2.12.x-reference/build/quick/classes/repl-jline-embedded/repl-jline.properties,repl-jline.properties)

Merge pull request #8686 from retronym/topic/jdknext-2.12

Make junit/test pass on JDK 14

Merge pull request #8687 from retronym/2.12.x-reference

Avoid duplicate repl-jline.properties entries in compiler/packageBin

Optimise sameLength intersect.

The List.intersect method creates a new list of elements, which in this case was discarded (only the length matters). Since typeParams is to be a list without repetitions, for (A intersect B) to be the same length as B, it needs be that all elements of B are contained in A.

create less objects for zipWithIndex (#8685)

create less objects for zipWithIndex

don't create an IntRef in toArray

Optimise HashSet bulk operations mostly focussed around ++ and union

EmptySet and SetBuilder adjusted to take advantage of ++ optimisation for simple and common cases

eliminate unneeded allocations for HashSets where the result is already built for -    subSet ++ superSet    subSet union superSet    superSet union subSet    superSet ++ subSet

make a fast path when there is structural sharing in the HashSet for union, guarantee internal operations will only return a new HashSet if one of the existing HashSet parameters or internal values cant be used

use System.arraycopy rather than Array.copy as it avoid JVM nulling the array

add missing eq fast path to intersect0 and diff0

minor improvements to + to reduce allocations

reduce calls to HashSet.size which can be a bottleneck

reduce allocations in ListSet ++, + and - no allocations in ++ or + if the data is contained in the original sets

HashSetCollision1 stores its length so as to avoid calls to ListSet.size which is O(n) take advantage of ListSet guarantees on identity for return or + or - where we can avoid calling ListSet.size where we can avoid it

[nomerge] HashMap#transform reuses structure

The keys in the resulting map are the same, so the internal structure will also be the same, and that can be used to avoid allocating tuples and going through MapBuilder and other such convolutions.

Clear my terminal of a pair of unused-import warnings

I thought som-snytt had recently gone on some sort of warning-cleanup mission, but nowadays I can't compile 2.12.x without seeing scala tell me off for these. Well, now I can.

Thoroughly typecheck Java sources for pickling

Unlike .scala files, .java files are named and typed lazily: they will only be analyzed when necessary to typecheck a Scala source. However, under -Ypickle-java, pickler runs over them after typechecking, and can force infos that otherwise wouldn't be forced. If typing the Java source fails, the tree can contain erroneous types and symbols which will then crash pickler as it attempts to write out the pickle.

This patch makes -Ypickle-java eagerly typecheck Java sources during typer, so any errors will be emitted alongside Scala typer errors.

The enclosed test case previously crashed the compiler with a MatchError on ErrorType.

use fast intersect and diff where we can

Merge pull request #8692 from hrhino/topic/pickle-java-crash

Thoroughly typecheck Java sources for pickling

[nomerge] Update to sbt 1.3.8, remove workarounds

Merge pull request #8690 from dwijnand/2.12/update/sbt-1.3.8

[nomerge] Update to sbt 1.3.8, remove workarounds

Merge pull request #8630 from hrhino/topic/hashmap-transform

[nomerge] HashMap#transform reuses structure

fix our Windows Jenkins job (sbt 1.3 upgrade broke it)

fixes scala/scala-dev#666

Merge pull request #8703 from SethTisue/sd-666

fix our Windows Jenkins job (sbt 1.3 upgrade broke it)

add HasForeachEntry

Created at 2 weeks ago

Merge pull request #5285 from coord-e/patch-1

Fix stack installation in alpine

Explain why user should add HOME_LOCAL_BIN to PATH

Part of https://github.com/commercialhaskell/stack/issues/3569

Bump copyright year to 2020

add docker network option (fixes #5121)

Merge pull request #5303 from mrArkwright/5121-docker-network-option

add docker network option (fixes #5121)

Make snapshot locations configurable

Add snapshot-location-base CL option

Do not remove sublibrary information when adding pvp-bounds

This fixes stack sdist broken when using pvp-bounds, see https://github.com/commercialhaskell/stack/issues/5289. This is a regression after https://github.com/commercialhaskell/stack/pull/5156.

When using pvp-bounds we pretty-print an updated package description back to .cabal file. If a set of sublibraries used in a dependency is empty (from cabal-the-library perspective) then instance Pretty Dependency from https://hackage.haskell.org/package/Cabal-3.0.0.0/docs/src/Distribution.Types.Dependency.html#line-58 will just print an empty set there:

build-depends: vector : {} <0.13

This leads to the following error when using stack sdist:

- 46:16:
unexpected Sublibrary dependency syntax used. To use this syntax the package needs to specify at least 'cabal-version: 3.0'. Alternatively, if you are depending on an internal library, you can write directly the library name as it were a package.
expecting space

What we want instead is to use the same sublibrary set as the original dep. I suspect most of the time it's just [LMainLibName], which thanks to instance Pretty Dependency omits the {} in the dependency line and is hence (hopefully) compatible with whatever cabal-version the original .cabal file used.

Merge pull request #5309 from dzhus/fix/pvp-bounds-r1

Do not remove sublibrary information when adding pvp-bounds

Merge pull request #5296 from tomjaguarpaw/patch-1

Explain why user should add HOME_LOCAL_BIN to PATH

Make file watching take targets into account

Resolves #5310

Merge pull request #5317 from qrilka/5310-watch-targets

Make file watching take targets into account

Use target components when starting a REPL

This partially fixes #5213 - starting a repl for an exe component doesn't appear to work for some reason

doc/travis_ci: remove future enhancements" section

It is no longer relevant, since we no longer publish .deb packages.

Merge pull request #5281 from acondolu/pr-snapshots-config

Make snapshot locations configurable

Remove standard Azure CI builds

Start unit tests workflow

Add pedantic

Try doing actual builds

Add Mac and Windows

Created at 2 weeks ago
push

go/parser: remove validation of expression syntax, leave to type checker

Remove the code that verifies that an expression is a type or non-type expression. For one, it cannot be done perfectly accurate (e.g., consider *p which could be an indirection or a pointer type), it also unnecessarily slows down parsing. It's simpler to leave the verification to the type checker which has all the information needed.

Remove short compiler tests that tested the expression/type property. Adjust a couple of go/types tests which now trigger because the parser doesn't complain anymore.

Change file for benchmark from "parser.go" to "../printer/nodes.go" to avoid a moving target when benchmarking.

The parser may be marginally faster when tested on nodes.go:

name old time/op new time/op delta ParseOnly-12 1.35ms ± 0% 1.31ms ± 0% ~ (p=0.100 n=3+3)

name old speed new speed delta ParseOnly-12 39.9MB/s ± 0% 41.0MB/s ± 0% ~ (p=0.100 n=3+3)

For #54511.

Change-Id: I9a32c24c2c6e843c3d1af4587651c352f378b490 Reviewed-on: https://go-review.googlesource.com/c/go/+/425716 Reviewed-by: Robert Griesemer gri@google.com Run-TryBot: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Reviewed-by: Alan Donovan adonovan@google.com Auto-Submit: Robert Griesemer gri@google.com

cmd/compile/internal/syntax: use BadExpr instead of fake CallExpr in bad go/defer

If the go/defer syntax is bad, using a fake CallExpr may produce a follow-on error in the type checker. Instead store a BadExpr in the syntax tree (since an error has already been reported).

Adjust various tests.

For #54511.

Change-Id: Ib2d25f8eab7d5745275188d83d11620cad6ef47c Reviewed-on: https://go-review.googlesource.com/c/go/+/425675 Reviewed-by: Alan Donovan adonovan@google.com TryBot-Result: Gopher Robot gobot@golang.org Run-TryBot: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com Reviewed-by: Robert Griesemer gri@google.com

go/parser: adjustments to error messages

  • Use "expected X" rather then "expecting X".
  • Report a better error when a type argument list is expected.
  • Adjust various tests.

For #54511.

Change-Id: I0c5ca66ecbbdcae1a8f67377682aae6b0b6ab89a Reviewed-on: https://go-review.googlesource.com/c/go/+/425734 TryBot-Result: Gopher Robot gobot@golang.org Reviewed-by: Alan Donovan adonovan@google.com Run-TryBot: Robert Griesemer gri@google.com Reviewed-by: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com

go/types, types2: consolidate testdata/check test files

Use the go/types version of testdata/check tests where the diffs are only in the error positions (the types2 test harness allows for some position tolerance). Consolidate files where there are other minor differences.

Comment out a couple of tests that are different between the two type checkers.

With this CL, the testdata/check files are identical between the two type checkers.

For #54511.

Change-Id: Ibdff2ca3ec9bdaca3aa84029a7883bb83d2d2060 Reviewed-on: https://go-review.googlesource.com/c/go/+/425735 Auto-Submit: Robert Griesemer gri@google.com Reviewed-by: Alan Donovan adonovan@google.com Reviewed-by: Robert Griesemer gri@google.com Run-TryBot: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org

cmd/compile/internal/types2: use go/types/testdata/check tests

Since the check tests are now identical between the two type checkers, remove the local copy of the check tests and (for now) use the tests in go/types/testdata/check instead. Eventually we may decide to move all tests out of the type checker directories and place them in a shared space (e.g. internal/types/testdata).

For #54511.

Change-Id: Id3a97593f6c705c5eda4566089ddc7aeb7b47337 Reviewed-on: https://go-review.googlesource.com/c/go/+/425736 Reviewed-by: Alan Donovan adonovan@google.com TryBot-Result: Gopher Robot gobot@golang.org Run-TryBot: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com Reviewed-by: Robert Griesemer gri@google.com

cmd/compile: avoid "not used" errors due to bad go/defer statements

The syntax for go and defer specifies an arbitrary expression, not a call; the call requirement is spelled out in prose. Don't to the call check in the parser; instead move it to the type checker. This is simpler and also allows the type checker to check expressions that are not calls, and avoid "not used" errors due to such expressions.

We would like to make the same change in go/parser and go/types but the change requires Go/DeferStmt nodes to hold an ast.Expr rather than an *ast.CallExpr. We cannot change that for backward- compatibility reasons. Since we don't test this behavior for the type checkers alone (only for the compiler), we get away with it for now.

Follow-up on CL 425675 which introduced the extra errors in the first place.

Change-Id: I90890b3079d249bdeeb76d5673246ba44bec1a7b Reviewed-on: https://go-review.googlesource.com/c/go/+/425794 Reviewed-by: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Run-TryBot: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com Reviewed-by: Alan Donovan adonovan@google.com

go/parser: check that go/defer expressions are not parenthesized

Logic matches the code in the syntax package. This error was missing from go/parser and go/types. Added some tests.

For #54511.

Change-Id: I418de4bd4c7169457b424366caae70227a92a761 Reviewed-on: https://go-review.googlesource.com/c/go/+/425795 Auto-Submit: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Run-TryBot: Robert Griesemer gri@google.com Reviewed-by: Alan Donovan adonovan@google.com Reviewed-by: Robert Griesemer gri@google.com

go/parser: leave checking of LHS in short var decls to type checker

Instead of checking at parse-time that the LHS of a short variable declaration contains only identifiers, leave the check to the the type checker which tests this already.

This removes a duplicate error and matches the behavior of the syntax package.

For #54511.

Change-Id: I4c68f2bd8a0e015133685f9308beb98e714a83fc Reviewed-on: https://go-review.googlesource.com/c/go/+/426476 Run-TryBot: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Reviewed-by: Robert Findley rfindley@google.com Reviewed-by: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com

types2: use strings.Builder in errors.go

Permissible now because go1.17 is used for bootstrapping.

Change-Id: Ia6f314f9314eda1cc42002dcbdfa551196df76f0 Reviewed-on: https://go-review.googlesource.com/c/go/+/427554 TryBot-Result: Gopher Robot gobot@golang.org Auto-Submit: Robert Griesemer gri@google.com Reviewed-by: Cuong Manh Le cuong.manhle.vn@gmail.com Run-TryBot: Robert Griesemer gri@google.com Reviewed-by: Robert Griesemer gri@google.com Run-TryBot: hopehook hopehook@golangcn.org Reviewed-by: Matthew Dempsky mdempsky@google.com

types2: use strings.Builder in infer.go

Permissible now because go1.17 is used for bootstrapping.

Change-Id: Ic97b0706190c3eb907da69003bc94448c90e5af7 Reviewed-on: https://go-review.googlesource.com/c/go/+/427556 Run-TryBot: Robert Griesemer gri@google.com Run-TryBot: hopehook hopehook@golangcn.org Reviewed-by: Matthew Dempsky mdempsky@google.com Reviewed-by: Cuong Manh Le cuong.manhle.vn@gmail.com Auto-Submit: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Reviewed-by: Robert Griesemer gri@google.com

go/types: use singular in version error messages

This matches the majority use case as well as types2.

For #54511.

Change-Id: If800afc35db8d32cca8329ed9d6a80b4a15c4878 Reviewed-on: https://go-review.googlesource.com/c/go/+/426477 Reviewed-by: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Reviewed-by: Robert Findley rfindley@google.com Run-TryBot: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com

cmd/compile/internal/types2: match go/types error for invalid instantiations

Also: add a missing test.

For #54511.

Change-Id: Ie9828c6ba5186feb5a79db0d58beb2cda2beae56 Reviewed-on: https://go-review.googlesource.com/c/go/+/426478 Reviewed-by: Robert Findley rfindley@google.com Reviewed-by: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com Run-TryBot: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org

go/types, types2: consolidate a test file with different syntax errors

For #54511.

Change-Id: I317c5f9beed7f1de4979ec12c6ec8d5de71bac1c Reviewed-on: https://go-review.googlesource.com/c/go/+/426554 Reviewed-by: Robert Findley rfindley@google.com Run-TryBot: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Reviewed-by: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com

go/parser: parse import specs the same way as the syntax parser

This results in better error recovery and allows us to use the same tests for go/types and types2.

For #54511.

Change-Id: Ic11a9dafb8c62e0cb952b3924d55a28b438241c6 Reviewed-on: https://go-review.googlesource.com/c/go/+/427154 Run-TryBot: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com Reviewed-by: Robert Findley rfindley@google.com TryBot-Result: Gopher Robot gobot@golang.org Reviewed-by: Robert Griesemer gri@google.com

cmd/compile/internal/syntax: more tolerant parsing of import declarations

Change-Id: I114548640d51bf69833259578609901fa1602510 Reviewed-on: https://go-review.googlesource.com/c/go/+/427156 TryBot-Result: Gopher Robot gobot@golang.org Auto-Submit: Robert Griesemer gri@google.com Reviewed-by: Robert Griesemer gri@google.com Reviewed-by: Robert Findley rfindley@google.com Run-TryBot: Robert Griesemer gri@google.com

go/parser: more tolerant parsing of import declarations

This is a port of CL 427156 from the syntax package's parser to go/parser.

While at it, remove an unused token.Pos parameter from parseSpecFunction and dependent declarations.

Also, consolidate the respective test file.

For #54511.

Change-Id: Id6a28eb3d23a46fa5fa1d85d2c4e634b7015513c Reviewed-on: https://go-review.googlesource.com/c/go/+/427157 Run-TryBot: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Reviewed-by: Robert Griesemer gri@google.com Reviewed-by: Robert Findley rfindley@google.com

go/parser: match syntax parser error for unnamed type parameters

For #54511.

Change-Id: I1ae391b5f157bf688f9f31b1577c90e681b6df26 Reviewed-on: https://go-review.googlesource.com/c/go/+/426655 Reviewed-by: Robert Griesemer gri@google.com Run-TryBot: Robert Griesemer gri@google.com Reviewed-by: Robert Findley rfindley@google.com TryBot-Result: Gopher Robot gobot@golang.org Auto-Submit: Robert Griesemer gri@google.com

go/types, types2: consolidate testdata/fixedbugs/issue46404.go

Rename .../issue46404.go1 to .../issue46404.go so that it is not skipped anymore when running tests, and copy for types2.

Disable the code for now due to a difference in error reporting due to the slightly different handling of index expressions. This allows us to make progress with test consolidation.

For #54511.

Change-Id: Ib5c9ffa49b1b24ec680ddb5001bc3dcb1df7eb1f Reviewed-on: https://go-review.googlesource.com/c/go/+/426656 Run-TryBot: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Auto-Submit: Robert Griesemer gri@google.com Reviewed-by: Robert Findley rfindley@google.com Reviewed-by: Robert Griesemer gri@google.com

cmd/compile/internal/syntax: more strict parsing of type instances

Report a syntax error if the first element of a type instance is not actually a type (but some other expression), rather then relying on the type checker error in this case. This matches the behavior of go/parser. Adjust the corresponding types2 test case.

For #54511.

Change-Id: Ia82b3a7d444738c56955ce6c15609470b3431fd1 Reviewed-on: https://go-review.googlesource.com/c/go/+/426657 Reviewed-by: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com Run-TryBot: Robert Griesemer gri@google.com Reviewed-by: Robert Findley rfindley@google.com TryBot-Result: Gopher Robot gobot@golang.org

go/types, types2: consolidate testdata/fixedbugs test files

Use the go/types version of testdata/fixedbugs tests where diffs are only in the error positions (the types2 test harness allows for some position tolerance). Consolidate files where there are other minor differences.

Add files to respective directories if they only existed for one of the type checkers.

Move types2-only test issue47996.go out of testdata/fixedbugs into testdata. Making it work for both type checkers requires some more work.

With this CL, the testdata/fixedbugs files are identical between the two type checkers.

For #54511.

Change-Id: I0d67f0db75ad1743c62da9181a6d0032c8bdb728 Reviewed-on: https://go-review.googlesource.com/c/go/+/427236 Reviewed-by: Robert Griesemer gri@google.com TryBot-Result: Gopher Robot gobot@golang.org Run-TryBot: Robert Griesemer gri@google.com Auto-Submit: Robert Griesemer gri@google.com Reviewed-by: Robert Findley rfindley@google.com

Created at 2 weeks ago

Speed up man page generation

by a factor of 3 Without this patch, using make -j built every man page and html page 25 times

Now, man pages are always generated in a single ronn call after all .ronn files are made.

Workarounds GNU make bug https://savannah.gnu.org/bugs/?54854

Provide correct instructions to build github/hub

See #1404, closes #1929 [ci skip]

Update contributing docs regardig working with a local checkout

[ci skip]

Fix link to README

[ci skip]

Expand tokens found in ssh config HostName

Per "TOKENS" section in ssh_config(5)

Fixes #1936

Allow specifying a literal %h in HostName ssh config

Fix test that failed without a local git checkout

Fixes #1937

Make the utility file during make man-pages hidden

Merge branch 'make'

add pullrequest vim syntax. #1916

Enable hub to work with github.localhost

Update the OAuth app url

Add additional test for ssh.github.com support

Clarify documentation about what constitutes a title in --message

It's not only the first line of text; it's the entire first "block" (or paragraph) of text with newlines turned into spaces. This is for compatibility with git-commit(1).

Add test for multiline title handling

Add support for passing multiple --message options

This is for compatibility with git-commit(1)

Fix test broken by OAuth URL update

Merge pull request #1951 from github/multiline-message

Add support for multiple --message options

Merge branch 'localhost'

Docs: mention that comma-separated lists must not have spaces

This was tripping me up for so long. I eventually discovered the problem was my spaces, re. https://github.com/github/hub/issues/1287#issuecomment-250454584.

Created at 2 weeks ago

sql: show hash shared check constraint if set NOT VALID

inspired by https://github.com/cockroachdb/cockroach/issues/89012

If check constraints that accompanies hash shared index are accidentally set NOT VALID, it should show up in the SHOW CREATE TABLE's output.

Release note (sql change): show hash shared check constraint in SHOW CREATE TABLEif it is set NOT VALID

Merge #89690

89690: lint: Add URL support and "part of" support to epic/issue ref linter r=nickvigilante a=nickvigilante

Many contributors use full URLs to reference GitHub issues within the PR bodies and commits. Additionally, contributors will use "part of" in their PR bodies and commits to denote that an issue is related to the specific PR.

This PR adds support for these two scenarios in the linter.

part of https://github.com/cockroachdb/cockroach/issues/89684 part of https://github.com/cockroachdb/cockroach/issues/89685

Release note: None

Co-authored-by: Nick Vigilante vigilante@cockroachlabs.com

go.mod: update to go 1.18

We use Go 1.19 to compile CRDB right now, but go.mod has been pinned to 1.17. Here, update to 1.18 to get us a little closer to being up-to-date.

Release note: None

sql: avoid some overhead due to error construction on common paths

These paths amount for about .5% of CPU time and almost as much in terms of allocated objects in tpcc.

Release note: None

Merge #89702

89702: go.mod: update to go 1.18 r=knz a=rickystewart

We use Go 1.19 to compile CRDB right now, but go.mod has been pinned to 1.17. Here, update to 1.18 to get us a little closer to being up-to-date.

Release note: None

Co-authored-by: Ricky Stewart ricky@cockroachlabs.com

Merge #89691

89691: sql: avoid some overhead due to error construction on common paths r=ajwerner a=ajwerner

These paths amount for about .5% of CPU time and almost as much in terms of allocated objects in tpcc.

Epic: None

Release note: None

Co-authored-by: Andrew Werner awerner32@gmail.com

Merge #89235

89235: sql: don't cache uncommitted privileges r=rafiss a=RichardJCai

Release note (sql change): Previously, uncommitted privileges could be cached if the txn is rolled back. This is now fixed. This has not made it into GA and is a GA blocker. Example:

BEGIN;
GRANT SELECT ON crdb_internal.tables TO testuser;
SELECT has_table_privilege('testuser', 'crdb_internal.tables', 'SELECT'); --- this caches the privilege ---
ROLLBACK;
--- SELECT IS STILL CACHED UNTIL ANOTHER GRANT/REVOKE HAPPENS TO INVALIDATE THE CACHE---

Fixes: #89001

Co-authored-by: richardjcai caioftherichard@gmail.com

licenses: update licenses for 22.2

This PR updates license files for the 22.2 release, which will be backported to release-22.2.0 and release.22.2.x.

This commit adds licenses for any new packages used in 22.2, using the following rules:

  • For BSD licenses: the name of the copyright holder appears in the text of the license itself, so we've copied their BSD license into the license/ folder
  • For all other licenses: we are using the generic license text.

Notes:

  • The update to the BSL license, which should not be backported to 22.2, will happen in a separate commit.

Release justification: non-production code change (add licenses for 22.2). Release note: None.

Merge #89167

89167: batcheval: set default AddSSTable SST rewrite concurrency to 4 r=erikgrinaker a=erikgrinaker

@dt Uhm, looks like we never enabled the optimized SST rewriter by default. Frankly not sure how we missed that. I think we should flip it before we ship 22.2, wdyt?


This has higher constant costs, and is thus slower for small SSTs, but is significantly faster for large ones.

name                                   old time/op    new time/op     delta
UpdateSSTTimestamps/numKeys=1-24          132µs ± 1%      313µs ± 1%  +138.25%  (p=0.008 n=5+5)
UpdateSSTTimestamps/numKeys=10-24         138µs ± 2%      319µs ± 1%  +130.96%  (p=0.008 n=5+5)
UpdateSSTTimestamps/numKeys=100-24        174µs ± 4%      383µs ± 1%  +120.64%  (p=0.008 n=5+5)
UpdateSSTTimestamps/numKeys=1000-24       467µs ± 1%      868µs ± 2%   +85.95%  (p=0.008 n=5+5)
UpdateSSTTimestamps/numKeys=10000-24     3.38ms ± 0%     2.30ms ± 1%   -32.05%  (p=0.008 n=5+5)
UpdateSSTTimestamps/numKeys=100000-24    32.6ms ± 1%      7.2ms ± 3%   -77.80%  (p=0.008 n=5+5)

Resolves #89646.

Release note: None

Co-authored-by: Erik Grinaker grinaker@cockroachlabs.com

Merge #89225

89225: rewrite: rewrite UniqueWithoutIndexConstraint on restore r=ajwerner a=adityamaru

If a table with UniqueWithoutIndexConstraint is captured as part of the backup, then on restore the tableIDs in the UniqueWithoutIndexConstraint slice on the table descriptor need to be remapped to the new tableIDs that will be assigned to the descriptors post restore.

Fixes: #88860

Release note (bug fix): Restoring a backup with a table containing UniqueWithoutIndexConstraints would fail because of incorrect tableIDs being referenced in the constraints stored on the restored tabl

Co-authored-by: adityamaru adityamaru@gmail.com

roachtest: roachtest testing gc functionaltiy

Previously there were no roachtest that verified mvcc GC functionality. This commit adds a GC roachtest with an emphasis on range tombstone processing. This is a new area and involves feature flags and optional handling. Integration tests will ensure component wiring works as expected.

Release note: None

Merge #88972 #89517

88972: metrics: compute InternalIntervalMetrics without making calls to GetInternalIntervalMetrics r=coolcom200 a=coolcom200

Remove dependence on the GetInternalIntervalMetrics as this method resets the interval following each call. This results in issues if two clients interact with GetInternalIntervalMetrics as they will reset the other client’s interval. Ex: Client A calls every 5 seconds and Client B calls every 10 seconds. Client B will end up getting metrics at a 5-second interval since GetInternalIntervalMetrics resets the interval on each call.

The admission.StoreMetrics are updated to remove the InternalIntervalField as these metrics need to be computed based off the current metrics admission.StoreMetrics.Metrics and the previous metrics. The storage of the previous metrics is left up to the client. Removing the field was chosen instead of setting it to a nil value as it would be confusing to return the StoreMetrics and require the client to populate the field when they compute the necessary metrics.

For the admission control use case, the flush metrics are computed as part of ioLoadListener.adjustTokens with the previous metrics being initialized in ioLoadListener.pebbleMetricsTick and stored on the ioLoadListenerState as cumFlushWriteThroughput.

Additionally, make a copy of the pebble.InternalIntervalMetrics in order to move away from using the pebble version of the interval metrics as these metrics are now the responsibility of the caller to compute.

Release note: None Epic: CRDB-17515

89517: sql: show hash check constraints if set NOT VALID r=ajwerner a=ZhouXing19

If check constraints that accompanies hash shared index are accidentally set NOT VALID, it should show up in the SHOW CREATE TABLE's output.

Informs: #89012

Release note (sql change): show hash shared check constraint in SHOW CREATE TABLEif it is set NOT VALID

Co-authored-by: Leon Fattakhov leon.fattakhov@cockroachlabs.com Co-authored-by: Jane Xing zhouxing@uchicago.edu

builtins: add explicit type for argument to GenerateuUniqueInt

The argument used to be a base.SQLInstanceID. In some cases, we were casting to that type in order to call that function. This seems misleading. In fact, the function just needs some integer which is unique to this process in the cluster in order to achieve its goals. We add a new type ProcessUniqueID to which we can cast IDs like SQLInstanceID and NodeID without having to think too hard.

Release note: None

kvserver: refactor rangelog code in anticipation of extraction

This introduces a new interface and some logic to extract the implementation.

Release note: None

server,kvserver/rangelog: extract implementation of rangelog writer

Release note: None

kvserver/rangelog: provide IDs from clients, add testing

This commit is primarily about building out testing infrastructure for the rangelog package. It does that by taking real rangelog data, encoding it as protobuf for cross-version compatibility, and then making sure it round-trips. These tools will be useful to validate an alternative implementation of the interface.

Release note: None

kvserver/rangelog: switch implementation to use raw KVs

This commit swaps out the old internal executor based implementation with one which hard-codes its understanding of the rangelog table and uses the KV API directly.

Release note: None

Merge #89515

89515: cluster-ui: correct comment in insightsApi r=THardy98 a=THardy98

Nit change to correct a comment in insightsApi that mentioned a query from crdb_internal.cluster_contention_events, when it intended to mention crdb_internal.transaction_contention_events.

Release note: None

Co-authored-by: Thomas Hardy thardy@cockroachlabs.com

Merge #88956 #89331

88956: keys: refactor PrettyPrint function to use safeFormatInternal r=Santamaura a=Santamaura

Previously the PrettyPrint function called the prettyPrintInternal function which had similar logic to safeFormatInternal. This patch modifies safeFormatInternal such that PrettyPrint can use it and prettyPrintInternal has been removed. As part of this refactor, all ppFunc functions have been updated to return redact.RedactableString. Changes from https://github.com/cockroachdb/cockroach/pull/87952 are also included.

Resolves https://github.com/cockroachdb/cockroach/issues/88060

Release note: None

89331: server: Thread storeID through stickyInMemEngine r=nicktrav a=itsbilal

The stickyInMemEngine that's used by the test cluster as well as by cockroach demo did not implement the SetStoreID call implemented in storage.Pebble. This change implements that to bring about store IDs in log entries emitted by demo/test clusters.

Fixes #72701.

Release note: None

Co-authored-by: Alex Barganier abarganier@cockroachlabs.com Co-authored-by: Bilal Akhtar bilal@cockroachlabs.com

sql/catalog/resolver: add a benchmark for ResolveFunction

Release note: None

Created at 2 weeks ago

fix kafka sample, the yaml should indent spaces in TLS KafkaSource sa… (#3327)

  • fix kafka sample, the yaml should indent spaces in TLS KafkaSource samples

Change-Id: If3ef1dcf85b643a00468f5bdd06b9b9e0931fd46

  • fix kafka sample, the yaml should indent spaces in TLS KafkaSource samples

Change-Id: If3ef1dcf85b643a00468f5bdd06b9b9e0931fd46

Add Subscription docs with kn commands (#3306)

  • Add Subscription docs with kn commands

  • cleaned up fluff, fixed links

  • peer review update

  • SME review updates

Change some numbered steps to sub-headings (#3329)

  • Change some numbered steps to sub-headings

Per https://github.com/knative/docs/issues/3018, change numbered steps containing mini-procedures into sub-headings.

  • Update docs/install/any-kubernetes-cluster.md

Co-authored-by: Samia Nneji snneji@vmware.com

  • Update docs/install/any-kubernetes-cluster.md

Co-authored-by: Samia Nneji snneji@vmware.com

  • Update docs/install/any-kubernetes-cluster.md

Co-authored-by: Samia Nneji snneji@vmware.com

  • Added stems below headers

Accessibility: apparently stem sentences/fragments below headers make docs read better in screen readers.

  • Removed trailing whitespace

  • Stated which mini-procedures are optional

Co-authored-by: Samia Nneji snneji@vmware.com

Drop unnecessary occurrences of master (#3333)

New blog template and update doc template (#3341)

  • New blog template/instructions

  • update and sync with new blog template

  • edits

  • add the copy section

  • fix formatting

  • update links for both templates

  • Add links to new content templates in PR template

  • typo

  • whitespace

  • more whitespace

  • and even more whitespace

  • trailing whitespace

  • whitespace

  • between

Fix obsolete links in Debugging guide (#3343)

Fixed comments and moved verification step (#3347)

Update Rust version and installation commands (#3314)

Update Dart example for latest stable SDK (#3340)

Add a note on replication factor value (#3348)

  • Add a note on replication factor value

We've got a bug [1] report for a misconfiguration of default.topic.replication.factor. This PR adds a note that could alert users on the value of this configuration.

[1] https://github.com/knative-sandbox/eventing-kafka-broker/issues/720

  • Update docs/eventing/broker/kafka-broker.md

Co-authored-by: Ashleigh Brennan 40172997+abrennan89@users.noreply.github.com

Co-authored-by: Ashleigh Brennan 40172997+abrennan89@users.noreply.github.com

Removed the Go code link (#3318)

Update OWNERS_ALIASES (#3281)

Adding new tech writers as reviewers :D

Removed the Go path link from the ./eventing/sources/_index.md (#3324)

  • Removed the Go link

  • Added path

  • Added the correct path

  • Added minor changes

  • Added minor changes

  • Added minor changes with keeping .md extenstion

Update knative-offerings.md (#3358)

Removed PCF Functions since it no longer exists

Added examples of kn usage for the Scala sample app (#2895)

Add documentation on how to use OpenTelemetry +collector (#3005)

  • Add documentation on how to use opentelemetry collector with prometheus for serving.

Signed-off-by: Evan Anderson evan.k.anderson@gmail.com

  • Add cert-manager to otel install instructions

  • Update to remove operators

  • Fix prometheus/otel typos, add rule examples.

  • Convert to _index.md, address @skonto comments

Removed the Go path link from the ./eventing/event-delivery.md (#3321)

  • Removed the Go link

  • Added the yaml file

  • Added the yaml file

Removed the Go path link from the ./eventing/debugging/README.md (#3323)

  • Removed the Go link

  • Added path for ApiServerSource

  • Added the correct path

  • Updated with the new path

  • Updated with the new path

Add events to Cloud Run for Anthos description (#3026)

  • Add events to Cloud Run for Anthos description

  • Update docs/knative-offerings.md

Co-authored-by: Ashleigh Brennan 40172997+abrennan89@users.noreply.github.com

Run github.com/client9/misspell (#3342)

Signed-off-by: Knative Automation automation@knative.team

Created at 2 weeks ago

b2: support use of non-master application keys

Adding a stow adapter to work with remote filesystems via sftp

sftp: add support for a base path that isn't the user's home dir

GP-1873: b2: support ranged download requests

adding go module support

GP-2121: remove deleted buckets from list buckets results if the region determination shows they no longer exist

local: fix dropped error

local: close after error check

Added logic to not fetch the region if specified

Merge pull request #235 from marbergq/feature/disable-bucket-location-lookup

Do not fetch the region if region is already specified

GCP Update

Updated the APIs and added OpenRange

Merge pull request #248 from graymeta/GCP-Update

GCP Update

Created at 2 weeks ago

xds: not cancel and restart RDS watch on the same LDS update (#3619)

internal: update rls.pb.go (#3637)

xds: rename subBalancerWithConfig to subBalancerWrapper (#3608)

credentials/alts: Fix ALTS record crypto interface comments (#3638)

transport: move append of header and data down to http2 write loop to save garbage (#3568)

xds: handle weighted cluster as route action (#3613)

grpclb, dns: pass balancer addresses via resolver.State (#3614)

internal: fix errors after merging (#3643)

xds: eds balancer handleEDSUpdate cleanup (#3639)

xds: move balancer/resolver registation to package xds (#3640)

cmd/protoc-gen-go-grpc: add code generator (#3453)

xds: handle errors in eds balancer (#3645)

doc: fix quickstart hyperlink in README (#3648)

all: regenerate .pb.go files using cmd/protoc-gen-go-grpc (#3646)

Change regenerate.sh to use cmd/protoc-gen-go-grpc and rerun it. This splits the gRPC service definitions into separate files, but otherwise has no changes.

xds: handle errors in cds balancer (#3649)

credentials/local: fix incorrect binding of listener port (#3656)

xds: handle errors in xds resolver (#3651)

xds: handle errors in xds_client (#3658)

  • xds_client

    • send resource-not-found error when a resource is removed for LDS or CDS
    • handle LDS resource-not-found to cancel RDS watch
  • test update because it was expecting no update when resource is removed

  • test cleanup to apply timeout to channels

protoc-gen-go-grpc: add requirement of embedding UnimplementedServer in services (#3657)

advancedtls: check error before deferring close (#3659)

Created at 2 weeks ago

Improvements to corrupt payload sanitization (#9321)

Recently we found two issues in the fuzzer tester: #9302 #9285 After fixing them, more problems surfaced and this PR (as well as #9297) aims to fix them.

Here's a list of the fixes

  • Prevent an overflow when allocating a dict hashtable
  • Prevent OOM when attempting to allocate a huge string
  • Prevent a few invalid accesses in listpack
  • Improve sanitization of listpack first entry
  • Validate integrity of stream consumer groups PEL
  • Validate integrity of stream listpack entry IDs
  • Validate ziplist tail followed by extra data which start with 0xff

Co-authored-by: sundb sundbcn@gmail.com

corrupt-dump-fuzzer test, avoid creating junk keys (#9302)

The execution of the RPOPLPUSH command by the fuzzer created junk keys, that were later being selected by RANDOMKEY and modified. This also meant that lists were statistically tested more than other files.

Fix the fuzzer not to pass junk key names to RPOPLPUSH, and add a check that detects that new keys are not added by the fuzzer to detect future similar issues.

Ignore resize threshold on idle qbuf resizing (#9322)

Also update qbuf tests to verify both idle and peak based resizing logic. And delete unused function: getClientsMaxBuffers

[BUGFIX] Add some missed error statistics (#9328)

add error counting for some missed behaviors.

Fix the wrong method used in quicklistTest. (#8951)

The test try to test insert before 1 element, but it use quicklist InsertAfter, a copy-paste typo.

The commit also add an assert to verify results in some tests to make sure it is as expected.

sds.c: Fix potential overflow in sdsll2str. (#8910)

Fixes an undefined behavior, same way as our ll2string does.

Propagate OPENSSL_PREFIX to hiredis. (#9345)

Allow master to replicate command longer than replica's query buffer limit (#9340)

Replication client no longer checks incoming command length against the client-query-buffer-limit. This makes the master able to replicate commands longer than replica's configured client-query-buffer-limit

Add SORT_RO command (#9299)

Add a readonly variant of the STORE command, so it can be used on read-only workloads (replica, ACL, etc)

Cleanup: createAOFClient uses createClient to avoid overlooked mismatches (#9338)

AOF fake client creation (createAOFClient) was doing similar work as createClient, with some minor differences, most of which unintended, this was dangerous and meant that many changes to createClient should have always been reflected to aof.c

This cleanup changes createAOFClient to call createClient with NULL, like we do in module.c and elsewhere.

Sanitize dump payload: handle remaining empty key when RDB loading and restore command (#9349)

This commit mainly fixes empty keys due to RDB loading and restore command, which was omitted in #9297.

  1. When loading quicklsit, if all the ziplists in the quicklist are empty, NULL will be returned. If only some of the ziplists are empty, then we will skip the empty ziplists silently.
  2. When loading hash zipmap, if zipmap is empty, sanitization check will fail.
  3. When loading hash ziplist, if ziplist is empty, NULL will be returned.
  4. Add RDB loading test with sanitize.

Replace all usage of ziplist with listpack for t_hash (#8887)

Part one of implementing #8702 (taking hashes first before other types)

Description of the feature

  1. Change ziplist encoded hash objects to listpack encoding.
  2. Convert existing ziplists on RDB loading time. an O(n) operation.

Rdb format changes

  1. Add RDB_TYPE_HASH_LISTPACK rdb type.
  2. Bump RDB_VERSION to 10

Interface changes

  1. New hash-max-listpack-entries config is an alias for hash-max-ziplist-entries (same with hash-max-listpack-value)
  2. OBJECT ENCODING will return listpack instead of ziplist

Listpack improvements:

  1. Support direct insert, replace integer element (rather than convert back and forth from string)
  2. Add more listpack capabilities to match the ziplist ones (like lpFind, lpRandomPairs and such)
  3. Optimize element length fetching, avoid multiple calculations
  4. Use inline to avoid function call overhead.

Tests

  1. Add a new test to the RDB load time conversion
  2. Adding the listpack unit tests. (based on the one in ziplist.c)
  3. Add a few "corrupt payload: fuzzer findings" tests, and slightly modify existing ones.

Co-authored-by: Oran Agra oran@redislabs.com

Format fixes and naming. SentReplyOnKeyMiss -> addReplyOrErrorObject (#9346)

Following the comments on #8659, this PR fix some formatting and naming issues.

fix a compilation error around madvise when make with jemalloc on MacOS (#9350)

We only use MADV_DONTNEED on Linux, that's were it was tested.

support regex in "--only" in runtest (#9352)

Redis-cli monitor and pubsub can be aborted with Ctrl+C, keeping the cli alive (#9347)

Abort cli blocking modes with SIGINT without exiting the cli.

Co-authored-by: charsyam charsyam@gmail.com

Fix missing dismiss hash listpack memory due to ziplist->listpack migration (#9353)

Add debian:oldoldstable build target for CI. (#9358)

Making sure Redis builds properly on older compiler is important given the wide range of systems it is built for. So far Ubuntu 16.04 has been used for this purpose, but as it's getting phased out we'll move to oldoldstable Debian as an "old system" precursor.

Improve setup operations order after fork. (#9365)

The order of setting things up follows some reasoning: Setup signal handlers first because a signal could fire at any time. Adjust OOM score before everything else to assist the OOM killer if memory resources are low.

The trigger for this is a valgrind test failure which resulted with the child catching a SIGUSR1 before initializing the handler.

Update cluster debug log to include human readable packet type (#9361)

Created at 2 weeks ago

testserver: fix updated proxy arguments

Merge pull request #107 from cockroachdb/fix-testserver-proxy-update

testserver: fix updated proxy arguments

Remove PGURL nil check from testserver docs

NewTestServer performs the check so it is redundant.

Merge pull request #105 from 0xmohit/docs

Remove PGURL nil check from testserver docs

Migrate to GitHub Actions

  • Use currently supported Go versions only
  • Added "build" to verify it builds correctly
  • golint and megacheck are deprecated. Dropped in favour of go tool vet and staticcheck.
  • Minor changes to make sure some checks pass

Merge pull request #114 from rail/github-actions

Migrate to GitHub Actions

add support for --store=type=mem,size=val when start a server

This commit sets --store=type=mem (storing database in memory) as the default option for storage. We also allow users to customize the proportion of available memory allocated to the test server.

Merge pull request #108 from ZhouXing19/use-mem-store-080421

add support for --store=type=mem when start a server

make Start() to a no-op if testserver is started

Resolves #103 and #98.

This commit is to ensure that when testserver is already started, calling ts.Start() is a no-op.

Merge branch 'master' into fix-Start

Merge pull request #111 from ZhouXing19/fix-Start

Make Start() to a no-op if testserver is started

Add README for testserver

Merge pull request #116 from ZhouXing19/add-readme-testserver

Add README for testserver

Redownload CRDB if previous download got killed in the middle

Resolve #102

This commit is to add a flock to the local file when downloading CRDB binary. If such localfile exists but can be flocked, it means the previous download process was killed before it finished. In this case, remove the existing local file and redownload CRDB binary.

Redownload CRDB if previous download got killed in the middle

Redownload CRDB if previous download got killed in the middle

testserver: improve the error trace

Wrapped errors from NewTestServerand NewTenantServer. Also improved logging for better error trace by adding "cockroach-go testserver:" or cockroach-go tenantserver: at the beginning of log messages.

README,crdb: update documentation

Add a link to the pkg.go.dev documentation in the README. Also, fix the formatting on a couple comments. The indentation of 'library' caused godoc/pkg.go.dev to present the line as a code block.

Merge pull request #117 from jbowens/jackson/doc-updates

README,crdb: update documentation

support downloading the latest stable version of CRDB

resolves #83

This commit sets the default mode for database downloads to "Download the latest stable version of CRDB".

We get the latest stable version through https://register.cockroachdb.com/api/updates, and save it to a local file with cockroach-majorv-minorv-patch naming pattern in the tmp directory. The downloading is OS-specific.

Problem unsolved: the tenant tests with proxy always fail with stable CRDB, but pass with latest non-stable CRDB.

testserver: add more informative error and log messages

Created at 2 weeks ago

update link for ZBar

Quoting from the README at the new link:

As its development stopped in 2012, I took the task of keeping it updated with the V4L2 API. This is the main repository for it.

Add Nix flake

Resolve some shellcheck warnings

Add Github workflow

flake: Add derivation for pass with local otp build

Handle -c/--clip in cmd_otp_uri

Update sharness

Handle otpauth:// URIs with port numbers

README.md: Add example use of wl-clipboard to get QR from clip

Created at 2 weeks ago

switch go-oauth2 to v4 and updates deps

switch example to oauth2/v4

set domain of go-oauth2/oauth2 same as service URL

Update auth.go

Typo in error message

Update auth_test.go

Oops, forgot about test update, sorry @umputun

Fixed mistake in syntax and updated link

get rid of errors package in favour of fmt

bump deps

missing go tidy

revert mongo driver to 1.8.5

fix wrong error returned

sanitize both user and address in verified provider

limit max len of sanitized user/address to 128

sanitize site as well, just in case

lint: ReplaceAll instead of Replace

replace text/template with html/template

prevent escaping of query in dev provider

fix linter-reported errors

lint: suppress on query templ

Custom dev host (#125)

  • add ability to change dev oauth2 host

  • fix test

  • drop host and port dev setters, too late to set here

  • bump bluemonday

  • fix NewDev function default hostname

Co-authored-by: Dmitry Verkhoturov paskal.07@gmail.com

Created at 2 weeks ago

Add tips to url-migration docs

fix frontend documentation typo

bump auth module

Follow-up for https://github.com/go-pkgz/auth/pull/107

add proper default values for two boolean variables

Fix typo in index.md

The text in the backend development section should be backend instead of frontend

remove explicit /srv/ usage from docker-compose files

We have plenty of paths used in the application, but two of them are hardcoded in examples all over the code for historical reasons.

I found that by default in Docker, the path would resolve to the value we are setting it explicitly to, so it doesn't make sense to set a few variables we are setting now explicitly.

Add telegram auth to frontend

fix tests

update tg icon

Fix function name

Get rid of isTelegramShown state

Switch QR to backend rendering

Bump nanoid from 3.1.23 to 3.2.0 in /frontend

Bumps nanoid from 3.1.23 to 3.2.0.


updated-dependencies:

  • dependency-name: nanoid dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Bump nanoid from 3.1.23 to 3.2.0 in /frontend

Bumps nanoid from 3.1.23 to 3.2.0.


updated-dependencies:

  • dependency-name: nanoid dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

telegram adjustments and tests

  • get rid of redux store in favor of local state
  • add tests for telegram happy path
  • lift auth handling on Auth level

move error hook to hooks file

simplify click outside

bump Go modules

Merge pull request #1107 from Ksinia/master

Add telegram auth to frontend

return 200 and empty list on user comments if nothing #1265

Created at 2 weeks ago

don't assume uname in /usr/bin/ (#117)

uname exists in /bin on Ubuntu. As such, the installation fails.

The script determines the OS without specifying the complete path to uname. Do the same in order to determine ARCH.

Update module golang.org/x/sync to v0.1.0 (#116)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update module github.com/urfave/cli/v2 to v2.23.0 (#115)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update module github.com/urfave/cli/v2 to v2.23.2 (#118)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update module github.com/urfave/cli/v2 to v2.23.4 (#119)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update protocol and server-sdk-go (#122)

Version 1.2.2 (#123)

Example create-ingress JSON file (#126)

Update module github.com/urfave/cli/v2 to v2.23.5 (#124)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Created at 2 weeks ago

don't assume uname in /usr/bin/ (#1138)

uname exists in /bin on Ubuntu. As such, the installation fails.

The script determines the OS without specifying the complete path to uname. Do the same in order to determine ARCH.

Update module golang.org/x/sync to v0.1.0 (#1136)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update module github.com/urfave/cli/v2 to v2.23.0 (#1133)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Add red encoding for opus only publisher (#1137)

  • Add red encodings for opus only publisher

  • Add test case for red receiver

Recover lost packet from red encoding for opus only client (#1139)

  • Recover lost packet from red encoding for opus only client

Avoid divide-by-zero (#1141)

revert canclose method of red receivers (#1142)

Update module github.com/urfave/cli/v2 to v2.23.2 (#1144)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update module github.com/prometheus/client_golang to v1.13.1 (#1140)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update module github.com/urfave/cli/v2 to v2.23.4 (#1145)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Make sure client get participant info before track fired (#1147)

Set track level codec settings for all pending tracks (#1148)

Use the redis.UniversalClient interface instead of *redis.Client when interacting with go-redis (#1149)

  • Use the redis.UniversalClient interface instead of *redis.Client when interacting with go-redis

  • Update protocol to v1.2.1

RedisStore: make UnlockRoom atomic (#1044)

Co-authored-by: David Zhao dz@livekit.io

Update module github.com/prometheus/client_golang to v1.14.0 (#1151)

Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Version 1.3.0 (#1152)

Co-authored-by: David Zhao dz@livekit.io

Fix YAML failure when logging config is declared (#1154)

  • Fix YAML failure when logging config is declared

  • version bump

CreateRoom API to actually create the room on an RTC node (#1155)

Previously, CreateRoom only created the room in storage, but did not hydrate it on an RTC node. This has caused strange behaviors such as emptyTimeout not working correctly (#1109).

Also reduced room reap worker to consistently reap rooms. Fixes #241

Confirm room creation prior to returning from CreateRoom (#1157)

Demote some stable logs to Debugw (#1158)

  • Demote some stable logs to Debugw

  • Add 'discard message from' to ignore list

Created at 2 weeks ago

update to Go 1.19.1

Autofix: upgrade-lang-node (#936)

Co-authored-by: Autofix autofix-bot@users.noreply.github.com

refactor: python_hook.bash (#928)

  • refactor: python_hook.bash

  • trap EXIT as well

update go to v1.19.1

bump go version to 1.19.2 and 1.18.7

feat: bump rust to 1.64

fix: package manager bugs for Node.js (#907)

  • fix: pacakge manager setup for Node.js

  • Use npm to install global deps and maintain consistency with nvm

Co-authored-by: Kyle Brennan kylos101@gmail.com

chore(deps): update google-github-actions/auth action to v0.8.2 (#950)

install missing staticcheck (#947)

Copy images using OCI manifests (#951)

chore(deps): update google-github-actions/setup-gcloud action to v0.6.1 (#952)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update brew layer

To get the latest available versions of packages.

chore(deps): update google-github-actions/auth action to v0.8.3 (#954)

Autofix: upgrade-lang-node

Fix tailscale ssh

Related to https://github.com/gitpod-io/website/pull/2908

docs: add architecture info & dockerhub url (#910)

  • docs: add architecture info & dockerhub url

  • chore: new docs path refs

  • fix: linting errors

Signed-off-by: Siddhant Khare siddhant@gitpod.io

  • add docs references

Co-authored-by: Thomas Schubart 24721048+Furisto@users.noreply.github.com

  • lint error fixes

  • Update README.md

Co-authored-by: Thomas Schubart 24721048+Furisto@users.noreply.github.com

  • Update README.md

  • nit-fix

  • Disable line length lint

Signed-off-by: Siddhant Khare siddhant@gitpod.io Co-authored-by: Thomas Schubart 24721048+Furisto@users.noreply.github.com Co-authored-by: Thomas Schubart thomas@gitpod.io

Adjust the config of markdownlint to reality (#961)

Autofix: upgrade-lang-node (#964)

Co-authored-by: Autofix autofix-bot@users.noreply.github.com

Autofix: upgrade-lang-java (#962)

Co-authored-by: Autofix autofix-bot@users.noreply.github.com

feat: update composer to 2.4.4

Created at 2 weeks ago
delete branch
0xmohit delete branch upgrade-go
Created at 2 weeks ago
pull request opened
update Go to 1.19.3 and 1.18.8

Description

Related Issue(s)

Fixes #

How to test

Release Notes

Documentation

Created at 2 weeks ago
create branch
0xmohit create branch upgrade-go
Created at 2 weeks ago
pull request opened
update instructions to install development version

Starting Go 1.18, go get no longer builds packages. go install must be used to install a module.

Created at 3 weeks ago

update instructions to install development version

Starting Go 1.18, go get no longer builds packages. go install must be used to install a module.

Created at 3 weeks ago
Created at 3 weeks ago
delete branch
0xmohit delete branch patch-1
Created at 3 weeks ago
delete branch
0xmohit delete branch patch-1
Created at 3 weeks ago
pull request opened
don't assume uname in /usr/bin/

uname exists in /bin on Ubuntu. As such, the installation fails.

The script determines the OS without specifying the complete path to uname. Do the same in order to determine ARCH.

Created at 3 weeks ago

don't assume uname in /usr/bin/

uname exists in /bin on Ubuntu. As such, the installation fails.

The script determines the OS without specifying the complete path to uname. Do the same in order to determine ARCH.

Created at 3 weeks ago
Created at 3 weeks ago
pull request opened
don't assume uname in /usr/bin/

uname exists in /bin on Ubuntu. As such, the installation fails.

The script determines the OS without specifying the complete path to uname. Do the same in order to determine ARCH.

Created at 3 weeks ago